[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Add select encoding in Control Center (for CVS HEAD)
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-09-29 9:55:01
[Download RAW message or body]

On Friday 28 September 2001 19:41, Lukas Tinkl wrote:
> Hi, thanks a lot -- it looks good. I already fixed the other part of the
> bug in KLocale, so you should be now able to input any character, even
> without your patch -- KDE will fallback to Qt's default encoding, as that's
> always more intelligent. (see QTextCodec::codecForLocale() or sth like that
> :)
>
> Please try to update kdelibs/kdecore to see if my patch helps you, I'd
> really like to know that. Please note that this fallback solution in
> KLocale will be in effect only if the user hadn't saved the MIBEnum before.

I tried your patch. works fine. :) I think your patch OK to a KDE user of 99%.
Because there is hardly a user changing default encoding.
My patch is for a KDE user of 1%. ;-)

> Oh, now I see that you save the value "EncodingMib" ... hmm, please consult
> this patch with Hans-Petter Bieker, I can't comment on this because I don't
> have CVS sources here at the moment. I _guess_ that KLocale saves/loads
> "MIBEnum", but I may be wrong. So we rather wait what Hans-Petter says
> before committing.

Ok.

Thank you.
-- 
Toshitaka Fujioka
http://www.kde.org                The K Desktop Environment Project
                                                    fujioka@kde.org
http://www.kde.gr.jp               Japan KDE User's Group
                                                    toshitaka@kde.gr.jp

-- We offer the best Desktop Environment to you.  (This is my goal. ;-)) --     

[prev in list] [next in list] [prev in thread] [next in thread]