[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Add select encoding in Control Center (for CVS HEAD)
From:       Lukas Tinkl <lukas () kde ! org>
Date:       2001-09-28 10:41:44
[Download RAW message or body]

Dne èt 27. záøí 2001 17:55 Toshitaka Fujioka napsal(a):
> Hello,
>
> This patch can select Encoding with Control Center.
> Fix some i18n bugs when you set Encoding.
> BUG:
> 1. I can not display non-latin1 character of local directory and file
> justly. 2. I can not input Japanese.
>   .
>   .
>
> Please select "Control Center -> Personalization -> Country & Language ->
> Encoding -> Your encoding".
>
> Please review.

Hi, thanks a lot -- it looks good. I already fixed the other part of the bug 
in KLocale, so you should be now able to input any character, even without 
your patch -- KDE will fallback to Qt's default encoding, as that's always 
more intelligent. (see QTextCodec::codecForLocale() or sth like that :)

Please try to update kdelibs/kdecore to see if my patch helps you, I'd really 
like to know that. Please note that this fallback solution in KLocale will be 
in effect only if the user hadn't saved the MIBEnum before.

Oh, now I see that you save the value "EncodingMib" ... hmm, please consult 
this patch with Hans-Petter Bieker, I can't comment on this because I don't 
have CVS sources here at the moment. I _guess_ that KLocale saves/loads 
"MIBEnum", but I may be wrong. So we rather wait what Hans-Petter says before 
committing.

Bye,
-- 
Lukas Tinkl | lukas@kde.org
KDE i18n maintainer
http://www.kde.org/international/czechia

[prev in list] [next in list] [prev in thread] [next in thread]