[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Patch for kde-ice to remove warnings
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-09-28 6:33:37
[Download RAW message or body]

On Thursday 27 September 2001 10:05 pm, George Staikos wrote:
> I just got fed up with all the warnings in kde-ice so I made a patch which
> cleans up many of them (and perhaps makes the code a tiny bit safer?). 
> This patch is only for one file (process.c -- the worst offender) and there
> are still warnings left.  These were the easiest to fix (and by far the
> bulk of them too).
>
> I haven't tried _running_ with this yet because I'm compiling on my laptop
> which takes forever.  It does compile fine though, and the changes are very
> minor as you can see.  I'd appreciate it if someone could review it for
> applications to 2_2 branch and HEAD.

If it doesn't fix a bug it shouldn't go into 2.2. Code cleanup can go in HEAD 
but not in the stable branch.

Cheers,
Waldo
-- 
bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]