[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-community
Subject: Re: [kde-community] What is a GitHub pull request exactly?
From: Jaroslaw Staniek <staniek () kde ! org>
Date: 2015-09-20 10:21:20
Message-ID: CAOj7QQ0YPTazScz=Z=FjB=T95oopNXHDoJ4RCEk0oB8Vwapjsw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Sunday, 20 September 2015, Sune Vuorela <nospam@vuorela.dk> wrote:
> On 2015-09-20, Kevin Krammer <krammer@kde.org> wrote:
>> First, I have no idea where this "use github for review" comes from at =
>> all.
>> Who wants to do that in the first place?
>
> The github pull requests comes automatically with review abilities, so
> once it is there and one already interacts with github, it is the simple
> thing to do.
But effectively it won't be reviews because the KDE reviewers won't use it.
Or do you think we need some dracon law because our community cannot do
self-control?
Similarly kde.org has paste.kde.org. Hell, it's sometimes used for quick
reviews. But apparently does not replace the official tools.
>
> /Sune
>
> _______________________________________________
> kde-community mailing list
> kde-community@kde.org
> https://mail.kde.org/mailman/listinfo/kde-community
--
regards, Jaroslaw Staniek
KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
[Attachment #5 (text/html)]
<br><br>On Sunday, 20 September 2015, Sune Vuorela <<a \
href="mailto:nospam@vuorela.dk">nospam@vuorela.dk</a>> wrote:<br>> On \
2015-09-20, Kevin Krammer <<a \
href="mailto:krammer@kde.org">krammer@kde.org</a>> wrote:<br>>> First, I \
have no idea where this "use github for review" comes from at =<br>>> \
all.<br>>> Who wants to do that in the first place?<br>><br>> The github \
pull requests comes automatically with review abilities, so<br>> once it is there \
and one already interacts with github, it is the simple<br>> thing to \
do.<br><br>But effectively it won't be reviews because the KDE reviewers \
won't use it. Or do you think we need some dracon law because our community \
cannot do self-control?<br><br>Similarly <a href="http://kde.org">kde.org</a> has <a \
href="http://paste.kde.org">paste.kde.org</a>. Hell, it's sometimes used for \
quick reviews. But apparently does not replace the official tools. \
<br><br>><br>> /Sune<br>><br>> \
_______________________________________________<br>> kde-community mailing \
list<br>> <a href="mailto:kde-community@kde.org">kde-community@kde.org</a><br>> \
<a href="https://mail.kde.org/mailman/listinfo/kde-community">https://mail.kde.org/mailman/listinfo/kde-community</a><br><br>-- \
<br>regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software \
engineers, artists, writers, translators<br>: and facilitators committed to Free \
Software development - <a href="http://kde.org" \
target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office \
suite - <a href="http://calligra.org" \
target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder \
- <a href="http://calligra.org/kexi" \
target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a \
href="http://www.linkedin.com/in/jstaniek" \
target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
[Attachment #6 (text/plain)]
_______________________________________________
kde-community mailing list
kde-community@kde.org
https://mail.kde.org/mailman/listinfo/kde-community
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic