[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kdeui
From:       Michael Brade <Michael.Brade () informatik ! uni-muenchen ! de>
Date:       2001-07-31 22:50:35
[Download RAW message or body]

On Wednesday 01 August 2001 00:32, CVS by brade wrote:
> For the first time David's analysis of a problem was wrong ;-)
> I just got a mail from AleXXX with bugreport #29530 (as I found out
> by comparing the time...) with the following reason:
>
> If selectCurrentItemAndEnableSelectedBySimpleMoveMode() was called (which
> only the textview does) KListView::focusOutEvent deselects the current
> item, regardless of how many items are selected.
> KListView::focusInEvent does nearly the same, it just selects the
> current item. So if you have now the sidebar enabled and select a
> directory to display in the textview the textview has no focus yet.
> Clicking on an item in the textview, holding down the control button, leds
> to a focusInEvent selecting the current item (the first one) and the
> LMB+Ctrl then selects the second one.
>
> The problem: if you scroll down first, there is no focusInEvent,
> so you won't realize the first item gets selected.
> Clicking now on an item while pressing Ctrl... well, see #29530 ;)
>
> Fixed with this commit. Waldo, if possible, please move the tag. I think
> it's really important for the textview!
Shit, I just got a mail from AleXXX telling me this is not the fix he'd like 
to see because (de)selecting items on focusIn/focusOut makes visible which 
Konqy has focus much easier if you have two windows open and switch between 
them with Alt-Tab.

It would be better to test if some items got automatically selected and 
deselect them on mouse events first. Hmm, sounds like quite a bit of 
hacking... And I find my fix much more logical, but anyways, just my $0.02.

I definitely need some sleep now, so if someone thinks this is really 
important please revert - or just leave the tag as it is now, I don't know.

Ciao,
  Michael

-- 

       Some operating systems are called `user friendly',
             Linux however is `expert friendly'.

[prev in list] [next in list] [prev in thread] [next in thread]