[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-05-31 20:48:03
[Download RAW message or body]

On Thursday 31 May 2001 13:30, George Staikos wrote:
> On Thursday 31 May 2001 15:47, Waldo Bastian wrote:
> > On Thursday 31 May 2001 09:48, CVS by staikos wrote:
> > > kdelibs/kio scheduler.cpp,1.61,1.62
> > > Author: staikos
> > > Thu May 31 16:47:54 UTC 2001
> > >
> > >
> > > Modified Files:
> > >          scheduler.cpp
> > > Log Message:
> > > This seems to fix the assert failures without problem.  I really doubt
> > > these were necessary at all.
> >
> > They aren't necassery but they indicate a design problem, e.g. they
> > shouldn't happen, and when they happen something is wrong.
> >
> > It's like the fuses in your house, aluminum foil works wonders there, but
> > you really don't want to do that.
>
> One of them already had code to handle the case that was being asserted.

Yes, i know, but I still would like to know why the assert gets hits. Hitting 
the assert means "The slave is idle and it doesn't exist." Well, that's 
wrong.. if it is idle it does exist. If it doesn't exists, it isn't idle.

> In any case, there are problems.

Yes, see above.

> Now metadata doesn't get out to the SSL messageBox() and infact causes an 
> assert failure in observer.cpp.

I don't think metadata will be handled from messageBox() at all actually. 
Normally metaData() gets send before a request is send to a slave, and a 
slave sends metadata back before it responds. "messageBox" is not considered 
a response. Talking about metaData.. in which direction are we talking? 
slave->app or app->slave?

Cheers,
Waldo
-- 
bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]