[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kio
From:       Michael Brade <Michael.Brade () informatik ! uni-muenchen ! de>
Date:       2001-04-30 20:40:58
[Download RAW message or body]

On Monday 30 April 2001 22:13, CVS by hausmann wrote:
> kdelibs/kio kdirlister.cpp,1.55,1.56
> Author: hausmann
> Mon Apr 30 20:13:46 UTC 2001
> In directory cvs.kde.org:/var/tmp/cvs-serv15425
>
> Modified Files:
> 	kdirlister.cpp
> Log Message:
> - behave the same as in the KDE2_1_BRANCH and in previous kde2 releases,
>   where openURL() changed the dirlister's url
>   (the dirtree in konqueror relies on that, otherwise you get those
>    endlessly rotating wheels :) , and while one could probably hack the
>    dirtree to match the new behaviour IMHO we should not break the old
>    one, to avoid the risk of breaking 3rd party applications)
>
> @@ -155,8 +155,7 @@ void KDirLister::openURL( const KURL& _u
>      return;
>    }
>
> -  if ( m_url.isEmpty() || !_keep )
> -    m_url = _url;     // the root
> +  m_url = _url;
Please don't, this is a very bad design. If KDirLister is listing two or more 
dirs at the moment you'll always return the dir of the last started job like 
this. So this will break the treeview as well....

As for the 3rd pary applications I'm *VERY* sure nobody ever used the 
KDirLister in a way that this change will break something. The docu of 
KDirLister::url() explicitely said it will return the root of the currently 
listed directories - it won't anymore with this change and I consider that a 
bug.

So I will revert this change after I hacked the treeview to be able to list 
more directories at once, so nobody will ever see the nonstop spinning wheel 
again ;-) And btw, it worked for me...

Ciao,
  Michael

-- 

       Some operating systems are called `user friendly',
             Linux however is `expert friendly'.

[prev in list] [next in list] [prev in thread] [next in thread]