[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml/xml
From:       Tobias Anton <anton () stud ! fbi ! fh-darmstadt ! de>
Date:       2001-04-01 15:57:12
[Download RAW message or body]

On Saturday 31 March 2001 13:19, Dirk Mueller wrote:
> Moin Tobias!
>
> > Why does the m_styleDecls->setParent(0) fix a memory leak? How does the
> > fix work?
>
> CSS Declarations are not deleted if they're still part of the CSS tree.
> That means all of our autogenerated stylesheets happily leaked while
> browsing.
I see. What i don't understand yet is why the memory was leaking out of the X 
server.
You described it right, it was leaking with lightspeed. I had an increase of 
about 10 MB (!) mem usage of the X server everytime i reloaded a small HTML 
page with a background gif (compressed size: <10Kbytes, 1600x1200 pixels). 
That looked more like leaking server side images rather than stylesheet 
declarations.

> > I'd love to see this fix in the 2.1 branch.
>
> Well, there was a purpose for not backporting it. But I agree, it turned
> out to be quite stable. We just don't have to forget that if we run into a
> problem in HEAD that we have the problem then in the branch too.
Huh? What was the purpose?
I consider it essential to backport this one, for the above reason.
So, are there still serious objections left against backporting?

Cheers,
Tobias

[prev in list] [next in list] [prev in thread] [next in thread]