[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdenetwork/kmail
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2000-12-31 16:59:59
[Download RAW message or body]

On Sunday, 31. December 2000 17:16, CVS by antlarr wrote:
> kdenetwork/kmail kmcomposewin.cpp,1.298,1.299
> Author: antlarr
> Sun Dec 31 16:16:33 UTC 2000
> In directory cvs.kde.org:/tmp/cvs-serv20471
>
> Modified Files:
> 	kmcomposewin.cpp
> Log Message:
> Fixed a problem that could result in a corrupted mbox.
> When a line in the body of a msg starts with "From ", and there's no
> index file, it could be interpreted as a start of another msg, so it
> must be changed to something like " From " (Netscape and Pine use
> ">From", but I've preferred a blank space because it seems less intrusive)

Sorry, but this change is simply wrong.
It is not correct to modify the text the user entered. If there is really a 
problem with mbox format somewhere, then it has to be fixed at the place 
where the mbox file is written, but AFAIK this is done correctely in KMail. 
At least I never heard of a problem with that in the last months.
The case that a mail comes in via the net is anyway not handled by this 
change.
I reverted the commit.

Also I think, it would be nice if people that don't read our mailinglist and 
don't know what's up announce their changes first.

Regards,
Michael Häckel

[prev in list] [next in list] [prev in thread] [next in thread]