[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/desktop
From:       Antonio Larrosa <antlarr () arrakis ! es>
Date:       2000-10-08 11:27:18
[Download RAW message or body]

CVS by coolo wrote:
> 
> kdebase/kcontrol/desktop desktop.cpp,1.9,1.10
> Author: coolo
> Fri Oct  6 19:34:41 UTC 2000
> 
> Modified Files:
>         desktop.cpp
> Log Message:
> Brad says the NET_WM don't support setting names of newly created desktops.
> So we first increase the desktop number and then change the names - which lets
> the pager resize twice, but I didn't made up the NET_WM specs ;(
> 
>    NETRootInfo info( qt_xdisplay(), NET::NumberOfDesktops | NET::DesktopNames );
>    info.setNumberOfDesktops(_numSlider->value());
> +  XSync(qt_xdisplay(), FALSE);
> +  info.activate();
> 
>    // set desktop names
>    for(int i = 1; i <= 16; i++)

Now that we're at it, what do you think about changing
KWinModulePrivate::x11Event( XEvent * ev )  in kwinmodule.cpp
to emit first the numberOfDesktopsChanged signal and then the
desktopNamesChanged signal, instead of in the other way as it's
doing now ?

-       if ( m & DesktopNames )
-           for ( module = modules.first(); module; module =
modules.next() )
-               emit module->desktopNamesChanged();
        if ( m & NumberOfDesktops )
            for ( module = modules.first(); module; module =
modules.next() )
                emit module->numberOfDesktopsChanged( numberOfDesktops()
);  
+       if ( m & DesktopNames )
+           for ( module = modules.first(); module; module =
modules.next() )
+               emit module->desktopNamesChanged();

Wouldn't that make sense ?

Greetings,

--
Antonio Larrosa Jimenez
KDE core developer
antlarr@arrakis.es        larrosa@kde.org
http://www.arrakis.es/~rlarrosa
KDE - The development framework of the future, today.

[prev in list] [next in list] [prev in thread] [next in thread]