[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdeutils/karm
From:       blackie () kde ! org (Jesper K !  Pedersen)
Date:       2000-08-01 6:11:37
[Download RAW message or body]

Antonio Larrosa <larrosa@suse.de> writes:

| Well, that file uses extensively QString::fromLatin1 to convert char *
| to QString. for example: createGUI( QString::fromLatin1("karmui.rc") );
| 
| If you just leave createGUI( "karmui.rc" ); (as in every other place in
| KDE), you get compiler errors because there seems to be no "implicit"
| QString constructor that takes just a char *  (!?!?)
| 
| So it seems to me that there's some kind of header files problem.
| 
| Anyway, if you're mantaining this app, I'll just leave the problem for
| you (Ok, it wasn't a bugfix, but it was a "maintenance fix" :) )

All these QString::fromLatin1 was introduced by bieker as you can see
from the following check in message:
  revision 1.38
  date: 2000/06/28 21:14:50;  author: bieker;  state: Exp;  lines: +32 -24
  * strict compilation - fixing some unicode problems
  * someone forgot to i18n() some strings... (that's easy to catch with
    QT_NO_CAST_ASCII :-)

The reason why it doesn't compile without, is the existence of the
following line in Makefile.am:
  ############ Autoconf-generated variables  ###################
  AM_CPPFLAGS = -DQT_NO_ASCII_CAST -DQT_NO_CAST_ASCII

Don't ask my why its there twice, not dont ask me if this is the  origin of
the settings, or as the header says, it is generated from somewhere else.

BIEKER: Why did you introduce QString::fromLatin1 in the first place? Is
this agreed upon that we should make such changes to all KDE apps.?

Kind Regards Jesper.

[prev in list] [next in list] [prev in thread] [next in thread]