[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/kcontrol/kio
From:       Simon Hausmann <shaus () helios ! Med ! Uni-Magdeburg ! DE>
Date:       2000-07-29 6:22:06
[Download RAW message or body]



On Fri, 28 Jul 2000, Dawit Alemayehu wrote:

> On Fri, 28 Jul 2000, you wrote:
> > kdebase/kcontrol/kio useragentdlg.cpp,1.11,1.12
> >  Author: hausmann
> >  CVSROOT: /home/kde
> >  Fri Jul 28 09:36:30 UTC 2000
> >  Update of /home/kde/kdebase/kcontrol/kio
> >  cvs.kde.org hosted by sourceforge.net
> >  
> >  Modified Files:
> >  	useragentdlg.cpp 
> >  Log Message:
> >  - replacing DEFAULT_USERAGENT_STRING with 
> >    KProtocolManager::userAgentForHost( QString::null )
> >    not sure if that's the right fix, but at least it compiles
> 
> Well this would work.  Since no match will be found for a null string the
> default agent string will be returned.  However, this seems to be too much
> work just to get the default agent string so I tried compiling myself.  Low and
> behold I got the same result!!  When I took a peak at the kprotocolmanager.h
> file installed in /opt/kde2/include and it was the old one :((  Unfortunately I
> cannot compile kdelibs/kio at the moment because of all the work I am doing on
> the caching stuff ; so I cannot attempt to test if this file is properly
> installed. Anyways, when I manually copied the modified kprotocolmanager.h
> file to /opt/kde2/bin, kdebase/kcontrol/kio compiled flawlessly.  Could it be
> that Simon did not compile kdelibs or forgot to install kdelibs before
> compiling kdebase after the update ??

Yes, you are right. I forgot a -A in my .cvsrc for cvs update on the
machine I was running the update on. That's why kprotocolmanger was still
in kdecore and that's why it lacked the default useragent string.

I apologize for the trouble. I'll revert my commit.

Bye,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]