[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kde-common/admin
From:       Michael Matz <matzmich () cs ! tu-berlin ! de>
Date:       2000-05-01 0:23:45
[Download RAW message or body]

Hi,

On Mon, 1 May 2000 kde-cvs@kde.org wrote:
>  > How lucky, that configure (and the old autoconf macro) uses
>  > INSTALL_DATA = '${INSTALL} -m 644'
>  > 
>  > Note that $INSTALL gets not expanded in the AC_PROG_INSTALL macro, but in
>  > the Makefile, so I only need to change $INSTALL, and its taken up by all
>  > Makefiles. Or what do you mean? At least for me I get in my Makefiles:
>  > 
>  > INSTALL = /usr/bin/install -c -p
>  > INSTALL_PROGRAM = ${INSTALL}
>  > INSTALL_DATA = ${INSTALL} -m 644
>  > INSTALL_SCRIPT = ${INSTALL_PROGRAM}
>  > 
>  > (May be it gets confused because you have INSTALL_DATA=... in your
>  > startup-scripts?) Or was it a feature request?
>  > 
>  Well, it wasn't my bug report, that make install-strip is broken because
>  it sets INSTALL_PROGRAM to INSTALL -s and then INSTALL_SCRIPT is broken

I have reviewed the bug-report. The only possibility is that he used
another automake version than me. Because my install-strip target only
does a "$(MAKE) $(AM_MAKEFLAGS) INSTALL_STRIP_FLAG=-s install" and
INSTALL_PROGRAM is set as above, it doesn't even care about that flag.

Rather my automake tries to write "install-@DIR@PROGRAMS" targets, which
use that flag like "@LIBTOOL --mode=install@ $(INSTALL_PROGRAM)
$(INSTALL_STRIP_FLAG)", but currently KDE is not using (for whatever
reason, I just noticed) or even emitting these targets.

So at least my version of automake has not that problem of using -s in
INSTALL_SCRIPT, but KDE currently does not the right thing to activate
that use, while his version is clearly incompatible with autoconf.

In another bugreport I saw a line like "INSTALL_PROGRAM=${INSTALL}
${AM_BLA_FLAG}" (automake there was 1.4), which of course blows up
INSTALL_SCRIPT. (my automake version: 1.4a) If we can come up with a
variable name which contains "-s" in case of install-strip, I can paper
over that mess in our AC_PROG_INSTALL. (I would even use
"$(AM_INSTALL_PROGRAM_FLAGS) $(INSTALL_STRIP_FLAG)" to respect
install-script targets emitted by both automake 1.4 and 1.4a, so do you
have other flags INSTALL_PROGRAM should include?)


Ciao,
Michael.

[prev in list] [next in list] [prev in thread] [next in thread]