[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror/iconview
From:       Reginald Stadlbauer <reggie () troll ! no>
Date:       1999-12-12 14:17:42
[Download RAW message or body]

On Sun, 12 Dec 1999, David Faure wrote:
>On Sun, Dec 12, 1999 at 02:19:03PM +0100, Reginald Stadlbauer wrote:
>> On Sun, 12 Dec 1999, CVS by faure wrote:
>> >kdebase/konqueror/iconview konq_iconview.cc,1.165,1.166
>> >Author: faure
>> >CVSROOT: /home/kde
>> >Sun Dec 12 14:31:13 MET 1999
>> >Update of /home/kde/kdebase/konqueror/iconview
>> >In directory zeus:/tmp/cvs-serv23246
>> >
>> >Modified Files:
>> >	konq_iconview.cc 
>> >Log Message:
>> >Avoid calling AlignItemsInGrid when it's useless (image preview on, but
>> >no image in the current dir). Fixes flicker.
>> >
>> >Still a strange flicker in image preview mode when there are images, though.
>> >(Looks like alignItemsInGrid does it twice, first with no sorting ??)
>> 
>> No, sort does an alignItemsInGrid, but alignItemsInGrid doesn't know anything
>> about sorting. As it only happens in konqy in imagePreview mode, it looks like
>> konqy calls it one time too often.
>
>Well, it's for sure that alignItemsInGrid called when all mimetypes
>are found, that causes this flicker (I've tried without it).
>But without it, we have the "images overlap text" bug.

You mean only in imagePreviewMode, right?

>The problem isn't exactly calling alignItemsInGrid too often, it's more
>that .. when it's called from processMimeTypesSomething, the sorting
>isn't right yet.
>Where/when is the sorting done ? Isn't it done at the same time the
>icons are inserted ??

More or less, yes. If I think about it, I think we have to live with one
flicker in the image preview stuff - or maybe not... Well I'll look at it
tonight, maybe I can find something somewhere :-))

-- 
Reggie

[prev in list] [next in list] [prev in thread] [next in thread]