[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/corba/cuteidl
From:       David Faure <faure () kde ! org>
Date:       1999-09-20 23:31:51
[Download RAW message or body]

On Mon, Sep 20, 1999 at 11:23:56PM +0000, David Faure wrote:
> On Tue, Sep 21, 1999 at 12:18:43AM +0200, Lars Knoll wrote:
> > On Mon, 20 Sep 1999, CVS by dfaure wrote:
> > 
> > > 
> > > kdelibs/corba/cuteidl codegen-qt-common.cc,1.4,1.5
> > > Author: dfaure
> > > CVSROOT: /home/kde
> > > Mon Sep 20 23:58:22 MET DST 1999
> > > Update of /home/kde/kdelibs/corba/cuteidl
> > > In directory zeus:/tmp/cvs-serv710
> > > 
> > > Modified Files:
> > > 	codegen-qt-common.cc 
> > > Log Message:
> > > Fixed typedefs for string and wstring. Great news : my kded compiles with cuteidl !
> > > 
> > Great to hear! Does it work too??? ;-)
> 
> Yes !
> Would you believe it ? :)))

I've started on kom.
It's unbelievable the great simplifications this allows.
The best example :

-KOM::Base::RelativesSeq* KOMBase::describeRelatives()
-{
-  KOM::Base::RelativesSeq* seq = new KOM::Base::RelativesSeq;
-  int i = 0;
-  seq->length( i );
-
-  QValueList<KOM::Base_var>::Iterator it = m_lstRelatives.begin();
-  for( ; it != m_lstRelatives.end(); ++it )
-  {
-    seq->length( i + 1 );
-    (*seq)[i++] = *it;
-  }
-
-  return seq;
 }  

All removed, and turned into the inline
 KOM::Base::RelativesSeq describeRelatives() { return m_lstRelatives; }  


I love it !

We win on simplicity (for non-CORBA gurus), on speed (a lot of conversions removed)
and on memory usage (useless code removed, and less data necessary : no conversion = sharing 
the same object instead of copying/converting)

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://www.insa-lyon.fr/People/AEDI/dfaure/index.html 
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]