[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       Simon Hausmann <tronical () gmx ! net>
Date:       1999-08-02 20:26:41
[Download RAW message or body]

On Mon, 2 Aug 1999, Matthias Elter wrote:

> On Mon, 02 Aug 1999, Harri Porten wrote:
> > Matthias Elter wrote:
> > > 
> > > On Mon, 02 Aug 1999, Harri Porten wrote:
> > > > CVS by elter wrote:
> > > > >
> > > > > Modified Files:
> > > > >         konq_iconview.cc
> > > > > Log Message:
> > > > > - m_mouseMode = settings->mouseMode();
> > > > > + m_mouseMode = (KIconContainer::MouseMode) settings->mouseMode();
> > > > >
> > > > > to make gcc2.95 happy
> > > >
> > > > Yes, it makes the compiler happy but should strike the programmer as
> > > > error prone. It's a potential bug and should be fixed correctly.
> > > 
> > > It's the same enum but in different name spaces. Why is it a potential bug to
> > > cast it?
> > 
> > Because it's only the same enum *now*. They live in different places,
> > though, and if one day someone has the idea to change one of them
> > without knowing of the other: Bang !
> 
> Yes I see, but this should be fixed by one of the konqy developers. The
> problems afaik result from Simon moving the enum to two .h files to get rid of
> mousemode.h.

Nono, it wasn't me :-)

The problem already existed in mousemode.h.

I just moved the stuff into konq_defs.h to sort things a little bit and to
have a place where to put the RowInfo declarations, so that
konq_childview.h didn't need to include konq_viewgr.h. The advantage is
that when I changed a little thing in konq_viewmgr.h, I don't need to
recompile all shit including konq_childview.h :-)

Bye,
 Simon

[prev in list] [next in list] [prev in thread] [next in thread]