[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/corba/kded
From:       Simon Hausmann <tronical () gmx ! net>
Date:       1999-05-27 23:03:43
[Download RAW message or body]

On Thu, 27 May 1999, CVS by dfaure wrote:

> 
> kdelibs/corba/kded kded-server.cc,1.2,1.3 ktrader.h,1.6,1.7
> Author: dfaure
> CVSROOT: /home/kde
> Thu May 27 22:42:00 MET DST 1999
> Update of /home/kde/kdelibs/corba/kded
> In directory zeus:/tmp/cvs-serv3436
> 
> Modified Files:
> 	kded-server.cc ktrader.h 
> Log Message:
> Another ref-count bug (services returned were deleted !!)
> -  typedef const KSharedPtr<KService> ServicePtr
> +  typedef const KService * ServicePtr
> 
> Services exist in the registry, we just borrow
> the pointer from it. No need for KSharedPtr I think.

Hm, I'm not sure about this.

a) We don't borrow pointers in case of the remote trader (and the remote
trader is used always, from the client's side) .

b) Usually the returned references shouldn't get deleted, because
KServiceEntry _should_ still reference the KService object..
Unfortunately it doesn't, so that's where I think is the bug.

but I might be wrong :-)

Ciao,
  Simon

(P.S.: David - jump on irc, so I can tell you what I thinking of :)
      (/me is too lazy to write this now)

--
Simon Hausmann       <hausmann@kde.org>
http://www.kde.org/  <tronical@gmx.net>

[prev in list] [next in list] [prev in thread] [next in thread]