From kde-commits Wed May 26 11:08:07 1999 From: David Faure Date: Wed, 26 May 1999 11:08:07 +0000 To: kde-commits Subject: Re: kdenetwork/kbiff X-MARC-Message: https://marc.info/?l=kde-commits&m=92771623014808 On Wed, May 26, 1999 at 12:06:17PM +0200, Stephan Kulow wrote: > > Oops, my fault then. This icon stuff is pretty confusing. > That's why I cleared it and cleaned up the API while I was at it. Yes, but I think we might clear it even more. > The large thing is another interesting example. It has been a hack > and shouldn't really be in KIconLoader anymore. Yes, it had to be a hack so that it would remain binary compatible in 1.1.x I totally agree with you (and Taj who commented in the sources :) that we should do it better in HEAD. BUT : I don't really know how. Hmm, perhaps the app could handle it itself and call insertDir to insert the "large/" ones (oh, I could have done it this way in 1.1.x ! Though my patch touched only kiconloader which was nice too) but we still need something in kiconloader for the other apps (the default value, the one that KDEIconStyle contains) > > This should be loadApplicationIcon, then ? > Right. Or just use KApplication::getApplicationIcon, which should > exactly this for you. You see ? Again two ways to do the same thing. :) -- David FAURE david.faure@insa-lyon.fr, faure@kde.org http://www.insa-lyon.fr/People/AEDI/dfaure/index.html KDE, Making The Future of Computing Available Today