[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace/Plasma/5.14] applets/mediacontroller/contents/ui: [Media Controller] Emit moved() 
From:       Kai Uwe Broulik <null () kde ! org>
Date:       2018-09-26 15:33:54
Message-ID: E1g5Bp4-00056o-3U () code ! kde ! org
[Download RAW message or body]

Git commit 23d16f9687c49b00218470c8d12eb0d84e941ada by Kai Uwe Broulik.
Committed on 26/09/2018 at 15:32.
Pushed by broulik into branch 'Plasma/5.14'.

[Media Controller] Emit moved() signal when seeking with keyboard shortcuts

In QtQuick Controls 2 (Plasma Components 3) there's separate signals for when the \
slider's value changes "on its own" or by explicit user interaction. Pressing a \
keyboard shortcut changes the value but doesn't cause the move signal to be emitted. \
Do this explicitly now.

M  +5    -0    applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

https://commits.kde.org/plasma-workspace/23d16f9687c49b00218470c8d12eb0d84e941ada

diff --git a/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml \
b/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml index \
                75939192..ff445163 100644
--- a/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
+++ b/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
@@ -103,16 +103,21 @@ Item {
             } else if (event.key === Qt.Key_Left || event.key === Qt.Key_J) { // \
TODO ltr languages  // seek back 5s
                 seekSlider.value = Math.max(0, seekSlider.value - 5000000) // \
microseconds +                seekSlider.moved();
             } else if (event.key === Qt.Key_Right || event.key === Qt.Key_L) {
                 // seek forward 5s
                 seekSlider.value = Math.min(seekSlider.to, seekSlider.value + \
5000000) +                seekSlider.moved();
             } else if (event.key === Qt.Key_Home) {
                 seekSlider.value = 0
+                seekSlider.moved();
             } else if (event.key === Qt.Key_End) {
                 seekSlider.value = seekSlider.to
+                seekSlider.moved();
             } else if (event.key >= Qt.Key_0 && event.key <= Qt.Key_9) {
                 // jump to percentage, ie. 0 = beginnign, 1 = 10% of total length \
                etc
                 seekSlider.value = seekSlider.to * (event.key - Qt.Key_0) / 10
+                seekSlider.moved();
             } else {
                 event.accepted = false
             }


[prev in list] [next in list] [prev in thread] [next in thread]