[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [discover/Plasma/5.14] libdiscover/backends/FwupdBackend: fwupd: Properly scope error variable
From:       Aleix Pol <null () kde ! org>
Date:       2018-09-25 7:42:47
Message-ID: E1g4hzb-0001qh-9Z () code ! kde ! org
[Download RAW message or body]

Git commit 1eeff2c00ad4ad158770430d71f75c9ffdbb772e by Aleix Pol.
Committed on 25/09/2018 at 07:40.
Pushed by apol into branch 'Plasma/5.14'.

fwupd: Properly scope error variable

Otherwise it complains nasty

M  +1    -2    libdiscover/backends/FwupdBackend/FwupdBackend.cpp

https://commits.kde.org/discover/1eeff2c00ad4ad158770430d71f75c9ffdbb772e

diff --git a/libdiscover/backends/FwupdBackend/FwupdBackend.cpp \
b/libdiscover/backends/FwupdBackend/FwupdBackend.cpp index ee56500d..1806c856 100644
--- a/libdiscover/backends/FwupdBackend/FwupdBackend.cpp
+++ b/libdiscover/backends/FwupdBackend/FwupdBackend.cpp
@@ -191,7 +191,6 @@ void FwupdBackend::populate()
 void FwupdBackend::addUpdates()
 {
     g_autoptr(GError) error = nullptr;
-    g_autoptr(GError) error2 = nullptr;
     g_autoptr(GPtrArray) devices = fwupd_client_get_devices(client, nullptr, \
&error);  
     if (!devices)
@@ -224,7 +223,7 @@ void FwupdBackend::addUpdates()
         if (!fwupd_device_has_flag(device, FWUPD_DEVICE_FLAG_UPDATABLE))
             continue;
 
-
+        g_autoptr(GError) error2 = nullptr;
         g_autoptr(GPtrArray) rels = fwupd_client_get_upgrades(client, \
fwupd_device_get_id(device), nullptr, &error2);  if (rels) {
             fwupd_device_add_release(device, (FwupdRelease *)g_ptr_array_index(rels, \
0));


[prev in list] [next in list] [prev in thread] [next in thread]