[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [zanshin] src/presentation: Fix two "TODO Qt5" comments
From:       David Faure <null () kde ! org>
Date:       2018-09-22 10:42:49
Message-ID: E1g3fNB-0000e9-JN () code ! kde ! org
[Download RAW message or body]

Git commit ff8a82fbaa72c1da36823835de308342032f3e56 by David Faure.
Committed on 22/09/2018 at 10:42.
Pushed by dfaure into branch 'master'.

Fix two "TODO Qt5" comments

M  +1    -2    src/presentation/availablesourcesmodel.cpp
M  +0    -3    src/presentation/querytreemodelbase.h

https://commits.kde.org/zanshin/ff8a82fbaa72c1da36823835de308342032f3e56

diff --git a/src/presentation/availablesourcesmodel.cpp b/src/presentation/availablesourcesmodel.cpp
index 6c0fceb0..96e07316 100644
--- a/src/presentation/availablesourcesmodel.cpp
+++ b/src/presentation/availablesourcesmodel.cpp
@@ -150,8 +150,7 @@ void AvailableSourcesModel::emitDefaultSourceChanged(const QModelIndex &root)
     const auto rowCount = m_sourceListModel->rowCount(root);
     for (int row = 0; row < rowCount; row++) {
         const auto index = m_sourceListModel->index(row, 0, root);
-        // TODO Qt5: Remove static_cast
-        emit static_cast<QueryTreeModelBase*>(m_sourceListModel)->dataChanged(index, index);
+        emit m_sourceListModel->dataChanged(index, index);
         emitDefaultSourceChanged(index);
     }
 }
diff --git a/src/presentation/querytreemodelbase.h b/src/presentation/querytreemodelbase.h
index 95b3694e..eb90f35e 100644
--- a/src/presentation/querytreemodelbase.h
+++ b/src/presentation/querytreemodelbase.h
@@ -93,9 +93,6 @@ public:
     Qt::DropActions supportedDragActions() const Q_DECL_OVERRIDE;
     Qt::DropActions supportedDropActions() const Q_DECL_OVERRIDE;
 
-    // TODO Qt5: Remove but needed in Qt4, so that we can trigger it from the outside
-    using QAbstractItemModel::dataChanged;
-
 protected:
     explicit QueryTreeModelBase(QueryTreeNodeBase *rootNode,
                                 QObject *parent = Q_NULLPTR);
[prev in list] [next in list] [prev in thread] [next in thread]