[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [blinken] /: Use KDEFrameworkCompilerSettings + use nullptr
From:       laurent Montel <montel () kde ! org>
Date:       2018-09-24 11:38:40
Message-ID: 1562087.dkkqpI00YI () linux-zym0
[Download RAW message or body]

Le lundi 24 septembre 2018, 11:07:56 CEST Albert Astals Cid a écrit :
> El dilluns, 24 de setembre de 2018, a les 7:11:08 CEST, laurent Montel va 
escriure:
> > Le dimanche 23 septembre 2018, 19:37:11 CEST Albert Astals Cid a écrit :
> > > Can you fix the spacing, it seems you broke it.
> 
> Don't forget the spacing ↑

I didn't forgot it.

> 
> > > Also, why are you using *Frameworks* compiler settings in an
> > > application?
> > 
> > And what is the problem to use it ?
> > For me it avoids to duplicate add_definitions in each CMakeLists.txt.
> > for example "add_definitions(-DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT)"
> > which allows to test if connection between signal/slot can have a problem
> > or avoid to add add_definitions(-DQT_STRICT_ITERATORS) when we don't use
> > Debug mode as I saw in several package.
> > 
> > And add "QT_NO_CAST_*" allows to fix some optimizations.
> > 
> > it adds some gcc flags so we can fix some compile warnings
> > 
> > So now I don't see problem.
> 
> The problem is it is clearly named *Frameworks* compiler settings and I
> think it would be confusing for developers (that are not you (or me)) to
> see it used in applications.

I don't understand your problem here ???
apps is based on frameworks
so what is the problem ?

if a developper doesn't know what is this module he can see in ECM no ?



> 
> If Frameworks compiler settings has benefits over regular applications
> compiler settings i suggest adding those benefits to the applications file,

So creating another module where we will add this flags ? => duplicate file 
for it ?

and we can't move them to KDECompilerSettings as we will break all apps which 
doesn't support it.

> maybe hidden under a GIVE_ME_MORE_STRICT_SETTINGS flag.
> 
> Cheers,
>   Albert

Regards.

> > > Cheers,
> > > 
> > >   Albert


-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 


[prev in list] [next in list] [prev in thread] [next in thread]