[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [discover/Plasma/5.12] notifier: Fix showing update notification
From:       Kai Uwe Broulik <null () kde ! org>
Date:       2018-09-24 6:35:19
Message-ID: E1g4KSl-0002pe-3g () code ! kde ! org
[Download RAW message or body]

Git commit 8b2cf5d81a6133445e0bf838a7f6996391c5be8f by Kai Uwe Broulik.
Committed on 24/09/2018 at 06:34.
Pushed by broulik into branch 'Plasma/5.12'.

Fix showing update notification

It would check whether the old count was greater than or equal to the new count which \
is the wrong way round and as such the notification was never shown.

BUG: 396426
BUG: 390322
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D15682

M  +1    -1    notifier/DiscoverNotifier.cpp

https://commits.kde.org/discover/8b2cf5d81a6133445e0bf838a7f6996391c5be8f

diff --git a/notifier/DiscoverNotifier.cpp b/notifier/DiscoverNotifier.cpp
index f95be43d..8313d611 100644
--- a/notifier/DiscoverNotifier.cpp
+++ b/notifier/DiscoverNotifier.cpp
@@ -86,7 +86,7 @@ void DiscoverNotifier::updateStatusNotifier()
     if (m_count == count && m_securityCount == securityCount)
         return;
 
-    if (state() != NoUpdates && m_count >= count) {
+    if (state() != NoUpdates && count > m_count) {
         m_timer.start();
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]