[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [akonadi/Applications/18.08] src/core/jobs: Job tracker: fix expected reply signature, improve error
From:       David Faure <null () kde ! org>
Date:       2018-09-20 8:16:00
Message-ID: E1g2u80-0002Xo-FW () code ! kde ! org
[Download RAW message or body]

Git commit 5ada337059fa8ca8a2a3ad097f4627d1ccd512ee by David Faure.
Committed on 20/09/2018 at 08:15.
Pushed by dfaure into branch 'Applications/18.08'.

Job tracker: fix expected reply signature, improve error handling

We kept being disconnected from the jobtracker because of a signature
mismatch.

M  +4    -4    src/core/jobs/job.cpp

https://commits.kde.org/akonadi/5ada337059fa8ca8a2a3ad097f4627d1ccd512ee

diff --git a/src/core/jobs/job.cpp b/src/core/jobs/job.cpp
index 410c14136..5a5520ab7 100644
--- a/src/core/jobs/job.cpp
+++ b/src/core/jobs/job.cpp
@@ -151,11 +151,11 @@ void JobPrivate::signalCreationToJobTracker()
                                              << jobDebuggingString();
         QDBusPendingCall call = \
s_jobtracker->asyncCallWithArgumentList(QStringLiteral("jobCreated"), argumentList);  \
                
-
-        QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(call, q);
-        QObject::connect(watcher, &QDBusPendingCallWatcher::finished, q, \
                [](QDBusPendingCallWatcher *w) {
-                QDBusPendingReply<QString, QByteArray> reply = *w;
+        QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(call, \
s_jobtracker); +        QObject::connect(watcher, &QDBusPendingCallWatcher::finished, \
s_jobtracker, [](QDBusPendingCallWatcher *w) { +                \
QDBusPendingReply<void> reply = *w;  if (reply.isError() && s_jobtracker) {
+                    qDebug() << reply.error().name() << reply.error().message();
                     s_jobtracker->deleteLater();
                     s_jobtracker = nullptr;
                 }


[prev in list] [next in list] [prev in thread] [next in thread]