[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [kmymoney/5.0] kmymoney/mymoney: Add test for MyMoneyTransactionFilter
From: Ralf Habacker <null () kde ! org>
Date: 2018-09-20 20:10:14
Message-ID: E1g35HC-0007V8-AH () code ! kde ! org
[Download RAW message or body]
Git commit cc670b1a8733ab3f2b4c5640122d661390575c76 by Ralf Habacker.
Committed on 20/09/2018 at 20:09.
Pushed by habacker into branch '5.0'.
Add test for MyMoneyTransactionFilter
This test was created to check the basic functions of the transaction
filter, but does not claim to be complete. It was written by me for 4.8
and ported from Thomas Baumgart to KF5.
CCBUG:395327
Test Plan: compiled and tested on linux
Reviewers: wojnilowicz
Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>
Differential Revision: https://phabricator.kde.org/D15107
M +1 -1 kmymoney/mymoney/mymoneytransactionfilter.cpp
M +4 -3 kmymoney/mymoney/mymoneytransactionfilter.h
A +787 -0 kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp [License: \
GPL (v2+)] A +58 -0 kmymoney/mymoney/tests/mymoneytransactionfilter-test.h \
[License: GPL (v2+)]
https://commits.kde.org/kmymoney/cc670b1a8733ab3f2b4c5640122d661390575c76
diff --git a/kmymoney/mymoney/mymoneytransactionfilter.cpp \
b/kmymoney/mymoney/mymoneytransactionfilter.cpp index 11e4e01e5..279a30377 100644
--- a/kmymoney/mymoney/mymoneytransactionfilter.cpp
+++ b/kmymoney/mymoney/mymoneytransactionfilter.cpp
@@ -520,7 +520,7 @@ bool MyMoneyTransactionFilter::matchText(const MyMoneySplit& s, \
const MyMoneyAcc {
Q_D(const MyMoneyTransactionFilter);
// check if the text is contained in one of the fields
- // memo, value, number, payee, tag, account, date
+ // memo, value, number, payee, tag, account
if (d->m_filterSet.singleFilter.textFilter) {
const auto file = MyMoneyFile::instance();
const auto sec = file->security(acc.currencyId());
diff --git a/kmymoney/mymoney/mymoneytransactionfilter.h \
b/kmymoney/mymoney/mymoneytransactionfilter.h index 5652dcaf8..bc1fca469 100644
--- a/kmymoney/mymoney/mymoneytransactionfilter.h
+++ b/kmymoney/mymoney/mymoneytransactionfilter.h
@@ -236,8 +236,9 @@ public:
/**
* This method is used to check a specific transaction against the filter.
* The transaction will match the whole filter, if all specified filters
- * match. If the filter is cleared using the clear() method, any transaciton
- * matches.
+ * match. If the filter is cleared using the clear() method, any transaction
+ * matches. Matching splits from the transaction are returned by @ref
+ * matchingSplits().
*
* @param transaction A transaction
*
@@ -267,7 +268,7 @@ public:
* checked filters match. If the filter is cleared using the clear()
* method, any split matches.
*
- * @param sp pointer to the split to be checked
+ * @param sp const reference to the split to be checked
*
* @retval true The split matches the filter set
* @retval false The split does not match at least one of
diff --git a/kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp \
b/kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp new file mode 100644
index 000000000..d9ee6b068
--- /dev/null
+++ b/kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp
@@ -0,0 +1,787 @@
+/*
+ * Copyright 2018 Ralf Habacker <ralf.habacker@freenet.de>
+ * Copyright 2018 Thomas Baumgart <tbaumgart@kde.org>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "mymoneytransactionfilter-test.h"
+
+#include <QtTest/QtTest>
+
+#include "mymoneyenums.h"
+#include "mymoneytransactionfilter.h"
+#include "mymoneyfile.h"
+#include "mymoneystoragemgr.h"
+#include "mymoneyaccount.h"
+#include "mymoneypayee.h"
+#include "mymoneysecurity.h"
+#include "mymoneytag.h"
+#include "mymoneytransaction.h"
+#include "mymoneysplit.h"
+#include "mymoneyexception.h"
+
+// uses helper functions from reports tests
+#include "tests/testutilities.h"
+using namespace test;
+
+
+QTEST_GUILESS_MAIN(MyMoneyTransactionFilterTest)
+
+
+// using namespace std;
+
+void MyMoneyTransactionFilterTest::init()
+{
+ storage = new MyMoneyStorageMgr;
+ file = MyMoneyFile::instance();
+ file->attachStorage(storage);
+
+ MyMoneyFileTransaction ft;
+ file->addCurrency(MyMoneySecurity("USD", "US Dollar", "$"));
+ file->setBaseCurrency(file->currency("USD"));
+
+ MyMoneyPayee payeeTest("Payee 10.2");
+ file->addPayee(payeeTest);
+ payeeId = payeeTest.id();
+
+ MyMoneyTag tag("Tag 10.2");
+ file->addTag(tag);
+ tagIdList << tag.id();
+
+ QString acAsset = MyMoneyFile::instance()->asset().id();
+ QString acExpense = (MyMoneyFile::instance()->expense().id());
+ QString acIncome = (MyMoneyFile::instance()->income().id());
+ acCheckingId = makeAccount("Account 10.2", eMyMoney::Account::Type::Checkings, \
MyMoneyMoney(0.0), QDate(2004, 1, 1), acAsset); + acExpenseId = \
makeAccount("Expense", eMyMoney::Account::Type::Expense, MyMoneyMoney(), QDate(2004, \
1, 11), acExpense); + acIncomeId = makeAccount("Expense", \
eMyMoney::Account::Type::Expense, MyMoneyMoney(), QDate(2004, 1, 11), acIncome); +
+ ft.commit();
+}
+
+void MyMoneyTransactionFilterTest::cleanup()
+{
+ file->detachStorage(storage);
+ delete storage;
+}
+
+void MyMoneyTransactionFilterTest::testMatchAmount()
+{
+ MyMoneySplit split;
+ split.setShares(MyMoneyMoney(123.20));
+
+ MyMoneyTransactionFilter filter;
+ QCOMPARE(filter.matchAmount(split), true);
+
+ filter.setAmountFilter(MyMoneyMoney("123.0"), MyMoneyMoney("124.0"));
+ QCOMPARE(filter.matchAmount(split), true);
+ filter.setAmountFilter(MyMoneyMoney("120.0"), MyMoneyMoney("123.0"));
+ QCOMPARE(filter.matchAmount(split), false);
+}
+
+void MyMoneyTransactionFilterTest::testMatchText()
+{
+ MyMoneySplit split;
+ MyMoneyTransactionFilter filter;
+ MyMoneyAccount account = file->account(acCheckingId);
+
+ // no filter
+ QCOMPARE(filter.matchText(split, account), true);
+
+ filter.setTextFilter(QRegExp("10.2"), false);
+ MyMoneyTransactionFilter filterInvert;
+ filterInvert.setTextFilter(QRegExp("10.2"), true);
+ MyMoneyTransactionFilter filterNotFound;
+ filterNotFound.setTextFilter(QRegExp("10.5"), false);
+
+ // memo
+ split.setMemo("10.2");
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setMemo(QString());
+ // payee
+ split.setPayeeId(payeeId);
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setPayeeId(QString());
+ // tag
+ split.setTagIdList(tagIdList);
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setTagIdList(QStringList());
+ // value
+ split.setValue(MyMoneyMoney("10.2"));
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setValue(MyMoneyMoney());
+ // number
+ split.setNumber("10.2");
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setNumber("0.0");
+ // transaction id
+ split.setTransactionId("10.2");
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+ split.setTransactionId("0.0");
+ // account
+ split.setAccountId(acCheckingId);
+ QCOMPARE(filter.matchText(split, account), true);
+ QCOMPARE(filterInvert.matchText(split, account), false);
+ QCOMPARE(filterNotFound.matchText(split, account), false);
+}
+
+void MyMoneyTransactionFilterTest::testMatchSplit()
+{
+ qDebug() << "returns matchText() || matchAmount(), which are already tested";
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionAll()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setShares(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.setReportAllSplits(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionAccount()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setShares(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.addAccount(acCheckingId);
+ filter.setReportAllSplits(true);
+ filter.setConsiderCategory(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setReportAllSplits(false);
+ filter.setConsiderCategory(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setReportAllSplits(false);
+ filter.setConsiderCategory(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setReportAllSplits(true);
+ filter.setConsiderCategory(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+ filter.clear();
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionCategory()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setShares(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.addCategory(acExpenseId);
+ filter.setReportAllSplits(true);
+ filter.setConsiderCategory(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.setConsiderCategory(false);
+ QVERIFY(!filter.match(transaction));
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionDate()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setShares(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+ filter.setDateFilter(QDate(2014, 1, 1), QDate(2014, 1, 3));
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.setReportAllSplits(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setDateFilter(QDate(2014, 1, 3), QDate(2014, 1, 5));
+ QVERIFY(!filter.match(transaction));
+}
+
+void setupTransactionForNumber(MyMoneyTransaction &transaction, const QString \
&accountId) +{
+ MyMoneySplit split;
+ split.setAccountId(accountId);
+ split.setShares(MyMoneyMoney(123.00));
+ split.setNumber("1");
+ split.setMemo("1");
+
+ MyMoneySplit split2;
+ split2.setAccountId(accountId);
+ split2.setShares(MyMoneyMoney(1.00));
+ split2.setNumber("2");
+ split2.setMemo("2");
+
+ MyMoneySplit split3;
+ split3.setAccountId(accountId);
+ split3.setShares(MyMoneyMoney(100.00));
+ split3.setNumber("3");
+ split3.setMemo("3");
+
+ MyMoneySplit split4;
+ split4.setAccountId(accountId);
+ split4.setShares(MyMoneyMoney(22.00));
+ split4.setNumber("4");
+ split4.setMemo("4");
+
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+ transaction.addSplit(split3);
+ transaction.addSplit(split4);
+}
+
+void runtTestMatchTransactionNumber(MyMoneyTransaction &transaction, \
MyMoneyTransactionFilter &filter) +{
+ // return all matching splits
+ filter.setReportAllSplits(true);
+
+ filter.setNumberFilter("", "");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ filter.setNumberFilter("1", "");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ filter.setNumberFilter("", "4");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ filter.setNumberFilter("1", "4");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ filter.setNumberFilter("1", "2");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ // do not return all matching splits
+ filter.setReportAllSplits(false);
+
+ filter.setNumberFilter("1", "4");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setNumberFilter("1", "2");
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionNumber()
+{
+ MyMoneyTransaction transaction;
+ setupTransactionForNumber(transaction, acCheckingId);
+
+ MyMoneyTransactionFilter filter;
+ runtTestMatchTransactionNumber(transaction, filter);
+
+ transaction.clear();
+ setupTransactionForNumber(transaction, acExpenseId);
+
+ filter.clear();
+ runtTestMatchTransactionNumber(transaction, filter);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionPayee()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+ split.setPayeeId(payeeId);
+
+ MyMoneySplit split2;
+ split2.setAccountId(acCheckingId);
+ split2.setShares(MyMoneyMoney(124.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.addPayee(payeeId);
+
+ filter.setReportAllSplits(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ filter.setReportAllSplits(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // check no category support
+ MyMoneySplit split3;
+ split3.setAccountId(acExpenseId);
+ split3.setShares(MyMoneyMoney(120.00));
+ split3.setPayeeId(payeeId);
+
+ MyMoneyTransaction transaction2;
+ transaction2.setPostDate(QDate(2014, 1, 2));
+ transaction2.addSplit(split3);
+
+ filter.setReportAllSplits(true);
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+
+ qDebug() << "payee on categories could not be tested";
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionState()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+ split.setReconcileFlag(eMyMoney::Split::State::NotReconciled);
+
+ MyMoneySplit split2;
+ split2.setAccountId(acCheckingId);
+ split2.setShares(MyMoneyMoney(1.00));
+ split2.setReconcileFlag(eMyMoney::Split::State::Cleared);
+
+ MyMoneySplit split3;
+ split3.setAccountId(acCheckingId);
+ split3.setShares(MyMoneyMoney(100.00));
+ split3.setReconcileFlag(eMyMoney::Split::State::Reconciled);
+
+ MyMoneySplit split4;
+ split4.setAccountId(acCheckingId);
+ split4.setShares(MyMoneyMoney(22.00));
+ split4.setReconcileFlag(eMyMoney::Split::State::Frozen);
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+ transaction.addSplit(split3);
+ transaction.addSplit(split4);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ // all states
+ filter.addState((int)eMyMoney::TransactionFilter::State::NotReconciled);
+ filter.addState((int)eMyMoney::TransactionFilter::State::Cleared);
+ filter.addState((int)eMyMoney::TransactionFilter::State::Reconciled);
+ filter.addState((int)eMyMoney::TransactionFilter::State::Frozen);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 4);
+
+ // single state
+ filter.clear();
+ filter.addState((int)eMyMoney::TransactionFilter::State::NotReconciled);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+ filter.clear();
+
+ filter.addState((int)eMyMoney::TransactionFilter::State::Cleared);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+ filter.clear();
+
+ filter.addState((int)eMyMoney::TransactionFilter::State::Reconciled);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+ filter.clear();
+
+ filter.addState((int)eMyMoney::TransactionFilter::State::Frozen);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // check no category support
+ MyMoneySplit split5;
+ split5.setAccountId(acCheckingId);
+ split5.setShares(MyMoneyMoney(22.00));
+ split5.setReconcileFlag(eMyMoney::Split::State::Frozen);
+
+ MyMoneyTransaction transaction2;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split5);
+
+ filter.clear();
+ filter.setReportAllSplits(true);
+ filter.addState((int)eMyMoney::TransactionFilter::State::Frozen);
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+
+ qDebug() << "states on categories could not be tested";
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionTag()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setShares(MyMoneyMoney(123.00));
+ split.setTagIdList(tagIdList);
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setShares(MyMoneyMoney(123.00));
+ split2.setTagIdList(tagIdList);
+
+ MyMoneySplit split3;
+ split3.setAccountId(acCheckingId);
+ split3.setShares(MyMoneyMoney(10.00));
+ split3.setTagIdList(tagIdList);
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+ transaction.addSplit(split3);
+
+ MyMoneyTransactionFilter filter;
+ filter.addTag(tagIdList.first());
+ filter.setReportAllSplits(true);
+ QVERIFY(filter.match(transaction));
+ // -1 because categories are not supported yet
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.setReportAllSplits(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // check no category support
+ MyMoneySplit split4;
+ split4.setAccountId(acExpenseId);
+ split4.setShares(MyMoneyMoney(123.00));
+ split4.setTagIdList(tagIdList);
+
+ MyMoneyTransaction transaction2;
+ transaction2.setPostDate(QDate(2014, 1, 2));
+ transaction2.addSplit(split4);
+
+ filter.setReportAllSplits(true);
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+
+ qDebug() << "tags on categories could not be tested";
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionTypeAllTypes()
+{
+ /*
+ alltypes
+ - account group == MyMoneyAccount::Income ||
+ - account group == MyMoneyAccount::Expense
+ */
+ MyMoneySplit split;
+ split.setAccountId(acExpenseId);
+ split.setValue(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acIncomeId);
+ split2.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+
+ // all splits
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.addType((int)eMyMoney::TransactionFilter::State::All);
+ qDebug() << "MyMoneyTransactionFilter::allTypes could not be tested";
+ qDebug() << "because type filter does not work with categories";
+
+ QVERIFY(!filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 0);
+
+ // ! alltypes
+ MyMoneySplit split3;
+ split3.setAccountId(acCheckingId);
+ split3.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction2;
+ transaction2.addSplit(split3);
+
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionTypeDeposits()
+{
+ // deposits - split value is positive
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setValue(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+
+ // all splits
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // deposits
+ filter.addType((int)eMyMoney::TransactionFilter::Type::Deposits);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // no deposits
+ MyMoneySplit split2;
+ split2.setAccountId(acCheckingId);
+ split2.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction2;
+ transaction2.setPostDate(QDate(2014, 1, 2));
+ transaction2.addSplit(split2);
+
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionTypePayments()
+{
+ /*
+ payments
+ - account group != MyMoneyAccount::Income
+ - account group != MyMoneyAccount::Expense
+ - split value is not positive
+ - number of splits != 2
+ */
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+
+ // all splits
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // valid payments
+ filter.addType((int)eMyMoney::TransactionFilter::Type::Payments);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // no payments
+ // check number of splits != 2
+ MyMoneySplit split2;
+ split2.setAccountId(acCheckingId);
+ split2.setValue(MyMoneyMoney(-123.00));
+ transaction.addSplit(split2);
+
+ QVERIFY(!filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 0);
+
+ // split value is not positive
+ MyMoneySplit split3;
+ split3.setAccountId(acCheckingId);
+ split3.setValue(MyMoneyMoney(123.00));
+ transaction.addSplit(split3);
+
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ // account group != MyMoneyAccount::Income && account group != \
MyMoneyAccount::Expense + MyMoneySplit split4;
+ split4.setAccountId(acExpenseId);
+ split4.setValue(MyMoneyMoney(-124.00));
+ transaction.addSplit(split4);
+
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionTypeTransfers()
+{
+ /*
+ check transfers
+ - number of splits == 2
+ - account group != MyMoneyAccount::Income
+ - account group != MyMoneyAccount::Expense
+ */
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setValue(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acCheckingId);
+ split2.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneySplit split3;
+ split3.setAccountId(acCheckingId);
+ split3.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ MyMoneyTransactionFilter filter;
+ filter.setReportAllSplits(true);
+
+ // all splits
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.addType((int)eMyMoney::TransactionFilter::Type::Transfers);
+
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ // transfers - invalid number of counts
+ transaction.addSplit(split3);
+ QVERIFY(!filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 0);
+
+ // transfers - invalid account
+ MyMoneySplit split4;
+ split4.setAccountId(acIncomeId);
+ split4.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneySplit split5;
+ split5.setAccountId(acCheckingId);
+ split5.setValue(MyMoneyMoney(123.00));
+
+ MyMoneyTransaction transaction2;
+ transaction2.setPostDate(QDate(2014, 1, 2));
+ transaction2.addSplit(split4);
+ transaction2.addSplit(split5);
+
+ QVERIFY(!filter.match(transaction2));
+ QCOMPARE(filter.matchingSplits(transaction2).size(), 0);
+}
+
+void MyMoneyTransactionFilterTest::testMatchTransactionValidity()
+{
+ MyMoneySplit split;
+ split.setAccountId(acCheckingId);
+ split.setValue(MyMoneyMoney(123.00));
+
+ MyMoneySplit split2;
+ split2.setAccountId(acExpenseId);
+ split2.setValue(MyMoneyMoney(-123.00));
+
+ MyMoneyTransaction transaction;
+ transaction.setPostDate(QDate(2014, 1, 2));
+ transaction.addSplit(split);
+ transaction.addSplit(split2);
+
+ // check valid transaction
+ MyMoneyTransactionFilter filter;
+ filter.addValidity((int)eMyMoney::TransactionFilter::Validity::Valid);
+ filter.setReportAllSplits(true);
+
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 2);
+
+ filter.setReportAllSplits(false);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 1);
+
+ // check invalid transaction
+ filter.clear();
+ filter.addValidity((int)eMyMoney::TransactionFilter::Validity::Invalid);
+ filter.setReportAllSplits(true);
+
+ QVERIFY(!filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 0);
+
+ // add split to make transaction invalid
+ MyMoneySplit split3;
+ split3.setAccountId(acExpenseId);
+ split3.setValue(MyMoneyMoney(-10.00));
+ transaction.addSplit(split3);
+
+ filter.setReportAllSplits(true);
+ QVERIFY(filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 3);
+
+ filter.clear();
+ filter.addValidity((int)eMyMoney::TransactionFilter::Validity::Valid);
+
+ QVERIFY(!filter.match(transaction));
+ QCOMPARE(filter.matchingSplits(transaction).size(), 0);
+}
diff --git a/kmymoney/mymoney/tests/mymoneytransactionfilter-test.h \
b/kmymoney/mymoney/tests/mymoneytransactionfilter-test.h new file mode 100644
index 000000000..96c3e87cf
--- /dev/null
+++ b/kmymoney/mymoney/tests/mymoneytransactionfilter-test.h
@@ -0,0 +1,58 @@
+/*
+ * Copyright 2018 Ralf Habacker <ralf.habacker@freenet.de>
+ * Copyright 2018 Thomas Baumgart <tbaumgart@kde.org>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef MYMONEYTRANSACTIONFILTERTEST_H
+#define MYMONEYTRANSACTIONFILTERTEST_H
+
+#include <QObject>
+class MyMoneyStorageMgr;
+class MyMoneyFile;
+
+class MyMoneyTransactionFilterTest : public QObject
+{
+ Q_OBJECT
+private slots:
+ void init();
+ void cleanup();
+ void testMatchAmount();
+ void testMatchText();
+ void testMatchSplit();
+ void testMatchTransactionAll();
+ void testMatchTransactionAccount();
+ void testMatchTransactionCategory();
+ void testMatchTransactionDate();
+ void testMatchTransactionNumber();
+ void testMatchTransactionPayee();
+ void testMatchTransactionState();
+ void testMatchTransactionTag();
+ void testMatchTransactionTypeAllTypes();
+ void testMatchTransactionTypeDeposits();
+ void testMatchTransactionTypePayments();
+ void testMatchTransactionTypeTransfers();
+ void testMatchTransactionValidity();
+private:
+ QString payeeId;
+ QList<QString> tagIdList;
+ QString acCheckingId;
+ QString acExpenseId;
+ QString acIncomeId;
+ MyMoneyStorageMgr* storage;
+ MyMoneyFile* file;
+};
+
+#endif
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic