[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace/Plasma/5.14] applets/notifications/package/contents/ui: [Notifications] Store "Ope
From:       Kai Uwe Broulik <null () kde ! org>
Date:       2018-09-17 16:05:43
Message-ID: E1g1w1w-00014U-06 () code ! kde ! org
[Download RAW message or body]

Git commit a8b71fe5c0175887100c16ed53382c91620984b0 by Kai Uwe Broulik.
Committed on 17/09/2018 at 16:05.
Pushed by broulik into branch 'Plasma/5.14'.

[Notifications] Store "Open..." action in history

Actions stop working when the original notification goes away, however the "Open..." \
notification when a job completed is added and handled by us, so we can store it in \
the history and it will continue to function.

BUG: 398732
FIXED-IN: 5.14.0

Differential Revision: https://phabricator.kde.org/D15578

M  +7    -1    applets/notifications/package/contents/ui/Notifications.qml

https://commits.kde.org/plasma-workspace/a8b71fe5c0175887100c16ed53382c91620984b0

diff --git a/applets/notifications/package/contents/ui/Notifications.qml \
b/applets/notifications/package/contents/ui/Notifications.qml index \
                e3f46d78..23b34a31 100644
--- a/applets/notifications/package/contents/ui/Notifications.qml
+++ b/applets/notifications/package/contents/ui/Notifications.qml
@@ -88,6 +88,12 @@ Column {
         else if (showHistory) {
             
             notificationsHistoryModel.inserting = true;
+
+            //Disable actions in this copy as they will stop working once the \
original notification is closed. +            //Only the jobUrl (which is a URL to \
open) can continue working as we'll handle this internally. +            var actions \
= notification.actions.filter(function (item) { +                return \
item.id.indexOf("jobUrl#") === 0; +            });
             
             //create a copy of the notification. 
             //Disable actions in this copy as they will stop working once the \
original notification is closed. @@ -101,7 +107,7 @@ Column {
                 "created" : new Date(),
                 "urls" : notification.urls,
                 "maximumTextHeight" : notification.maximumTextHeight,
-                "actions" : null,
+                "actions" : actions,
                 "hasDefaultAction" : false,
                 "hasConfigureAction" : false,
             });


[prev in list] [next in list] [prev in thread] [next in thread]