[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [purpose] /: Make compile with strict compile flags
From:       Laurent Montel <null () kde ! org>
Date:       2018-09-14 5:52:57
Message-ID: E1g0h2H-00060H-AT () code ! kde ! org
[Download RAW message or body]

Git commit b40009c31642e43ed34109778b8aea1e7b8b1520 by Laurent Montel.
Committed on 14/09/2018 at 05:52.
Pushed by mlaurent into branch 'master'.

Make compile with strict compile flags

M  +6    -0    CMakeLists.txt
M  +1    -1    src/plugins/phabricator/quick/difflistmodel.cpp

https://commits.kde.org/purpose/b40009c31642e43ed34109778b8aea1e7b8b1520

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a573ff2..c25c9b1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -39,6 +39,12 @@ ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX PURPOSE
                         VERSION_HEADER "${CMAKE_CURRENT_BINARY_DIR}/purpose_version.h"
                         PACKAGE_VERSION_FILE "${CMAKE_CURRENT_BINARY_DIR}/KF5PurposeConfigVersion.cmake"
                         SOVERSION 5)
+add_definitions(-DQT_NO_CAST_FROM_ASCII)
+add_definitions(-DQT_NO_CAST_TO_ASCII)
+add_definitions(-DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT)
+add_definitions(-DQT_NO_URL_CAST_FROM_STRING)
+add_definitions(-DQT_USE_QSTRINGBUILDER)
+#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000)
 
 add_subdirectory( src )
 if (BUILD_TESTING)
diff --git a/src/plugins/phabricator/quick/difflistmodel.cpp b/src/plugins/phabricator/quick/difflistmodel.cpp
index 0e8faca..d0f2beb 100644
--- a/src/plugins/phabricator/quick/difflistmodel.cpp
+++ b/src/plugins/phabricator/quick/difflistmodel.cpp
@@ -98,7 +98,7 @@ void DiffListModel::receivedDiffRevs(KJob* job)
         auto status = diffRevList->statusMap()[review.second];
         tmpValues += Value { review.second, review.first, status };
     }
-    qSort(tmpValues.begin(), tmpValues.end());
+    std::sort(tmpValues.begin(), tmpValues.end());
 
     beginResetModel();
     m_values.clear();
[prev in list] [next in list] [prev in thread] [next in thread]