[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [websites/digikam-org/dev] static/reports/cppcheck/master: update cppcheck static analyzer report di
From: Gilles Caulier <null () kde ! org>
Date: 2018-09-11 7:38:05
Message-ID: E1fzdFN-00041J-5o () code ! kde ! org
[Download RAW message or body]
Git commit e7f102d34d621de1926f955a16df47151f1dedc8 by Gilles Caulier.
Committed on 11/09/2018 at 07:38.
Pushed by cgilles into branch 'dev'.
update cppcheck static analyzer report digiKam-master-rev-0ca8051b21.
M +2 -2 static/reports/cppcheck/master/0.html
M +2 -2 static/reports/cppcheck/master/1.html
M +2 -2 static/reports/cppcheck/master/10.html
M +2 -2 static/reports/cppcheck/master/11.html
M +2 -2 static/reports/cppcheck/master/12.html
M +2 -2 static/reports/cppcheck/master/13.html
M +2 -2 static/reports/cppcheck/master/14.html
M +2 -2 static/reports/cppcheck/master/15.html
M +98 -100 static/reports/cppcheck/master/16.html
M +24 -24 static/reports/cppcheck/master/17.html
M +59 -69 static/reports/cppcheck/master/18.html
M +73 -95 static/reports/cppcheck/master/19.html
M +2 -2 static/reports/cppcheck/master/2.html
D +0 -359 static/reports/cppcheck/master/20.html
D +0 -373 static/reports/cppcheck/master/21.html
M +2 -2 static/reports/cppcheck/master/3.html
M +2 -2 static/reports/cppcheck/master/4.html
M +2 -2 static/reports/cppcheck/master/5.html
M +2 -2 static/reports/cppcheck/master/6.html
M +2 -2 static/reports/cppcheck/master/7.html
M +2 -2 static/reports/cppcheck/master/8.html
M +2 -2 static/reports/cppcheck/master/9.html
M +9 -13 static/reports/cppcheck/master/index.html
M +2 -2 static/reports/cppcheck/master/stats.html
https://commits.kde.org/websites/digikam-org/e7f102d34d621de1926f955a16df47151f1dedc8
diff --git a/static/reports/cppcheck/master/0.html \
b/static/reports/cppcheck/master/0.html index 7224f78b..5588ea2a 100644
--- a/static/reports/cppcheck/master/0.html
+++ b/static/reports/cppcheck/master/0.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/album/albummanager.h </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/album/albummanager.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> albummanager.h</p>
diff --git a/static/reports/cppcheck/master/1.html \
b/static/reports/cppcheck/master/1.html index b3059dc7..574f63aa 100644
--- a/static/reports/cppcheck/master/1.html
+++ b/static/reports/cppcheck/master/1.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/album/albummanager.cpp </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/album/albummanager.cpp </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> albummanager.cpp</p>
diff --git a/static/reports/cppcheck/master/10.html \
b/static/reports/cppcheck/master/10.html index 6d590157..ca0d53b1 100644
--- a/static/reports/cppcheck/master/10.html
+++ b/static/reports/cppcheck/master/10.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/threadimageio/thumbnailloadthread.cpp </h1> + <h1>Cppcheck \
report - digiKam-master-rev-0ca8051b21: \
../../core/libs/threadimageio/thumbnailloadthread.cpp </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> \
thumbnailloadthread.cpp</p>
diff --git a/static/reports/cppcheck/master/11.html \
b/static/reports/cppcheck/master/11.html index dead34af..1c8c930c 100644
--- a/static/reports/cppcheck/master/11.html
+++ b/static/reports/cppcheck/master/11.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/assistants/htmlgallery/generator/galleryxmlutils.h </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/assistants/htmlgallery/generator/galleryxmlutils.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> galleryxmlutils.h</p>
diff --git a/static/reports/cppcheck/master/12.html \
b/static/reports/cppcheck/master/12.html index bb9a4e43..f85eb69f 100644
--- a/static/reports/cppcheck/master/12.html
+++ b/static/reports/cppcheck/master/12.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/assistants/printcreator/tools/atkinspagelayouttree.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/assistants/printcreator/tools/atkinspagelayouttree.cpp </h1> \
</div> <div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> \
atkinspagelayouttree.cpp</p>
diff --git a/static/reports/cppcheck/master/13.html \
b/static/reports/cppcheck/master/13.html index 6c2f37dc..2eafc343 100644
--- a/static/reports/cppcheck/master/13.html
+++ b/static/reports/cppcheck/master/13.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/assistants/webservices/yandexfotki/yfrsa.h </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/assistants/webservices/yandexfotki/yfrsa.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> yfrsa.h</p>
diff --git a/static/reports/cppcheck/master/14.html \
b/static/reports/cppcheck/master/14.html index a75638f7..ba29f299 100644
--- a/static/reports/cppcheck/master/14.html
+++ b/static/reports/cppcheck/master/14.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/assistants/webservices/yandexfotki/yfrsa.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/assistants/webservices/yandexfotki/yfrsa.cpp </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> yfrsa.cpp</p>
diff --git a/static/reports/cppcheck/master/15.html \
b/static/reports/cppcheck/master/15.html index dae84dcc..ad22b8bd 100644
--- a/static/reports/cppcheck/master/15.html
+++ b/static/reports/cppcheck/master/15.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/facemanagement/facepipeline.h </h1> + <h1>Cppcheck report \
- digiKam-master-rev-0ca8051b21: ../../core/utilities/facemanagement/facepipeline.h \
</h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> facepipeline.h</p>
diff --git a/static/reports/cppcheck/master/16.html \
b/static/reports/cppcheck/master/16.html index 4b264886..0bf85cc1 100644
--- a/static/reports/cppcheck/master/16.html
+++ b/static/reports/cppcheck/master/16.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,11 +120,11 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2dng.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/queuemanager/tools/convert/convert2jpeg.cpp </h1> </div>
<div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2dng.cpp</p>
-<a href='16.html#line-55'> publicAllocationError 55</a>
+ <p id="filename"><a href="index.html">Defects:</a> convert2jpeg.cpp</p>
+<a href='16.html#line-62'> publicAllocationError 62</a>
</div>
<div id="content">
<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> \
1 @@ -247,16 +247,15 @@
118
119
120
-121
-122</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> \
+121</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> <a \
name="line-2"></a><span class="cm"> *</span> <a name="line-3"></a><span class="cm"> \
* This file is a part of digiKam project</span> <a name="line-4"></a><span \
class="cm"> * http://www.digikam.org</span> <a name="line-5"></a><span class="cm"> \
*</span>
-<a name="line-6"></a><span class="cm"> * Date : 2015-07-18</span>
-<a name="line-7"></a><span class="cm"> * Description : DNG Raw Converter batch \
tool.</span> +<a name="line-6"></a><span class="cm"> * Date : \
2008-11-24</span> +<a name="line-7"></a><span class="cm"> * Description : JPEG image \
Converter batch tool.</span> <a name="line-8"></a><span class="cm"> *</span>
-<a name="line-9"></a><span class="cm"> * Copyright (C) 2015-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span> +<a name="line-9"></a><span \
class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier <caulier dot gilles at \
gmail dot com></span> <a name="line-10"></a><span class="cm"> *</span>
<a name="line-11"></a><span class="cm"> * This program is free software; you can \
redistribute it</span> <a name="line-12"></a><span class="cm"> * and/or modify it \
under the terms of the GNU General</span> @@ -271,7 +270,7 @@
<a name="line-21"></a><span class="cm"> *</span>
<a name="line-22"></a><span class="cm"> * \
============================================================ */</span> <a \
name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2dng.h"</span><span class="cp"></span> +<a \
name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2jpeg.h"</span><span class="cp"></span> <a \
name="line-25"></a> <a name="line-26"></a><span class="c1">// Qt includes</span>
<a name="line-27"></a>
@@ -280,96 +279,95 @@
<a name="line-30"></a>
<a name="line-31"></a><span class="c1">// KDE includes</span>
<a name="line-32"></a>
-<a name="line-33"></a><span class="cp">#include</span> <span \
class="cpf"><klocalizedstring.h></span><span class="cp"></span>
-<a name="line-34"></a>
-<a name="line-35"></a><span class="k">namespace</span> <span \
class="n">Digikam</span>
-<a name="line-36"></a><span class="p">{</span>
-<a name="line-37"></a>
-<a name="line-38"></a><span class="n">Convert2DNG</span><span \
class="o">::</span><span class="n">Convert2DNG</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-39"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2DNG"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-40"></a><span class="p">{</span>
-<a name="line-41"></a> <span class="n">m_settings</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span>
-<a name="line-42"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-43"></a>
-<a name="line-44"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert RAW To DNG"</span><span \
class="p">));</span>
-<a name="line-45"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert RAW images to DNG container."</span><span \
class="p">));</span>
-<a name="line-46"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-x-adobe-dng"</span><span \
class="p">));</span>
-<a name="line-47"></a><span class="p">}</span>
-<a name="line-48"></a>
-<a name="line-49"></a><span class="n">Convert2DNG</span><span \
class="o">::~</span><span class="n">Convert2DNG</span><span \
class="p">()</span>
-<a name="line-50"></a><span class="p">{</span>
-<a name="line-51"></a><span class="p">}</span>
-<a name="line-52"></a>
-<a name="line-53"></a><span class="kt">void</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span>
-<a name="line-54"></a><span class="p">{</span>
-<a name="line-55"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">DNGSettings</span><span class="p">;</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span>
-</span><a name="line-56"></a> <span class="n">m_settingsWidget</span> <span \
class="o">=</span> <span class="n">m_settings</span><span \
class="p">;</span>
-<a name="line-57"></a>
-<a name="line-58"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span>
-<a name="line-59"></a> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span>
-<a name="line-60"></a>
-<a name="line-61"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span>
-<a name="line-62"></a><span class="p">}</span>
-<a name="line-63"></a>
-<a name="line-64"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span>
-<a name="line-65"></a><span class="p">{</span>
-<a name="line-66"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-67"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"CompressLossLess"</span><span class="p">),</span> <span \
class="nb">true</span><span class="p">);</span>
-<a name="line-68"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PreviewMode"</span><span class="p">),</span> <span \
class="n">DNGWriter</span><span class="o">::</span><span class="n">MEDIUM</span><span \
class="p">);</span>
-<a name="line-69"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"BackupOriginalRawFile"</span><span class="p">),</span> <span \
class="nb">false</span><span class="p">);</span>
-<a name="line-70"></a> <span class="k">return</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-71"></a><span class="p">}</span>
-<a name="line-72"></a>
-<a name="line-73"></a><span class="kt">void</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span>
-<a name="line-74"></a><span class="p">{</span>
-<a name="line-75"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">false</span><span \
class="p">;</span>
-<a name="line-76"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setCompressLossLess</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"CompressLossLess"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-77"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setPreviewMode</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PreviewMode"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-78"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setBackupOriginalRawFile</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"BackupOriginalRawFile"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-79"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-80"></a><span class="p">}</span>
-<a name="line-81"></a>
-<a name="line-82"></a><span class="kt">void</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span>
-<a name="line-83"></a><span class="p">{</span>
-<a name="line-84"></a> <span class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span>
-<a name="line-85"></a> <span class="p">{</span>
-<a name="line-86"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-87"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"CompressLossLess"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">compressLossLess</span><span class="p">());</span>
-<a name="line-88"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PreviewMode"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">previewMode</span><span class="p">());</span>
-<a name="line-89"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"BackupOriginalRawFile"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">backupOriginalRawFile</span><span class="p">());</span>
-<a name="line-90"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span \
class="p">);</span>
-<a name="line-91"></a> <span class="p">}</span>
-<a name="line-92"></a><span class="p">}</span>
-<a name="line-93"></a>
-<a name="line-94"></a><span class="n">QString</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span \
class="k">const</span>
-<a name="line-95"></a><span class="p">{</span>
-<a name="line-96"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"dng"</span><span class="p">);</span>
-<a name="line-97"></a><span class="p">}</span>
-<a name="line-98"></a>
-<a name="line-99"></a><span class="kt">void</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">cancel</span><span class="p">()</span>
-<a name="line-100"></a><span class="p">{</span>
-<a name="line-101"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">cancel</span><span \
class="p">();</span>
-<a name="line-102"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">cancel</span><span \
class="p">();</span>
-<a name="line-103"></a><span class="p">}</span>
-<a name="line-104"></a>
-<a name="line-105"></a><span class="kt">bool</span> <span \
class="n">Convert2DNG</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span>
-<a name="line-106"></a><span class="p">{</span>
-<a name="line-107"></a> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">isRawFile</span><span class="p">(</span><span \
class="n">inputUrl</span><span class="p">()))</span>
-<a name="line-108"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span>
-<a name="line-109"></a>
-<a name="line-110"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">reset</span><span \
class="p">();</span>
-<a name="line-111"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">setInputFile</span><span class="p">(</span><span \
class="n">inputUrl</span><span class="p">().</span><span \
class="n">toLocalFile</span><span class="p">());</span>
-<a name="line-112"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">setOutputFile</span><span class="p">(</span><span \
class="n">outputUrl</span><span class="p">().</span><span \
class="n">toLocalFile</span><span class="p">());</span>
-<a name="line-113"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">setBackupOriginalRawFile</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"BackupOriginalRawFile"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-114"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">setCompressLossLess</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"CompressLossLess"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-115"></a> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">setPreviewMode</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PreviewMode"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-116"></a>
-<a name="line-117"></a> <span class="kt">int</span> <span class="n">ret</span> \
<span class="o">=</span> <span class="n">m_dngProcessor</span><span \
class="p">.</span><span class="n">convert</span><span \
class="p">();</span>
-<a name="line-118"></a>
-<a name="line-119"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">ret</span> <span class="o">==</span> <span \
class="n">DNGWriter</span><span class="o">::</span><span \
class="n">PROCESSCOMPLETE</span><span class="p">);</span>
-<a name="line-120"></a><span class="p">}</span>
-<a name="line-121"></a>
-<a name="line-122"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> +<a name="line-33"></a><span class="cp">#include</span> <span \
class="cpf"><kconfiggroup.h></span><span class="cp"></span> +<a \
name="line-34"></a><span class="cp">#include</span> <span \
class="cpf"><klocalizedstring.h></span><span class="cp"></span> +<a \
name="line-35"></a><span class="cp">#include</span> <span \
class="cpf"><ksharedconfig.h></span><span class="cp"></span> +<a \
name="line-36"></a> +<a name="line-37"></a><span class="c1">// Local includes</span>
+<a name="line-38"></a>
+<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span> +<a \
name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"jpegsettings.h"</span><span class="cp"></span> +<a \
name="line-41"></a> +<a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span> +<a name="line-43"></a><span class="p">{</span>
+<a name="line-44"></a>
+<a name="line-45"></a><span class="n">Convert2JPEG</span><span \
class="o">::</span><span class="n">Convert2JPEG</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-46"></a> <span \
class="o">:</span> <span class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2JPEG"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-47"></a><span \
class="p">{</span> +<a name="line-48"></a> <span class="n">m_settings</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span> +<a \
name="line-49"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span class="p">;</span> +<a \
name="line-50"></a> +<a name="line-51"></a> <span \
class="n">setToolTitle</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Convert To JPEG"</span><span \
class="p">));</span> +<a name="line-52"></a> <span \
class="n">setToolDescription</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">"Convert images to \
JPEG format."</span><span class="p">));</span> +<a name="line-53"></a> <span \
class="n">setToolIconName</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-jpeg"</span><span class="p">));</span> +<a \
name="line-54"></a><span class="p">}</span> +<a name="line-55"></a>
+<a name="line-56"></a><span class="n">Convert2JPEG</span><span \
class="o">::~</span><span class="n">Convert2JPEG</span><span class="p">()</span> +<a \
name="line-57"></a><span class="p">{</span> +<a name="line-58"></a><span \
class="p">}</span> +<a name="line-59"></a>
+<a name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> +<a \
name="line-61"></a><span class="p">{</span> +<a name="line-62"></a><span class="hll"> \
<span class="n">m_settings</span> <span class="o">=</span> <span \
class="k">new</span> <span class="n">JPEGSettings</span><span class="p">;</span><span \
class='error2'><--- Possible leak in public function. The pointer 'm_settings' is \
not deallocated before it is allocated.</span> +</span><a name="line-63"></a> \
<span class="n">m_settingsWidget</span> <span class="o">=</span> <span \
class="n">m_settings</span><span class="p">;</span> +<a name="line-64"></a>
+<a name="line-65"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span> +<a \
name="line-66"></a> <span class="k">this</span><span class="p">,</span> \
<span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span> +<a \
name="line-67"></a> +<a name="line-68"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span> +<a name="line-69"></a><span class="p">}</span>
+<a name="line-70"></a>
+<a name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> +<a \
name="line-72"></a><span class="p">{</span> +<a name="line-73"></a> <span \
class="n">KSharedConfig</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="n">config</span> <span class="o">=</span> <span \
class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span> +<a name="line-74"></a> \
<span class="n">KConfigGroup</span> <span class="n">group</span> <span \
class="o">=</span> <span class="n">config</span><span class="o">-></span><span \
class="n">group</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span class="p">));</span> +<a \
name="line-75"></a> <span class="kt">int</span> <span class="n">compression</span> \
<span class="o">=</span> <span class="n">group</span><span class="p">.</span><span \
class="n">readEntry</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEGCompression"</span><span class="p">),</span> <span \
class="mi">75</span><span class="p">);</span> +<a name="line-76"></a> <span \
class="kt">int</span> <span class="n">subSampling</span> <span \
class="o">=</span> <span class="n">group</span><span class="p">.</span><span \
class="n">readEntry</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEGSubSampling"</span><span class="p">),</span> <span \
class="mi">1</span><span class="p">);</span> <span class="c1">// Medium \
subsampling</span> +<a name="line-77"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-78"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span> +<a name="line-79"></a> \
<span class="n">settings</span><span class="p">.</span><span \
class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">),</span> <span \
class="n">subSampling</span><span class="p">);</span> +<a name="line-80"></a> \
<span class="k">return</span> <span class="n">settings</span><span class="p">;</span> \
+<a name="line-81"></a><span class="p">}</span> +<a name="line-82"></a>
+<a name="line-83"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span> +<a \
name="line-84"></a><span class="p">{</span> +<a name="line-85"></a> <span \
class="n">m_changeSettings</span> <span class="o">=</span> <span \
class="nb">false</span><span class="p">;</span> +<a name="line-86"></a> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">setCompressionValue</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-87"></a> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">setSubSamplingValue</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-88"></a> <span \
class="n">m_changeSettings</span> <span class="o">=</span> <span \
class="nb">true</span><span class="p">;</span> +<a name="line-89"></a><span \
class="p">}</span> +<a name="line-90"></a>
+<a name="line-91"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span> +<a \
name="line-92"></a><span class="p">{</span> +<a name="line-93"></a> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span> +<a name="line-94"></a> \
<span class="p">{</span> +<a name="line-95"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-96"></a> <span \
class="n">settings</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompressionValue</span><span class="p">());</span> +<a \
name="line-97"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getSubSamplingValue</span><span class="p">());</span> +<a \
name="line-98"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span class="p">);</span> +<a \
name="line-99"></a> <span class="p">}</span> +<a name="line-100"></a><span \
class="p">}</span> +<a name="line-101"></a>
+<a name="line-102"></a><span class="n">QString</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span class="k">const</span> \
+<a name="line-103"></a><span class="p">{</span> +<a name="line-104"></a> <span \
class="k">return</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span class="s">"jpg"</span><span class="p">);</span> +<a \
name="line-105"></a><span class="p">}</span> +<a name="line-106"></a>
+<a name="line-107"></a><span class="kt">bool</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span> +<a \
name="line-108"></a><span class="p">{</span> +<a name="line-109"></a> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">loadToDImg</span><span class="p">())</span> +<a name="line-110"></a> \
<span class="p">{</span> +<a name="line-111"></a> <span \
class="k">return</span> <span class="nb">false</span><span class="p">;</span> +<a \
name="line-112"></a> <span class="p">}</span> +<a name="line-113"></a>
+<a name="line-114"></a> <span class="kt">int</span> <span \
class="n">JPEGCompression</span> <span class="o">=</span> <span \
class="n">JPEGSettings</span><span class="o">::</span><span \
class="n">convertCompressionForLibJpeg</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-115"></a> <span \
class="n">image</span><span class="p">().</span><span \
class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">JPEGCompression</span><span class="p">);</span> +<a name="line-116"></a> \
<span class="n">image</span><span class="p">().</span><span \
class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"subsampling"</span><span class="p">),</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-117"></a>
+<a name="line-118"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span class="p">());</span> +<a \
name="line-119"></a><span class="p">}</span> +<a name="line-120"></a>
+<a name="line-121"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> </pre></div>
</td></tr></table>
</div>
diff --git a/static/reports/cppcheck/master/17.html \
b/static/reports/cppcheck/master/17.html index 99fa29c0..e24c750e 100644
--- a/static/reports/cppcheck/master/17.html
+++ b/static/reports/cppcheck/master/17.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,10 +120,10 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2jp2.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/queuemanager/tools/convert/convert2pgf.cpp </h1> </div>
<div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2jp2.cpp</p>
+ <p id="filename"><a href="index.html">Defects:</a> convert2pgf.cpp</p>
<a href='17.html#line-62'> publicAllocationError 62</a>
</div>
<div id="content">
@@ -251,10 +251,10 @@
<a name="line-3"></a><span class="cm"> * This file is a part of digiKam \
project</span> <a name="line-4"></a><span class="cm"> * \
http://www.digikam.org</span> <a name="line-5"></a><span class="cm"> *</span>
-<a name="line-6"></a><span class="cm"> * Date : 2008-11-28</span>
-<a name="line-7"></a><span class="cm"> * Description : JPEG2000 image Converter \
batch tool.</span> +<a name="line-6"></a><span class="cm"> * Date : \
2009-06-18</span> +<a name="line-7"></a><span class="cm"> * Description : PGF image \
Converter batch tool.</span> <a name="line-8"></a><span class="cm"> *</span>
-<a name="line-9"></a><span class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span> +<a name="line-9"></a><span \
class="cm"> * Copyright (C) 2009-2018 by Gilles Caulier <caulier dot gilles at \
gmail dot com></span> <a name="line-10"></a><span class="cm"> *</span>
<a name="line-11"></a><span class="cm"> * This program is free software; you can \
redistribute it</span> <a name="line-12"></a><span class="cm"> * and/or modify it \
under the terms of the GNU General</span> @@ -269,7 +269,7 @@
<a name="line-21"></a><span class="cm"> *</span>
<a name="line-22"></a><span class="cm"> * \
============================================================ */</span> <a \
name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2jp2.h"</span><span class="cp"></span> +<a \
name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2pgf.h"</span><span class="cp"></span> <a \
name="line-25"></a> <a name="line-26"></a><span class="c1">// Qt includes</span>
<a name="line-27"></a>
@@ -285,29 +285,29 @@
<a name="line-37"></a><span class="c1">// Local includes</span>
<a name="line-38"></a>
<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span>
-<a name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"jp2ksettings.h"</span><span class="cp"></span> +<a \
name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"pgfsettings.h"</span><span class="cp"></span> <a \
name="line-41"></a> <a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span> <a name="line-43"></a><span class="p">{</span>
<a name="line-44"></a>
-<a name="line-45"></a><span class="n">Convert2JP2</span><span \
class="o">::</span><span class="n">Convert2JP2</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-46"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2JP2"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-45"></a><span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">Convert2PGF</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-46"></a> <span \
class="o">:</span> <span class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2PGF"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> <a name="line-47"></a><span \
class="p">{</span> <a name="line-48"></a> <span class="n">m_settings</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span> <a \
name="line-49"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span class="p">;</span> <a \
name="line-50"></a>
-<a name="line-51"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To JP2"</span><span class="p">));</span>
-<a name="line-52"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to JPEG-2000 format."</span><span \
class="p">));</span> +<a name="line-51"></a> <span \
class="n">setToolTitle</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Convert To PGF"</span><span \
class="p">));</span> +<a name="line-52"></a> <span \
class="n">setToolDescription</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">"Convert images to \
PGF format."</span><span class="p">));</span> <a name="line-53"></a> <span \
class="n">setToolIconName</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-jpeg"</span><span class="p">));</span> <a \
name="line-54"></a><span class="p">}</span> <a name="line-55"></a>
-<a name="line-56"></a><span class="n">Convert2JP2</span><span \
class="o">::~</span><span class="n">Convert2JP2</span><span class="p">()</span> +<a \
name="line-56"></a><span class="n">Convert2PGF</span><span class="o">::~</span><span \
class="n">Convert2PGF</span><span class="p">()</span> <a name="line-57"></a><span \
class="p">{</span> <a name="line-58"></a><span class="p">}</span>
<a name="line-59"></a>
-<a name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> +<a \
name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> <a \
name="line-61"></a><span class="p">{</span>
-<a name="line-62"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">JP2KSettings</span><span class="p">();</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span> +<a name="line-62"></a><span class="hll"> <span \
class="n">m_settings</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">PGFSettings</span><span class="p">();</span><span \
class='error2'><--- Possible leak in public function. The pointer 'm_settings' is \
not deallocated before it is allocated.</span> </span><a name="line-63"></a> \
<span class="n">m_settingsWidget</span> <span class="o">=</span> <span \
class="n">m_settings</span><span class="p">;</span> <a name="line-64"></a>
<a name="line-65"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span> @@ -316,19 +316,19 \
@@ <a name="line-68"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span> <a name="line-69"></a><span class="p">}</span>
<a name="line-70"></a>
-<a name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> +<a \
name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> <a \
name="line-72"></a><span class="p">{</span> <a name="line-73"></a> <span \
class="n">KSharedConfig</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="n">config</span> <span class="o">=</span> <span \
class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span> <a name="line-74"></a> \
<span class="n">KConfigGroup</span> <span class="n">group</span> <span \
class="o">=</span> <span class="n">config</span><span class="o">-></span><span \
class="n">group</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span \
class="p">));</span>
-<a name="line-75"></a> <span class="kt">int</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEG2000Compression"</span><span class="p">),</span> <span \
class="mi">75</span><span class="p">);</span>
-<a name="line-76"></a> <span class="kt">bool</span> <span \
class="n">lossLessCompression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEG2000LossLess"</span><span class="p">),</span> <span \
class="nb">true</span><span class="p">);</span> +<a name="line-75"></a> <span \
class="kt">int</span> <span class="n">compression</span> <span \
class="o">=</span> <span class="n">group</span><span class="p">.</span><span \
class="n">readEntry</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PGFCompression"</span><span class="p">),</span> <span \
class="mi">3</span><span class="p">);</span> +<a name="line-76"></a> <span \
class="kt">bool</span> <span class="n">lossLessCompression</span> <span \
class="o">=</span> <span class="n">group</span><span class="p">.</span><span \
class="n">readEntry</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PGFLossLess"</span><span class="p">),</span> <span \
class="nb">true</span><span class="p">);</span> <a name="line-77"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> <a name="line-78"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span> <a name="line-79"></a> \
<span class="n">settings</span><span class="p">.</span><span \
class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">),</span> <span \
class="n">lossLessCompression</span><span class="p">);</span> <a name="line-80"></a> \
<span class="k">return</span> <span class="n">settings</span><span class="p">;</span> \
<a name="line-81"></a><span class="p">}</span> <a name="line-82"></a>
-<a name="line-83"></a><span class="kt">void</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span> +<a \
name="line-83"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span> <a \
name="line-84"></a><span class="p">{</span> <a name="line-85"></a> <span \
class="n">m_changeSettings</span> <span class="o">=</span> <span \
class="nb">false</span><span class="p">;</span> <a name="line-86"></a> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">setCompressionValue</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> @@ -336,7 +336,7 @@
<a name="line-88"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span class="p">;</span> <a \
name="line-89"></a><span class="p">}</span> <a name="line-90"></a>
-<a name="line-91"></a><span class="kt">void</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span> +<a \
name="line-91"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span> <a \
name="line-92"></a><span class="p">{</span> <a name="line-93"></a> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span> <a name="line-94"></a> \
<span class="p">{</span> @@ -347,12 +347,12 @@
<a name="line-99"></a> <span class="p">}</span>
<a name="line-100"></a><span class="p">}</span>
<a name="line-101"></a>
-<a name="line-102"></a><span class="n">QString</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span class="k">const</span> \
+<a name="line-102"></a><span class="n">QString</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span class="k">const</span> \
<a name="line-103"></a><span class="p">{</span>
-<a name="line-104"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"jp2"</span><span class="p">);</span> +<a name="line-104"></a> \
<span class="k">return</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span class="s">"pgf"</span><span class="p">);</span> <a \
name="line-105"></a><span class="p">}</span> <a name="line-106"></a>
-<a name="line-107"></a><span class="kt">bool</span> <span \
class="n">Convert2JP2</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span> +<a \
name="line-107"></a><span class="kt">bool</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span> <a \
name="line-108"></a><span class="p">{</span> <a name="line-109"></a> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">loadToDImg</span><span class="p">())</span> <a name="line-110"></a> \
<span class="p">{</span> @@ -360,7 +360,7 @@
<a name="line-112"></a> <span class="p">}</span>
<a name="line-113"></a>
<a name="line-114"></a> <span class="kt">bool</span> <span \
class="n">lossless</span> <span class="o">=</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">();</span>
-<a name="line-115"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">lossless</span> <span class="o">?</span> <span class="mi">100</span> <span \
class="o">:</span> <span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-115"></a> <span \
class="n">image</span><span class="p">().</span><span \
class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">lossless</span> <span class="o">?</span> <span class="mi">0</span> <span \
class="o">:</span> <span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> <a name="line-116"></a>
<a name="line-117"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span class="p">());</span> <a \
name="line-118"></a><span class="p">}</span>
diff --git a/static/reports/cppcheck/master/18.html \
b/static/reports/cppcheck/master/18.html index 3e2e38d4..291d23b3 100644
--- a/static/reports/cppcheck/master/18.html
+++ b/static/reports/cppcheck/master/18.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,10 +120,10 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2jpeg.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/queuemanager/tools/convert/convert2png.cpp </h1> </div>
<div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2jpeg.cpp</p>
+ <p id="filename"><a href="index.html">Defects:</a> convert2png.cpp</p>
<a href='18.html#line-62'> publicAllocationError 62</a>
</div>
<div id="content">
@@ -242,18 +242,13 @@
113
114
115
-116
-117
-118
-119
-120
-121</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> \
+116</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> <a \
name="line-2"></a><span class="cm"> *</span> <a name="line-3"></a><span class="cm"> \
* This file is a part of digiKam project</span> <a name="line-4"></a><span \
class="cm"> * http://www.digikam.org</span> <a name="line-5"></a><span class="cm"> \
*</span>
-<a name="line-6"></a><span class="cm"> * Date : 2008-11-24</span>
-<a name="line-7"></a><span class="cm"> * Description : JPEG image Converter batch \
tool.</span> +<a name="line-6"></a><span class="cm"> * Date : \
2008-11-28</span> +<a name="line-7"></a><span class="cm"> * Description : PNG image \
Converter batch tool.</span> <a name="line-8"></a><span class="cm"> *</span>
<a name="line-9"></a><span class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span> <a name="line-10"></a><span \
class="cm"> *</span> @@ -270,7 +265,7 @@
<a name="line-21"></a><span class="cm"> *</span>
<a name="line-22"></a><span class="cm"> * \
============================================================ */</span> <a \
name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2jpeg.h"</span><span class="cp"></span> +<a \
name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2png.h"</span><span class="cp"></span> <a \
name="line-25"></a> <a name="line-26"></a><span class="c1">// Qt includes</span>
<a name="line-27"></a>
@@ -286,29 +281,29 @@
<a name="line-37"></a><span class="c1">// Local includes</span>
<a name="line-38"></a>
<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span>
-<a name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"jpegsettings.h"</span><span class="cp"></span> +<a \
name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"pngsettings.h"</span><span class="cp"></span> <a \
name="line-41"></a> <a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span> <a name="line-43"></a><span class="p">{</span>
<a name="line-44"></a>
-<a name="line-45"></a><span class="n">Convert2JPEG</span><span \
class="o">::</span><span class="n">Convert2JPEG</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-46"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2JPEG"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-45"></a><span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">Convert2PNG</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-46"></a> <span \
class="o">:</span> <span class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2PNG"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> <a name="line-47"></a><span \
class="p">{</span> <a name="line-48"></a> <span class="n">m_settings</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span> <a \
name="line-49"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span class="p">;</span> <a \
name="line-50"></a>
-<a name="line-51"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To JPEG"</span><span \
class="p">));</span>
-<a name="line-52"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to JPEG format."</span><span \
class="p">));</span>
-<a name="line-53"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-jpeg"</span><span class="p">));</span> +<a \
name="line-51"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To PNG"</span><span class="p">));</span> +<a \
name="line-52"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to PNG format."</span><span class="p">));</span> \
+<a name="line-53"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-png"</span><span class="p">));</span> <a \
name="line-54"></a><span class="p">}</span> <a name="line-55"></a>
-<a name="line-56"></a><span class="n">Convert2JPEG</span><span \
class="o">::~</span><span class="n">Convert2JPEG</span><span class="p">()</span> +<a \
name="line-56"></a><span class="n">Convert2PNG</span><span class="o">::~</span><span \
class="n">Convert2PNG</span><span class="p">()</span> <a name="line-57"></a><span \
class="p">{</span> <a name="line-58"></a><span class="p">}</span>
<a name="line-59"></a>
-<a name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> +<a \
name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> <a \
name="line-61"></a><span class="p">{</span>
-<a name="line-62"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">JPEGSettings</span><span class="p">;</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span> +<a name="line-62"></a><span class="hll"> <span \
class="n">m_settings</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">PNGSettings</span><span class="p">();</span><span \
class='error2'><--- Possible leak in public function. The pointer 'm_settings' is \
not deallocated before it is allocated.</span> </span><a name="line-63"></a> \
<span class="n">m_settingsWidget</span> <span class="o">=</span> <span \
class="n">m_settings</span><span class="p">;</span> <a name="line-64"></a>
<a name="line-65"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span> @@ -317,57 +312,52 \
@@ <a name="line-68"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span> <a name="line-69"></a><span class="p">}</span>
<a name="line-70"></a>
-<a name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> +<a \
name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> <a \
name="line-72"></a><span class="p">{</span> <a name="line-73"></a> <span \
class="n">KSharedConfig</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="n">config</span> <span class="o">=</span> <span \
class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span> <a name="line-74"></a> \
<span class="n">KConfigGroup</span> <span class="n">group</span> <span \
class="o">=</span> <span class="n">config</span><span class="o">-></span><span \
class="n">group</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span \
class="p">));</span>
-<a name="line-75"></a> <span class="kt">int</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEGCompression"</span><span class="p">),</span> <span \
class="mi">75</span><span class="p">);</span>
-<a name="line-76"></a> <span class="kt">int</span> <span \
class="n">subSampling</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"JPEGSubSampling"</span><span class="p">),</span> <span \
class="mi">1</span><span class="p">);</span> <span class="c1">// Medium \
subsampling</span>
-<a name="line-77"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-78"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span>
-<a name="line-79"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">),</span> <span \
class="n">subSampling</span><span class="p">);</span>
-<a name="line-80"></a> <span class="k">return</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-81"></a><span class="p">}</span>
-<a name="line-82"></a>
-<a name="line-83"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span>
-<a name="line-84"></a><span class="p">{</span>
-<a name="line-85"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">false</span><span \
class="p">;</span>
-<a name="line-86"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setCompressionValue</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-87"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setSubSamplingValue</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-88"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-89"></a><span class="p">}</span>
-<a name="line-90"></a>
-<a name="line-91"></a><span class="kt">void</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span>
-<a name="line-92"></a><span class="p">{</span>
-<a name="line-93"></a> <span class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span>
-<a name="line-94"></a> <span class="p">{</span>
-<a name="line-95"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-96"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompressionValue</span><span class="p">());</span>
-<a name="line-97"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getSubSamplingValue</span><span class="p">());</span>
-<a name="line-98"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span \
class="p">);</span>
-<a name="line-99"></a> <span class="p">}</span>
-<a name="line-100"></a><span class="p">}</span>
-<a name="line-101"></a>
-<a name="line-102"></a><span class="n">QString</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span \
class="k">const</span>
-<a name="line-103"></a><span class="p">{</span>
-<a name="line-104"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"jpg"</span><span class="p">);</span>
-<a name="line-105"></a><span class="p">}</span>
-<a name="line-106"></a>
-<a name="line-107"></a><span class="kt">bool</span> <span \
class="n">Convert2JPEG</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span>
-<a name="line-108"></a><span class="p">{</span>
-<a name="line-109"></a> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">loadToDImg</span><span \
class="p">())</span>
-<a name="line-110"></a> <span class="p">{</span>
-<a name="line-111"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span>
-<a name="line-112"></a> <span class="p">}</span>
-<a name="line-113"></a>
-<a name="line-114"></a> <span class="kt">int</span> <span \
class="n">JPEGCompression</span> <span class="o">=</span> <span \
class="n">JPEGSettings</span><span class="o">::</span><span \
class="n">convertCompressionForLibJpeg</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-115"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">JPEGCompression</span><span class="p">);</span>
-<a name="line-116"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"subsampling"</span><span class="p">),</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"SubSampling"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-117"></a>
-<a name="line-118"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span \
class="p">());</span>
-<a name="line-119"></a><span class="p">}</span>
-<a name="line-120"></a>
-<a name="line-121"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> +<a name="line-75"></a> <span class="kt">int</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PNGCompression"</span><span class="p">),</span> <span \
class="mi">9</span><span class="p">);</span> +<a name="line-76"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-77"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span> +<a name="line-78"></a> \
<span class="k">return</span> <span class="n">settings</span><span class="p">;</span> \
+<a name="line-79"></a><span class="p">}</span> +<a name="line-80"></a>
+<a name="line-81"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span> +<a \
name="line-82"></a><span class="p">{</span> +<a name="line-83"></a> <span \
class="n">m_changeSettings</span> <span class="o">=</span> <span \
class="nb">false</span><span class="p">;</span> +<a name="line-84"></a> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">setCompressionValue</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-85"></a> <span \
class="n">m_changeSettings</span> <span class="o">=</span> <span \
class="nb">true</span><span class="p">;</span> +<a name="line-86"></a><span \
class="p">}</span> +<a name="line-87"></a>
+<a name="line-88"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span> +<a \
name="line-89"></a><span class="p">{</span> +<a name="line-90"></a> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span> +<a name="line-91"></a> \
<span class="p">{</span> +<a name="line-92"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-93"></a> <span \
class="n">settings</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompressionValue</span><span class="p">());</span> +<a \
name="line-94"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span class="p">);</span> +<a \
name="line-95"></a> <span class="p">}</span> +<a name="line-96"></a><span \
class="p">}</span> +<a name="line-97"></a>
+<a name="line-98"></a><span class="n">QString</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span class="k">const</span> \
+<a name="line-99"></a><span class="p">{</span> +<a name="line-100"></a> <span \
class="k">return</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span class="s">"png"</span><span class="p">);</span> +<a \
name="line-101"></a><span class="p">}</span> +<a name="line-102"></a>
+<a name="line-103"></a><span class="kt">bool</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span> +<a \
name="line-104"></a><span class="p">{</span> +<a name="line-105"></a> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">loadToDImg</span><span class="p">())</span> +<a name="line-106"></a> \
<span class="p">{</span> +<a name="line-107"></a> <span \
class="k">return</span> <span class="nb">false</span><span class="p">;</span> +<a \
name="line-108"></a> <span class="p">}</span> +<a name="line-109"></a>
+<a name="line-110"></a> <span class="kt">int</span> <span \
class="n">PNGCompression</span> <span class="o">=</span> <span \
class="n">PNGSettings</span><span class="o">::</span><span \
class="n">convertCompressionForLibPng</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span> +<a name="line-111"></a> <span \
class="n">image</span><span class="p">().</span><span \
class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">PNGCompression</span><span class="p">);</span> +<a name="line-112"></a>
+<a name="line-113"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span class="p">());</span> +<a \
name="line-114"></a><span class="p">}</span> +<a name="line-115"></a>
+<a name="line-116"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> </pre></div>
</td></tr></table>
</div>
diff --git a/static/reports/cppcheck/master/19.html \
b/static/reports/cppcheck/master/19.html index e7f9950d..5b63e0aa 100644
--- a/static/reports/cppcheck/master/19.html
+++ b/static/reports/cppcheck/master/19.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,11 +120,11 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2pgf.cpp </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/utilities/queuemanager/tools/convert/convert2tiff.cpp </h1> </div>
<div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2pgf.cpp</p>
-<a href='19.html#line-62'> publicAllocationError 62</a>
+ <p id="filename"><a href="index.html">Defects:</a> convert2tiff.cpp</p>
+<a href='19.html#line-61'> publicAllocationError 61</a>
</div>
<div id="content">
<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> \
1 @@ -235,26 +235,15 @@
106
107
108
-109
-110
-111
-112
-113
-114
-115
-116
-117
-118
-119
-120</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> \
+109</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span> <a \
name="line-2"></a><span class="cm"> *</span> <a name="line-3"></a><span class="cm"> \
* This file is a part of digiKam project</span> <a name="line-4"></a><span \
class="cm"> * http://www.digikam.org</span> <a name="line-5"></a><span class="cm"> \
*</span>
-<a name="line-6"></a><span class="cm"> * Date : 2009-06-18</span>
-<a name="line-7"></a><span class="cm"> * Description : PGF image Converter batch \
tool.</span> +<a name="line-6"></a><span class="cm"> * Date : \
2008-11-28</span> +<a name="line-7"></a><span class="cm"> * Description : TIFF image \
Converter batch tool.</span> <a name="line-8"></a><span class="cm"> *</span>
-<a name="line-9"></a><span class="cm"> * Copyright (C) 2009-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span> +<a name="line-9"></a><span \
class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier <caulier dot gilles at \
gmail dot com></span> <a name="line-10"></a><span class="cm"> *</span>
<a name="line-11"></a><span class="cm"> * This program is free software; you can \
redistribute it</span> <a name="line-12"></a><span class="cm"> * and/or modify it \
under the terms of the GNU General</span> @@ -269,7 +258,7 @@
<a name="line-21"></a><span class="cm"> *</span>
<a name="line-22"></a><span class="cm"> * \
============================================================ */</span> <a \
name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2pgf.h"</span><span class="cp"></span> +<a \
name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2tiff.h"</span><span class="cp"></span> <a \
name="line-25"></a> <a name="line-26"></a><span class="c1">// Qt includes</span>
<a name="line-27"></a>
@@ -285,87 +274,76 @@
<a name="line-37"></a><span class="c1">// Local includes</span>
<a name="line-38"></a>
<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span>
-<a name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"pgfsettings.h"</span><span class="cp"></span> +<a \
name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"tiffsettings.h"</span><span class="cp"></span> <a \
name="line-41"></a> <a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span> <a name="line-43"></a><span class="p">{</span>
<a name="line-44"></a>
-<a name="line-45"></a><span class="n">Convert2PGF</span><span \
class="o">::</span><span class="n">Convert2PGF</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-46"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2PGF"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-45"></a><span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">Convert2TIFF</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span> +<a name="line-46"></a> <span \
class="o">:</span> <span class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2TIFF"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span> <a name="line-47"></a><span \
class="p">{</span> <a name="line-48"></a> <span class="n">m_settings</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span>
-<a name="line-49"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-50"></a>
-<a name="line-51"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To PGF"</span><span class="p">));</span>
-<a name="line-52"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to PGF format."</span><span \
class="p">));</span>
-<a name="line-53"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-jpeg"</span><span class="p">));</span>
-<a name="line-54"></a><span class="p">}</span>
-<a name="line-55"></a>
-<a name="line-56"></a><span class="n">Convert2PGF</span><span \
class="o">::~</span><span class="n">Convert2PGF</span><span \
class="p">()</span>
-<a name="line-57"></a><span class="p">{</span>
-<a name="line-58"></a><span class="p">}</span>
-<a name="line-59"></a>
-<a name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span>
-<a name="line-61"></a><span class="p">{</span>
-<a name="line-62"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">PGFSettings</span><span class="p">();</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span>
-</span><a name="line-63"></a> <span class="n">m_settingsWidget</span> <span \
class="o">=</span> <span class="n">m_settings</span><span \
class="p">;</span>
-<a name="line-64"></a>
-<a name="line-65"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span>
-<a name="line-66"></a> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span>
-<a name="line-67"></a>
-<a name="line-68"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span>
-<a name="line-69"></a><span class="p">}</span>
-<a name="line-70"></a>
-<a name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span>
-<a name="line-72"></a><span class="p">{</span>
-<a name="line-73"></a> <span class="n">KSharedConfig</span><span \
class="o">::</span><span class="n">Ptr</span> <span class="n">config</span> <span \
class="o">=</span> <span class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span>
-<a name="line-74"></a> <span class="n">KConfigGroup</span> <span \
class="n">group</span> <span class="o">=</span> <span \
class="n">config</span><span class="o">-></span><span class="n">group</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span \
class="p">));</span>
-<a name="line-75"></a> <span class="kt">int</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PGFCompression"</span><span class="p">),</span> <span \
class="mi">3</span><span class="p">);</span>
-<a name="line-76"></a> <span class="kt">bool</span> <span \
class="n">lossLessCompression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PGFLossLess"</span><span class="p">),</span> <span \
class="nb">true</span><span class="p">);</span>
-<a name="line-77"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-78"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span>
-<a name="line-79"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">),</span> <span \
class="n">lossLessCompression</span><span class="p">);</span>
-<a name="line-80"></a> <span class="k">return</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-81"></a><span class="p">}</span>
-<a name="line-82"></a>
-<a name="line-83"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span>
-<a name="line-84"></a><span class="p">{</span>
-<a name="line-85"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">false</span><span \
class="p">;</span>
-<a name="line-86"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setCompressionValue</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-87"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setLossLessCompression</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-88"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-89"></a><span class="p">}</span>
-<a name="line-90"></a>
-<a name="line-91"></a><span class="kt">void</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span>
-<a name="line-92"></a><span class="p">{</span>
-<a name="line-93"></a> <span class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span>
-<a name="line-94"></a> <span class="p">{</span>
-<a name="line-95"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-96"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompressionValue</span><span class="p">());</span>
-<a name="line-97"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getLossLessCompression</span><span class="p">());</span>
-<a name="line-98"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span \
class="p">);</span>
-<a name="line-99"></a> <span class="p">}</span>
-<a name="line-100"></a><span class="p">}</span>
-<a name="line-101"></a>
-<a name="line-102"></a><span class="n">QString</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span \
class="k">const</span>
-<a name="line-103"></a><span class="p">{</span>
-<a name="line-104"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"pgf"</span><span class="p">);</span>
-<a name="line-105"></a><span class="p">}</span>
-<a name="line-106"></a>
-<a name="line-107"></a><span class="kt">bool</span> <span \
class="n">Convert2PGF</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span>
-<a name="line-108"></a><span class="p">{</span>
-<a name="line-109"></a> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">loadToDImg</span><span \
class="p">())</span>
-<a name="line-110"></a> <span class="p">{</span>
-<a name="line-111"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span>
-<a name="line-112"></a> <span class="p">}</span>
-<a name="line-113"></a>
-<a name="line-114"></a> <span class="kt">bool</span> <span \
class="n">lossless</span> <span class="o">=</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"lossless"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">();</span>
-<a name="line-115"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">lossless</span> <span class="o">?</span> <span class="mi">0</span> <span \
class="o">:</span> <span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-116"></a>
-<a name="line-117"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span \
class="p">());</span>
-<a name="line-118"></a><span class="p">}</span>
-<a name="line-119"></a>
-<a name="line-120"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> +<a name="line-49"></a>
+<a name="line-50"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To TIFF"</span><span class="p">));</span> +<a \
name="line-51"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to TIFF format."</span><span class="p">));</span> \
+<a name="line-52"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-tiff"</span><span class="p">));</span> +<a \
name="line-53"></a><span class="p">}</span> +<a name="line-54"></a>
+<a name="line-55"></a><span class="n">Convert2TIFF</span><span \
class="o">::~</span><span class="n">Convert2TIFF</span><span class="p">()</span> +<a \
name="line-56"></a><span class="p">{</span> +<a name="line-57"></a><span \
class="p">}</span> +<a name="line-58"></a>
+<a name="line-59"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span> +<a \
name="line-60"></a><span class="p">{</span> +<a name="line-61"></a><span class="hll"> \
<span class="n">m_settings</span> <span class="o">=</span> <span \
class="k">new</span> <span class="n">TIFFSettings</span><span \
class="p">();</span><span class='error2'><--- Possible leak in public function. \
The pointer 'm_settings' is not deallocated before it is allocated.</span> +</span><a \
name="line-62"></a> <span class="n">m_settingsWidget</span> <span \
class="o">=</span> <span class="n">m_settings</span><span class="p">;</span> +<a \
name="line-63"></a> +<a name="line-64"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span> +<a \
name="line-65"></a> <span class="k">this</span><span class="p">,</span> \
<span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span> +<a \
name="line-66"></a> +<a name="line-67"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span> +<a name="line-68"></a><span class="p">}</span>
+<a name="line-69"></a>
+<a name="line-70"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span> +<a \
name="line-71"></a><span class="p">{</span> +<a name="line-72"></a> <span \
class="n">KSharedConfig</span><span class="o">::</span><span class="n">Ptr</span> \
<span class="n">config</span> <span class="o">=</span> <span \
class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span> +<a name="line-73"></a> \
<span class="n">KConfigGroup</span> <span class="n">group</span> <span \
class="o">=</span> <span class="n">config</span><span class="o">-></span><span \
class="n">group</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span class="p">));</span> +<a \
name="line-74"></a> <span class="kt">bool</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"TIFFCompression"</span><span class="p">),</span> <span \
class="nb">false</span><span class="p">);</span> +<a name="line-75"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-76"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span> +<a name="line-77"></a> \
<span class="k">return</span> <span class="n">settings</span><span class="p">;</span> \
+<a name="line-78"></a><span class="p">}</span> +<a name="line-79"></a>
+<a name="line-80"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span> +<a \
name="line-81"></a><span class="p">{</span> +<a name="line-82"></a> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">setCompression</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span> +<a name="line-83"></a><span \
class="p">}</span> +<a name="line-84"></a>
+<a name="line-85"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span> +<a \
name="line-86"></a><span class="p">{</span> +<a name="line-87"></a> <span \
class="n">BatchToolSettings</span> <span class="n">settings</span><span \
class="p">;</span> +<a name="line-88"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompression</span><span class="p">());</span> +<a name="line-89"></a> \
<span class="n">BatchTool</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">(</span><span \
class="n">settings</span><span class="p">);</span> +<a name="line-90"></a><span \
class="p">}</span> +<a name="line-91"></a>
+<a name="line-92"></a><span class="n">QString</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span class="k">const</span> \
+<a name="line-93"></a><span class="p">{</span> +<a name="line-94"></a> <span \
class="k">return</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span class="s">"tif"</span><span class="p">);</span> +<a \
name="line-95"></a><span class="p">}</span> +<a name="line-96"></a>
+<a name="line-97"></a><span class="kt">bool</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span> +<a name="line-98"></a><span \
class="p">{</span> +<a name="line-99"></a> <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span class="n">loadToDImg</span><span \
class="p">())</span> +<a name="line-100"></a> <span class="p">{</span>
+<a name="line-101"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span> +<a name="line-102"></a> <span \
class="p">}</span> +<a name="line-103"></a>
+<a name="line-104"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">),</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span> +<a name="line-105"></a>
+<a name="line-106"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span class="p">());</span> +<a \
name="line-107"></a><span class="p">}</span> +<a name="line-108"></a>
+<a name="line-109"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span> </pre></div>
</td></tr></table>
</div>
diff --git a/static/reports/cppcheck/master/2.html \
b/static/reports/cppcheck/master/2.html index c8ba23f2..021d30c5 100644
--- a/static/reports/cppcheck/master/2.html
+++ b/static/reports/cppcheck/master/2.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/coredb/coredbfields.h </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/database/coredb/coredbfields.h </h1> \
</div> <div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> coredbfields.h</p>
diff --git a/static/reports/cppcheck/master/20.html \
b/static/reports/cppcheck/master/20.html deleted file mode 100644
index f13a72a7..00000000
--- a/static/reports/cppcheck/master/20.html
+++ /dev/null
@@ -1,359 +0,0 @@
-
-<!DOCTYPE html>
-<html lang="en">
- <head>
- <meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
- <link rel="stylesheet" href="style.css">
- <style>
-.highlight .hll { background-color: #ffffcc }
-.highlight { background: #ffffff; }
-.highlight .c { color: #888888 } /* Comment */
-.highlight .err { color: #FF0000; background-color: #FFAAAA } /* Error */
-.highlight .k { color: #008800; font-weight: bold } /* Keyword */
-.highlight .o { color: #333333 } /* Operator */
-.highlight .ch { color: #888888 } /* Comment.Hashbang */
-.highlight .cm { color: #888888 } /* Comment.Multiline */
-.highlight .cp { color: #557799 } /* Comment.Preproc */
-.highlight .cpf { color: #888888 } /* Comment.PreprocFile */
-.highlight .c1 { color: #888888 } /* Comment.Single */
-.highlight .cs { color: #cc0000; font-weight: bold } /* Comment.Special */
-.highlight .gd { color: #A00000 } /* Generic.Deleted */
-.highlight .ge { font-style: italic } /* Generic.Emph */
-.highlight .gr { color: #FF0000 } /* Generic.Error */
-.highlight .gh { color: #000080; font-weight: bold } /* Generic.Heading */
-.highlight .gi { color: #00A000 } /* Generic.Inserted */
-.highlight .go { color: #888888 } /* Generic.Output */
-.highlight .gp { color: #c65d09; font-weight: bold } /* Generic.Prompt */
-.highlight .gs { font-weight: bold } /* Generic.Strong */
-.highlight .gu { color: #800080; font-weight: bold } /* Generic.Subheading */
-.highlight .gt { color: #0044DD } /* Generic.Traceback */
-.highlight .kc { color: #008800; font-weight: bold } /* Keyword.Constant */
-.highlight .kd { color: #008800; font-weight: bold } /* Keyword.Declaration */
-.highlight .kn { color: #008800; font-weight: bold } /* Keyword.Namespace */
-.highlight .kp { color: #003388; font-weight: bold } /* Keyword.Pseudo */
-.highlight .kr { color: #008800; font-weight: bold } /* Keyword.Reserved */
-.highlight .kt { color: #333399; font-weight: bold } /* Keyword.Type */
-.highlight .m { color: #6600EE; font-weight: bold } /* Literal.Number */
-.highlight .s { background-color: #fff0f0 } /* Literal.String */
-.highlight .na { color: #0000CC } /* Name.Attribute */
-.highlight .nb { color: #007020 } /* Name.Builtin */
-.highlight .nc { color: #BB0066; font-weight: bold } /* Name.Class */
-.highlight .no { color: #003366; font-weight: bold } /* Name.Constant */
-.highlight .nd { color: #555555; font-weight: bold } /* Name.Decorator */
-.highlight .ni { color: #880000; font-weight: bold } /* Name.Entity */
-.highlight .ne { color: #FF0000; font-weight: bold } /* Name.Exception */
-.highlight .nf { color: #0066BB; font-weight: bold } /* Name.Function */
-.highlight .nl { color: #997700; font-weight: bold } /* Name.Label */
-.highlight .nn { color: #0e84b5; font-weight: bold } /* Name.Namespace */
-.highlight .nt { color: #007700 } /* Name.Tag */
-.highlight .nv { color: #996633 } /* Name.Variable */
-.highlight .ow { color: #000000; font-weight: bold } /* Operator.Word */
-.highlight .w { color: #bbbbbb } /* Text.Whitespace */
-.highlight .mb { color: #6600EE; font-weight: bold } /* Literal.Number.Bin */
-.highlight .mf { color: #6600EE; font-weight: bold } /* Literal.Number.Float */
-.highlight .mh { color: #005588; font-weight: bold } /* Literal.Number.Hex */
-.highlight .mi { color: #0000DD; font-weight: bold } /* Literal.Number.Integer */
-.highlight .mo { color: #4400EE; font-weight: bold } /* Literal.Number.Oct */
-.highlight .sb { background-color: #fff0f0 } /* Literal.String.Backtick */
-.highlight .sc { color: #0044DD } /* Literal.String.Char */
-.highlight .sd { color: #DD4422 } /* Literal.String.Doc */
-.highlight .s2 { background-color: #fff0f0 } /* Literal.String.Double */
-.highlight .se { color: #666666; font-weight: bold; background-color: #fff0f0 } /* \
Literal.String.Escape */
-.highlight .sh { background-color: #fff0f0 } /* Literal.String.Heredoc */
-.highlight .si { background-color: #eeeeee } /* Literal.String.Interpol */
-.highlight .sx { color: #DD2200; background-color: #fff0f0 } /* Literal.String.Other \
*/
-.highlight .sr { color: #000000; background-color: #fff0ff } /* Literal.String.Regex \
*/
-.highlight .s1 { background-color: #fff0f0 } /* Literal.String.Single */
-.highlight .ss { color: #AA6600 } /* Literal.String.Symbol */
-.highlight .bp { color: #007020 } /* Name.Builtin.Pseudo */
-.highlight .vc { color: #336699 } /* Name.Variable.Class */
-.highlight .vg { color: #dd7700; font-weight: bold } /* Name.Variable.Global */
-.highlight .vi { color: #3333BB } /* Name.Variable.Instance */
-.highlight .il { color: #0000DD; font-weight: bold } /* Literal.Number.Integer.Long \
*/
- </style>
- <script language="javascript">
- function getStyle(el,styleProp) {
- if (el.currentStyle)
- var y = el.currentStyle[styleProp];
- else if (window.getComputedStyle)
- var y = document.defaultView.getComputedStyle(el,null).getPropertyValue(styleProp);
- return y;
- }
- function toggle() {
- var el = this.expandable_content;
- var mark = this.expandable_marker;
- if (el.style.display == "block") {
- el.style.display = "none";
- mark.innerHTML = "[+]";
- } else {
- el.style.display = "block";
- mark.innerHTML = "[-]";
- }
- }
- function init_expandables() {
- var elts = document.getElementsByClassName("expandable");
- for (var i = 0; i < elts.length; i++) {
- var el = elts[i];
- var clickable = el.getElementsByTagName("span")[0];
- var marker = clickable.getElementsByClassName("marker")[0];
- var content = el.getElementsByClassName("content")[0];
- var width = clickable.clientWidth - parseInt(getStyle(content, \
"padding-left")) - parseInt(getStyle(content, "padding-right"));
- content.style.width = width + "px";
- clickable.expandable_content = content;
- clickable.expandable_marker = marker;
- clickable.onclick = toggle;
- }
- }
- function set_class_display(c, st) {
- var elements = document.querySelectorAll('.' + c),
- len = elements.length;
- for (i = 0; i < len; i++) {
- elements[i].style.display = st;
- }
- }
- function toggle_class_visibility(id) {
- var box = document.getElementById(id);
- set_class_display(id, box.checked ? '' : 'none');
- }
- </script>
- </head>
- <body onload="init_expandables()">
- <div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2tiff.cpp \
</h1>
- </div>
- <div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2tiff.cpp</p>
-<a href='20.html#line-61'> publicAllocationError 61</a>
- </div>
- <div id="content">
-<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> \
1
- 2
- 3
- 4
- 5
- 6
- 7
- 8
- 9
- 10
- 11
- 12
- 13
- 14
- 15
- 16
- 17
- 18
- 19
- 20
- 21
- 22
- 23
- 24
- 25
- 26
- 27
- 28
- 29
- 30
- 31
- 32
- 33
- 34
- 35
- 36
- 37
- 38
- 39
- 40
- 41
- 42
- 43
- 44
- 45
- 46
- 47
- 48
- 49
- 50
- 51
- 52
- 53
- 54
- 55
- 56
- 57
- 58
- 59
- 60
- 61
- 62
- 63
- 64
- 65
- 66
- 67
- 68
- 69
- 70
- 71
- 72
- 73
- 74
- 75
- 76
- 77
- 78
- 79
- 80
- 81
- 82
- 83
- 84
- 85
- 86
- 87
- 88
- 89
- 90
- 91
- 92
- 93
- 94
- 95
- 96
- 97
- 98
- 99
-100
-101
-102
-103
-104
-105
-106
-107
-108
-109</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span>
-<a name="line-2"></a><span class="cm"> *</span>
-<a name="line-3"></a><span class="cm"> * This file is a part of digiKam \
project</span>
-<a name="line-4"></a><span class="cm"> * http://www.digikam.org</span>
-<a name="line-5"></a><span class="cm"> *</span>
-<a name="line-6"></a><span class="cm"> * Date : 2008-11-28</span>
-<a name="line-7"></a><span class="cm"> * Description : TIFF image Converter batch \
tool.</span>
-<a name="line-8"></a><span class="cm"> *</span>
-<a name="line-9"></a><span class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span>
-<a name="line-10"></a><span class="cm"> *</span>
-<a name="line-11"></a><span class="cm"> * This program is free software; you can \
redistribute it</span>
-<a name="line-12"></a><span class="cm"> * and/or modify it under the terms of the \
GNU General</span>
-<a name="line-13"></a><span class="cm"> * Public License as published by the Free \
Software Foundation;</span>
-<a name="line-14"></a><span class="cm"> * either version 2, or (at your \
option)</span>
-<a name="line-15"></a><span class="cm"> * any later version.</span>
-<a name="line-16"></a><span class="cm"> *</span>
-<a name="line-17"></a><span class="cm"> * This program is distributed in the hope \
that it will be useful,</span>
-<a name="line-18"></a><span class="cm"> * but WITHOUT ANY WARRANTY; without even the \
implied warranty of</span>
-<a name="line-19"></a><span class="cm"> * MERCHANTABILITY or FITNESS FOR A \
PARTICULAR PURPOSE. See the</span>
-<a name="line-20"></a><span class="cm"> * GNU General Public License for more \
details.</span>
-<a name="line-21"></a><span class="cm"> *</span>
-<a name="line-22"></a><span class="cm"> * \
============================================================ \
*/</span>
-<a name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2tiff.h"</span><span class="cp"></span>
-<a name="line-25"></a>
-<a name="line-26"></a><span class="c1">// Qt includes</span>
-<a name="line-27"></a>
-<a name="line-28"></a><span class="cp">#include</span> <span \
class="cpf"><QFileInfo></span><span class="cp"></span>
-<a name="line-29"></a><span class="cp">#include</span> <span \
class="cpf"><QWidget></span><span class="cp"></span>
-<a name="line-30"></a>
-<a name="line-31"></a><span class="c1">// KDE includes</span>
-<a name="line-32"></a>
-<a name="line-33"></a><span class="cp">#include</span> <span \
class="cpf"><kconfiggroup.h></span><span class="cp"></span>
-<a name="line-34"></a><span class="cp">#include</span> <span \
class="cpf"><klocalizedstring.h></span><span class="cp"></span>
-<a name="line-35"></a><span class="cp">#include</span> <span \
class="cpf"><ksharedconfig.h></span><span class="cp"></span>
-<a name="line-36"></a>
-<a name="line-37"></a><span class="c1">// Local includes</span>
-<a name="line-38"></a>
-<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span>
-<a name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"tiffsettings.h"</span><span class="cp"></span>
-<a name="line-41"></a>
-<a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span>
-<a name="line-43"></a><span class="p">{</span>
-<a name="line-44"></a>
-<a name="line-45"></a><span class="n">Convert2TIFF</span><span \
class="o">::</span><span class="n">Convert2TIFF</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-46"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2TIFF"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-47"></a><span class="p">{</span>
-<a name="line-48"></a> <span class="n">m_settings</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span>
-<a name="line-49"></a>
-<a name="line-50"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To TIFF"</span><span \
class="p">));</span>
-<a name="line-51"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to TIFF format."</span><span \
class="p">));</span>
-<a name="line-52"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-tiff"</span><span class="p">));</span>
-<a name="line-53"></a><span class="p">}</span>
-<a name="line-54"></a>
-<a name="line-55"></a><span class="n">Convert2TIFF</span><span \
class="o">::~</span><span class="n">Convert2TIFF</span><span \
class="p">()</span>
-<a name="line-56"></a><span class="p">{</span>
-<a name="line-57"></a><span class="p">}</span>
-<a name="line-58"></a>
-<a name="line-59"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span>
-<a name="line-60"></a><span class="p">{</span>
-<a name="line-61"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">TIFFSettings</span><span class="p">();</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span>
-</span><a name="line-62"></a> <span class="n">m_settingsWidget</span> <span \
class="o">=</span> <span class="n">m_settings</span><span \
class="p">;</span>
-<a name="line-63"></a>
-<a name="line-64"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span>
-<a name="line-65"></a> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span>
-<a name="line-66"></a>
-<a name="line-67"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span>
-<a name="line-68"></a><span class="p">}</span>
-<a name="line-69"></a>
-<a name="line-70"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span>
-<a name="line-71"></a><span class="p">{</span>
-<a name="line-72"></a> <span class="n">KSharedConfig</span><span \
class="o">::</span><span class="n">Ptr</span> <span class="n">config</span> <span \
class="o">=</span> <span class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span>
-<a name="line-73"></a> <span class="n">KConfigGroup</span> <span \
class="n">group</span> <span class="o">=</span> <span \
class="n">config</span><span class="o">-></span><span class="n">group</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span \
class="p">));</span>
-<a name="line-74"></a> <span class="kt">bool</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"TIFFCompression"</span><span class="p">),</span> <span \
class="nb">false</span><span class="p">);</span>
-<a name="line-75"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-76"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span>
-<a name="line-77"></a> <span class="k">return</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-78"></a><span class="p">}</span>
-<a name="line-79"></a>
-<a name="line-80"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span>
-<a name="line-81"></a><span class="p">{</span>
-<a name="line-82"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setCompression</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-83"></a><span class="p">}</span>
-<a name="line-84"></a>
-<a name="line-85"></a><span class="kt">void</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span>
-<a name="line-86"></a><span class="p">{</span>
-<a name="line-87"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-88"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompression</span><span class="p">());</span>
-<a name="line-89"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span \
class="p">);</span>
-<a name="line-90"></a><span class="p">}</span>
-<a name="line-91"></a>
-<a name="line-92"></a><span class="n">QString</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span \
class="k">const</span>
-<a name="line-93"></a><span class="p">{</span>
-<a name="line-94"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"tif"</span><span class="p">);</span>
-<a name="line-95"></a><span class="p">}</span>
-<a name="line-96"></a>
-<a name="line-97"></a><span class="kt">bool</span> <span \
class="n">Convert2TIFF</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span>
-<a name="line-98"></a><span class="p">{</span>
-<a name="line-99"></a> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">loadToDImg</span><span \
class="p">())</span>
-<a name="line-100"></a> <span class="p">{</span>
-<a name="line-101"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span>
-<a name="line-102"></a> <span class="p">}</span>
-<a name="line-103"></a>
-<a name="line-104"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">),</span> <span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"compress"</span><span class="p">)].</span><span \
class="n">toBool</span><span class="p">());</span>
-<a name="line-105"></a>
-<a name="line-106"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span \
class="p">());</span>
-<a name="line-107"></a><span class="p">}</span>
-<a name="line-108"></a>
-<a name="line-109"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span>
-</pre></div>
-</td></tr></table>
- </div>
- <div id="footer">
- <p>
- Cppcheck 1.77 - a tool for static C/C++ code analysis</br>
- </br>
- Internet: <a href="http://cppcheck.net">http://cppcheck.net</a></br>
- IRC: <a href="irc://irc.freenode.net/cppcheck">irc://irc.freenode.net/cppcheck</a></br>
- <p>
- </div>
- </body>
-</html>
diff --git a/static/reports/cppcheck/master/21.html \
b/static/reports/cppcheck/master/21.html deleted file mode 100644
index 50b08d40..00000000
--- a/static/reports/cppcheck/master/21.html
+++ /dev/null
@@ -1,373 +0,0 @@
-
-<!DOCTYPE html>
-<html lang="en">
- <head>
- <meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
- <link rel="stylesheet" href="style.css">
- <style>
-.highlight .hll { background-color: #ffffcc }
-.highlight { background: #ffffff; }
-.highlight .c { color: #888888 } /* Comment */
-.highlight .err { color: #FF0000; background-color: #FFAAAA } /* Error */
-.highlight .k { color: #008800; font-weight: bold } /* Keyword */
-.highlight .o { color: #333333 } /* Operator */
-.highlight .ch { color: #888888 } /* Comment.Hashbang */
-.highlight .cm { color: #888888 } /* Comment.Multiline */
-.highlight .cp { color: #557799 } /* Comment.Preproc */
-.highlight .cpf { color: #888888 } /* Comment.PreprocFile */
-.highlight .c1 { color: #888888 } /* Comment.Single */
-.highlight .cs { color: #cc0000; font-weight: bold } /* Comment.Special */
-.highlight .gd { color: #A00000 } /* Generic.Deleted */
-.highlight .ge { font-style: italic } /* Generic.Emph */
-.highlight .gr { color: #FF0000 } /* Generic.Error */
-.highlight .gh { color: #000080; font-weight: bold } /* Generic.Heading */
-.highlight .gi { color: #00A000 } /* Generic.Inserted */
-.highlight .go { color: #888888 } /* Generic.Output */
-.highlight .gp { color: #c65d09; font-weight: bold } /* Generic.Prompt */
-.highlight .gs { font-weight: bold } /* Generic.Strong */
-.highlight .gu { color: #800080; font-weight: bold } /* Generic.Subheading */
-.highlight .gt { color: #0044DD } /* Generic.Traceback */
-.highlight .kc { color: #008800; font-weight: bold } /* Keyword.Constant */
-.highlight .kd { color: #008800; font-weight: bold } /* Keyword.Declaration */
-.highlight .kn { color: #008800; font-weight: bold } /* Keyword.Namespace */
-.highlight .kp { color: #003388; font-weight: bold } /* Keyword.Pseudo */
-.highlight .kr { color: #008800; font-weight: bold } /* Keyword.Reserved */
-.highlight .kt { color: #333399; font-weight: bold } /* Keyword.Type */
-.highlight .m { color: #6600EE; font-weight: bold } /* Literal.Number */
-.highlight .s { background-color: #fff0f0 } /* Literal.String */
-.highlight .na { color: #0000CC } /* Name.Attribute */
-.highlight .nb { color: #007020 } /* Name.Builtin */
-.highlight .nc { color: #BB0066; font-weight: bold } /* Name.Class */
-.highlight .no { color: #003366; font-weight: bold } /* Name.Constant */
-.highlight .nd { color: #555555; font-weight: bold } /* Name.Decorator */
-.highlight .ni { color: #880000; font-weight: bold } /* Name.Entity */
-.highlight .ne { color: #FF0000; font-weight: bold } /* Name.Exception */
-.highlight .nf { color: #0066BB; font-weight: bold } /* Name.Function */
-.highlight .nl { color: #997700; font-weight: bold } /* Name.Label */
-.highlight .nn { color: #0e84b5; font-weight: bold } /* Name.Namespace */
-.highlight .nt { color: #007700 } /* Name.Tag */
-.highlight .nv { color: #996633 } /* Name.Variable */
-.highlight .ow { color: #000000; font-weight: bold } /* Operator.Word */
-.highlight .w { color: #bbbbbb } /* Text.Whitespace */
-.highlight .mb { color: #6600EE; font-weight: bold } /* Literal.Number.Bin */
-.highlight .mf { color: #6600EE; font-weight: bold } /* Literal.Number.Float */
-.highlight .mh { color: #005588; font-weight: bold } /* Literal.Number.Hex */
-.highlight .mi { color: #0000DD; font-weight: bold } /* Literal.Number.Integer */
-.highlight .mo { color: #4400EE; font-weight: bold } /* Literal.Number.Oct */
-.highlight .sb { background-color: #fff0f0 } /* Literal.String.Backtick */
-.highlight .sc { color: #0044DD } /* Literal.String.Char */
-.highlight .sd { color: #DD4422 } /* Literal.String.Doc */
-.highlight .s2 { background-color: #fff0f0 } /* Literal.String.Double */
-.highlight .se { color: #666666; font-weight: bold; background-color: #fff0f0 } /* \
Literal.String.Escape */
-.highlight .sh { background-color: #fff0f0 } /* Literal.String.Heredoc */
-.highlight .si { background-color: #eeeeee } /* Literal.String.Interpol */
-.highlight .sx { color: #DD2200; background-color: #fff0f0 } /* Literal.String.Other \
*/
-.highlight .sr { color: #000000; background-color: #fff0ff } /* Literal.String.Regex \
*/
-.highlight .s1 { background-color: #fff0f0 } /* Literal.String.Single */
-.highlight .ss { color: #AA6600 } /* Literal.String.Symbol */
-.highlight .bp { color: #007020 } /* Name.Builtin.Pseudo */
-.highlight .vc { color: #336699 } /* Name.Variable.Class */
-.highlight .vg { color: #dd7700; font-weight: bold } /* Name.Variable.Global */
-.highlight .vi { color: #3333BB } /* Name.Variable.Instance */
-.highlight .il { color: #0000DD; font-weight: bold } /* Literal.Number.Integer.Long \
*/
- </style>
- <script language="javascript">
- function getStyle(el,styleProp) {
- if (el.currentStyle)
- var y = el.currentStyle[styleProp];
- else if (window.getComputedStyle)
- var y = document.defaultView.getComputedStyle(el,null).getPropertyValue(styleProp);
- return y;
- }
- function toggle() {
- var el = this.expandable_content;
- var mark = this.expandable_marker;
- if (el.style.display == "block") {
- el.style.display = "none";
- mark.innerHTML = "[+]";
- } else {
- el.style.display = "block";
- mark.innerHTML = "[-]";
- }
- }
- function init_expandables() {
- var elts = document.getElementsByClassName("expandable");
- for (var i = 0; i < elts.length; i++) {
- var el = elts[i];
- var clickable = el.getElementsByTagName("span")[0];
- var marker = clickable.getElementsByClassName("marker")[0];
- var content = el.getElementsByClassName("content")[0];
- var width = clickable.clientWidth - parseInt(getStyle(content, \
"padding-left")) - parseInt(getStyle(content, "padding-right"));
- content.style.width = width + "px";
- clickable.expandable_content = content;
- clickable.expandable_marker = marker;
- clickable.onclick = toggle;
- }
- }
- function set_class_display(c, st) {
- var elements = document.querySelectorAll('.' + c),
- len = elements.length;
- for (i = 0; i < len; i++) {
- elements[i].style.display = st;
- }
- }
- function toggle_class_visibility(id) {
- var box = document.getElementById(id);
- set_class_display(id, box.checked ? '' : 'none');
- }
- </script>
- </head>
- <body onload="init_expandables()">
- <div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/utilities/queuemanager/tools/convert/convert2png.cpp </h1>
- </div>
- <div id="menu" dir="rtl">
- <p id="filename"><a href="index.html">Defects:</a> convert2png.cpp</p>
-<a href='21.html#line-62'> publicAllocationError 62</a>
- </div>
- <div id="content">
-<table class="highlighttable"><tr><td class="linenos"><div class="linenodiv"><pre> \
1
- 2
- 3
- 4
- 5
- 6
- 7
- 8
- 9
- 10
- 11
- 12
- 13
- 14
- 15
- 16
- 17
- 18
- 19
- 20
- 21
- 22
- 23
- 24
- 25
- 26
- 27
- 28
- 29
- 30
- 31
- 32
- 33
- 34
- 35
- 36
- 37
- 38
- 39
- 40
- 41
- 42
- 43
- 44
- 45
- 46
- 47
- 48
- 49
- 50
- 51
- 52
- 53
- 54
- 55
- 56
- 57
- 58
- 59
- 60
- 61
- 62
- 63
- 64
- 65
- 66
- 67
- 68
- 69
- 70
- 71
- 72
- 73
- 74
- 75
- 76
- 77
- 78
- 79
- 80
- 81
- 82
- 83
- 84
- 85
- 86
- 87
- 88
- 89
- 90
- 91
- 92
- 93
- 94
- 95
- 96
- 97
- 98
- 99
-100
-101
-102
-103
-104
-105
-106
-107
-108
-109
-110
-111
-112
-113
-114
-115
-116</pre></div></td><td class="code"><div class="highlight"><pre><span></span><a \
name="line-1"></a><span class="cm">/* \
============================================================</span>
-<a name="line-2"></a><span class="cm"> *</span>
-<a name="line-3"></a><span class="cm"> * This file is a part of digiKam \
project</span>
-<a name="line-4"></a><span class="cm"> * http://www.digikam.org</span>
-<a name="line-5"></a><span class="cm"> *</span>
-<a name="line-6"></a><span class="cm"> * Date : 2008-11-28</span>
-<a name="line-7"></a><span class="cm"> * Description : PNG image Converter batch \
tool.</span>
-<a name="line-8"></a><span class="cm"> *</span>
-<a name="line-9"></a><span class="cm"> * Copyright (C) 2008-2018 by Gilles Caulier \
<caulier dot gilles at gmail dot com></span>
-<a name="line-10"></a><span class="cm"> *</span>
-<a name="line-11"></a><span class="cm"> * This program is free software; you can \
redistribute it</span>
-<a name="line-12"></a><span class="cm"> * and/or modify it under the terms of the \
GNU General</span>
-<a name="line-13"></a><span class="cm"> * Public License as published by the Free \
Software Foundation;</span>
-<a name="line-14"></a><span class="cm"> * either version 2, or (at your \
option)</span>
-<a name="line-15"></a><span class="cm"> * any later version.</span>
-<a name="line-16"></a><span class="cm"> *</span>
-<a name="line-17"></a><span class="cm"> * This program is distributed in the hope \
that it will be useful,</span>
-<a name="line-18"></a><span class="cm"> * but WITHOUT ANY WARRANTY; without even the \
implied warranty of</span>
-<a name="line-19"></a><span class="cm"> * MERCHANTABILITY or FITNESS FOR A \
PARTICULAR PURPOSE. See the</span>
-<a name="line-20"></a><span class="cm"> * GNU General Public License for more \
details.</span>
-<a name="line-21"></a><span class="cm"> *</span>
-<a name="line-22"></a><span class="cm"> * \
============================================================ \
*/</span>
-<a name="line-23"></a>
-<a name="line-24"></a><span class="cp">#include</span> <span \
class="cpf">"convert2png.h"</span><span class="cp"></span>
-<a name="line-25"></a>
-<a name="line-26"></a><span class="c1">// Qt includes</span>
-<a name="line-27"></a>
-<a name="line-28"></a><span class="cp">#include</span> <span \
class="cpf"><QFileInfo></span><span class="cp"></span>
-<a name="line-29"></a><span class="cp">#include</span> <span \
class="cpf"><QWidget></span><span class="cp"></span>
-<a name="line-30"></a>
-<a name="line-31"></a><span class="c1">// KDE includes</span>
-<a name="line-32"></a>
-<a name="line-33"></a><span class="cp">#include</span> <span \
class="cpf"><kconfiggroup.h></span><span class="cp"></span>
-<a name="line-34"></a><span class="cp">#include</span> <span \
class="cpf"><klocalizedstring.h></span><span class="cp"></span>
-<a name="line-35"></a><span class="cp">#include</span> <span \
class="cpf"><ksharedconfig.h></span><span class="cp"></span>
-<a name="line-36"></a>
-<a name="line-37"></a><span class="c1">// Local includes</span>
-<a name="line-38"></a>
-<a name="line-39"></a><span class="cp">#include</span> <span \
class="cpf">"dimg.h"</span><span class="cp"></span>
-<a name="line-40"></a><span class="cp">#include</span> <span \
class="cpf">"pngsettings.h"</span><span class="cp"></span>
-<a name="line-41"></a>
-<a name="line-42"></a><span class="k">namespace</span> <span \
class="n">Digikam</span>
-<a name="line-43"></a><span class="p">{</span>
-<a name="line-44"></a>
-<a name="line-45"></a><span class="n">Convert2PNG</span><span \
class="o">::</span><span class="n">Convert2PNG</span><span class="p">(</span><span \
class="n">QObject</span><span class="o">*</span> <span class="k">const</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-46"></a> <span class="o">:</span> <span \
class="n">BatchTool</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Convert2PNG"</span><span class="p">),</span> <span \
class="n">ConvertTool</span><span class="p">,</span> <span \
class="n">parent</span><span class="p">)</span>
-<a name="line-47"></a><span class="p">{</span>
-<a name="line-48"></a> <span class="n">m_settings</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span>
-<a name="line-49"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-50"></a>
-<a name="line-51"></a> <span class="n">setToolTitle</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert To PNG"</span><span class="p">));</span>
-<a name="line-52"></a> <span class="n">setToolDescription</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
class="s">"Convert images to PNG format."</span><span \
class="p">));</span>
-<a name="line-53"></a> <span class="n">setToolIconName</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"image-png"</span><span class="p">));</span>
-<a name="line-54"></a><span class="p">}</span>
-<a name="line-55"></a>
-<a name="line-56"></a><span class="n">Convert2PNG</span><span \
class="o">::~</span><span class="n">Convert2PNG</span><span \
class="p">()</span>
-<a name="line-57"></a><span class="p">{</span>
-<a name="line-58"></a><span class="p">}</span>
-<a name="line-59"></a>
-<a name="line-60"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">registerSettingsWidget</span><span class="p">()</span>
-<a name="line-61"></a><span class="p">{</span>
-<a name="line-62"></a><span class="hll"> <span class="n">m_settings</span> \
<span class="o">=</span> <span class="k">new</span> <span \
class="n">PNGSettings</span><span class="p">();</span><span class='error2'><--- \
Possible leak in public function. The pointer 'm_settings' is not deallocated before \
it is allocated.</span>
-</span><a name="line-63"></a> <span class="n">m_settingsWidget</span> <span \
class="o">=</span> <span class="n">m_settings</span><span \
class="p">;</span>
-<a name="line-64"></a>
-<a name="line-65"></a> <span class="n">connect</span><span \
class="p">(</span><span class="n">m_settings</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">signalSettingsChanged</span><span class="p">()),</span>
-<a name="line-66"></a> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">slotSettingsChanged</span><span class="p">()));</span>
-<a name="line-67"></a>
-<a name="line-68"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">registerSettingsWidget</span><span \
class="p">();</span>
-<a name="line-69"></a><span class="p">}</span>
-<a name="line-70"></a>
-<a name="line-71"></a><span class="n">BatchToolSettings</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">defaultSettings</span><span class="p">()</span>
-<a name="line-72"></a><span class="p">{</span>
-<a name="line-73"></a> <span class="n">KSharedConfig</span><span \
class="o">::</span><span class="n">Ptr</span> <span class="n">config</span> <span \
class="o">=</span> <span class="n">KSharedConfig</span><span class="o">::</span><span \
class="n">openConfig</span><span class="p">();</span>
-<a name="line-74"></a> <span class="n">KConfigGroup</span> <span \
class="n">group</span> <span class="o">=</span> <span \
class="n">config</span><span class="o">-></span><span class="n">group</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"ImageViewer Settings"</span><span \
class="p">));</span>
-<a name="line-75"></a> <span class="kt">int</span> <span \
class="n">compression</span> <span class="o">=</span> <span \
class="n">group</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"PNGCompression"</span><span class="p">),</span> <span \
class="mi">9</span><span class="p">);</span>
-<a name="line-76"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-77"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">compression</span><span class="p">);</span>
-<a name="line-78"></a> <span class="k">return</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-79"></a><span class="p">}</span>
-<a name="line-80"></a>
-<a name="line-81"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">slotAssignSettings2Widget</span><span class="p">()</span>
-<a name="line-82"></a><span class="p">{</span>
-<a name="line-83"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">false</span><span \
class="p">;</span>
-<a name="line-84"></a> <span class="n">m_settings</span><span \
class="o">-></span><span class="n">setCompressionValue</span><span \
class="p">(</span><span class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-85"></a> <span class="n">m_changeSettings</span> <span \
class="o">=</span> <span class="nb">true</span><span \
class="p">;</span>
-<a name="line-86"></a><span class="p">}</span>
-<a name="line-87"></a>
-<a name="line-88"></a><span class="kt">void</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">slotSettingsChanged</span><span class="p">()</span>
-<a name="line-89"></a><span class="p">{</span>
-<a name="line-90"></a> <span class="k">if</span> <span class="p">(</span><span \
class="n">m_changeSettings</span><span class="p">)</span>
-<a name="line-91"></a> <span class="p">{</span>
-<a name="line-92"></a> <span class="n">BatchToolSettings</span> <span \
class="n">settings</span><span class="p">;</span>
-<a name="line-93"></a> <span class="n">settings</span><span \
class="p">.</span><span class="n">insert</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">),</span> <span \
class="n">m_settings</span><span class="o">-></span><span \
class="n">getCompressionValue</span><span class="p">());</span>
-<a name="line-94"></a> <span class="n">BatchTool</span><span \
class="o">::</span><span class="n">slotSettingsChanged</span><span \
class="p">(</span><span class="n">settings</span><span \
class="p">);</span>
-<a name="line-95"></a> <span class="p">}</span>
-<a name="line-96"></a><span class="p">}</span>
-<a name="line-97"></a>
-<a name="line-98"></a><span class="n">QString</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">outputSuffix</span><span class="p">()</span> <span \
class="k">const</span>
-<a name="line-99"></a><span class="p">{</span>
-<a name="line-100"></a> <span class="k">return</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"png"</span><span class="p">);</span>
-<a name="line-101"></a><span class="p">}</span>
-<a name="line-102"></a>
-<a name="line-103"></a><span class="kt">bool</span> <span \
class="n">Convert2PNG</span><span class="o">::</span><span \
class="n">toolOperations</span><span class="p">()</span>
-<a name="line-104"></a><span class="p">{</span>
-<a name="line-105"></a> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">loadToDImg</span><span \
class="p">())</span>
-<a name="line-106"></a> <span class="p">{</span>
-<a name="line-107"></a> <span class="k">return</span> <span \
class="nb">false</span><span class="p">;</span>
-<a name="line-108"></a> <span class="p">}</span>
-<a name="line-109"></a>
-<a name="line-110"></a> <span class="kt">int</span> <span \
class="n">PNGCompression</span> <span class="o">=</span> <span \
class="n">PNGSettings</span><span class="o">::</span><span \
class="n">convertCompressionForLibPng</span><span class="p">(</span><span \
class="n">settings</span><span class="p">()[</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"Quality"</span><span class="p">)].</span><span \
class="n">toInt</span><span class="p">());</span>
-<a name="line-111"></a> <span class="n">image</span><span \
class="p">().</span><span class="n">setAttribute</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"quality"</span><span class="p">),</span> <span \
class="n">PNGCompression</span><span class="p">);</span>
-<a name="line-112"></a>
-<a name="line-113"></a> <span class="k">return</span> <span \
class="p">(</span><span class="n">savefromDImg</span><span \
class="p">());</span>
-<a name="line-114"></a><span class="p">}</span>
-<a name="line-115"></a>
-<a name="line-116"></a><span class="p">}</span> <span class="c1">// namespace \
Digikam</span>
-</pre></div>
-</td></tr></table>
- </div>
- <div id="footer">
- <p>
- Cppcheck 1.77 - a tool for static C/C++ code analysis</br>
- </br>
- Internet: <a href="http://cppcheck.net">http://cppcheck.net</a></br>
- IRC: <a href="irc://irc.freenode.net/cppcheck">irc://irc.freenode.net/cppcheck</a></br>
- <p>
- </div>
- </body>
-</html>
diff --git a/static/reports/cppcheck/master/3.html \
b/static/reports/cppcheck/master/3.html index ba2e225e..883fd891 100644
--- a/static/reports/cppcheck/master/3.html
+++ b/static/reports/cppcheck/master/3.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/engine/dbenginebackend.h </h1> + <h1>Cppcheck report \
- digiKam-master-rev-0ca8051b21: ../../core/libs/database/engine/dbenginebackend.h \
</h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> dbenginebackend.h</p>
diff --git a/static/reports/cppcheck/master/4.html \
b/static/reports/cppcheck/master/4.html index cba2029d..b7899f14 100644
--- a/static/reports/cppcheck/master/4.html
+++ b/static/reports/cppcheck/master/4.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/imagehistory/imagehistorygraph_boost.h </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/libs/database/imagehistory/imagehistorygraph_boost.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> \
imagehistorygraph_boost.h</p>
diff --git a/static/reports/cppcheck/master/5.html \
b/static/reports/cppcheck/master/5.html index 8830b7f1..4adb936e 100644
--- a/static/reports/cppcheck/master/5.html
+++ b/static/reports/cppcheck/master/5.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/imagehistory/imagehistorygraphdata.h </h1> + \
<h1>Cppcheck report - digiKam-master-rev-0ca8051b21: \
../../core/libs/database/imagehistory/imagehistorygraphdata.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> \
imagehistorygraphdata.h</p>
diff --git a/static/reports/cppcheck/master/6.html \
b/static/reports/cppcheck/master/6.html index 7d914a99..466a4262 100644
--- a/static/reports/cppcheck/master/6.html
+++ b/static/reports/cppcheck/master/6.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/item/imageinfolist.h </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/database/item/imageinfolist.h </h1> \
</div> <div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> imageinfolist.h</p>
diff --git a/static/reports/cppcheck/master/7.html \
b/static/reports/cppcheck/master/7.html index a2a2a0a3..056d8db8 100644
--- a/static/reports/cppcheck/master/7.html
+++ b/static/reports/cppcheck/master/7.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/database/item/imagecopyright.cpp </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/database/item/imagecopyright.cpp </h1> \
</div> <div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> imagecopyright.cpp</p>
diff --git a/static/reports/cppcheck/master/8.html \
b/static/reports/cppcheck/master/8.html index 750adbf3..66e1c622 100644
--- a/static/reports/cppcheck/master/8.html
+++ b/static/reports/cppcheck/master/8.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/dimg/dshareddata.h </h1> + <h1>Cppcheck report - \
digiKam-master-rev-0ca8051b21: ../../core/libs/dimg/dshareddata.h </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> dshareddata.h</p>
diff --git a/static/reports/cppcheck/master/9.html \
b/static/reports/cppcheck/master/9.html index 1f387934..530699ee 100644
--- a/static/reports/cppcheck/master/9.html
+++ b/static/reports/cppcheck/master/9.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
.highlight .hll { background-color: #ffffcc }
@@ -120,7 +120,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: \
../../core/libs/imageproperties/disjointmetadata.cpp </h1> + <h1>Cppcheck \
report - digiKam-master-rev-0ca8051b21: \
../../core/libs/imageproperties/disjointmetadata.cpp </h1> </div>
<div id="menu" dir="rtl">
<p id="filename"><a href="index.html">Defects:</a> disjointmetadata.cpp</p>
diff --git a/static/reports/cppcheck/master/index.html \
b/static/reports/cppcheck/master/index.html index def8128f..f69f7f01 100644
--- a/static/reports/cppcheck/master/index.html
+++ b/static/reports/cppcheck/master/index.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
@@ -56,11 +56,11 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: </h1>
+ <h1>Cppcheck report - digiKam-master-rev-0ca8051b21: </h1>
</div>
<div id="menu_index">
<p id="filename"><a href="index.html">Defect summary;</a> </p>
- <table> <tr><th>Show</th><th>#</th><th>Defect ID</th></tr> \
<tr><td><input type='checkbox' onclick='toggle_class_visibility(this.id)' \
id='noExplicitConstructor' name='noExplicitConstructor' \
checked></td><td>19</td><td>noExplicitConstructor</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='publicAllocationError' \
name='publicAllocationError' \
checked></td><td>6</td><td>publicAllocationError</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='operatorEqToSelf' \
name='operatorEqToSelf' checked></td><td>4</td><td>operatorEqToSelf</td></tr> \
<tr><td><input type='checkbox' onclick='toggle_class_visibility(this.id)' \
id='unmatchedSuppression' name='unmatchedSuppression' \
checked></td><td>3</td><td>unmatchedSuppression</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' \
id='copyCtorPointerCopying' name='copyCtorPointerCopying' \
checked></td><td>1</td><td>copyCtorPointerCopying</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='operatorEqVarError' \
name='operatorEqVarError' checked></td><td>1</td><td>operatorEqVarError</td></tr> \
<tr><td></td><td>34</td><td>total</td></tr> </table> <a \
href="stats.html">Statistics</a></p> + <table> \
<tr><th>Show</th><th>#</th><th>Defect ID</th></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='noExplicitConstructor' \
name='noExplicitConstructor' \
checked></td><td>19</td><td>noExplicitConstructor</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='operatorEqToSelf' \
name='operatorEqToSelf' checked></td><td>4</td><td>operatorEqToSelf</td></tr> \
<tr><td><input type='checkbox' onclick='toggle_class_visibility(this.id)' \
id='publicAllocationError' name='publicAllocationError' \
checked></td><td>4</td><td>publicAllocationError</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='unmatchedSuppression' \
name='unmatchedSuppression' checked></td><td>3</td><td>unmatchedSuppression</td></tr> \
<tr><td><input type='checkbox' onclick='toggle_class_visibility(this.id)' \
id='copyCtorPointerCopying' name='copyCtorPointerCopying' \
checked></td><td>1</td><td>copyCtorPointerCopying</td></tr> <tr><td><input \
type='checkbox' onclick='toggle_class_visibility(this.id)' id='operatorEqVarError' \
name='operatorEqVarError' checked></td><td>1</td><td>operatorEqVarError</td></tr> \
<tr><td></td><td>32</td><td>total</td></tr> </table> <a \
href="stats.html">Statistics</a></p> </div>
<div id="content_index">
<table>
@@ -110,18 +110,14 @@
<tr><td colspan='4'><a \
href='15.html'>../../core/utilities/facemanagement/facepipeline.h</a></td></tr> <tr \
class="noExplicitConstructor"><td><a \
href="15.html#line-73">73</a></td><td>noExplicitConstructor</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>style</td><td \
>Class 'FacePipelineFaceTagsIface' has a constructor with 1 argument that is not \
> explicit.</td></tr>
<tr class="noExplicitConstructor"><td><a \
href="15.html#line-89">89</a></td><td>noExplicitConstructor</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>style</td><td \
>Class 'FacePipelineFaceTagsIfaceList' has a constructor with 1 argument that is not \
> explicit.</td></tr>
- <tr><td colspan='4'><a \
href='16.html'>../../core/utilities/queuemanager/tools/convert/convert2dng.cpp</a></td></tr>
- <tr class="publicAllocationError"><td><a \
href="16.html#line-55">55</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
- <tr><td colspan='4'><a \
href='17.html'>../../core/utilities/queuemanager/tools/convert/convert2jp2.cpp</a></td></tr>
+ <tr><td colspan='4'><a \
href='16.html'>../../core/utilities/queuemanager/tools/convert/convert2jpeg.cpp</a></td></tr>
+ <tr class="publicAllocationError"><td><a \
href="16.html#line-62">62</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
+ <tr><td colspan='4'><a \
href='17.html'>../../core/utilities/queuemanager/tools/convert/convert2pgf.cpp</a></td></tr>
<tr class="publicAllocationError"><td><a \
href="17.html#line-62">62</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
- <tr><td colspan='4'><a \
href='18.html'>../../core/utilities/queuemanager/tools/convert/convert2jpeg.cpp</a></td></tr>
+ <tr><td colspan='4'><a \
href='18.html'>../../core/utilities/queuemanager/tools/convert/convert2png.cpp</a></td></tr>
<tr class="publicAllocationError"><td><a \
href="18.html#line-62">62</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
- <tr><td colspan='4'><a \
href='19.html'>../../core/utilities/queuemanager/tools/convert/convert2pgf.cpp</a></td></tr>
- <tr class="publicAllocationError"><td><a \
href="19.html#line-62">62</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
- <tr><td colspan='4'><a \
href='21.html'>../../core/utilities/queuemanager/tools/convert/convert2png.cpp</a></td></tr>
- <tr class="publicAllocationError"><td><a \
href="21.html#line-62">62</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
- <tr><td colspan='4'><a \
href='20.html'>../../core/utilities/queuemanager/tools/convert/convert2tiff.cpp</a></td></tr>
- <tr class="publicAllocationError"><td><a \
href="20.html#line-61">61</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
+ <tr><td colspan='4'><a \
href='19.html'>../../core/utilities/queuemanager/tools/convert/convert2tiff.cpp</a></td></tr>
+ <tr class="publicAllocationError"><td><a \
href="19.html#line-61">61</a></td><td>publicAllocationError</td><td><a \
href='https://cwe.mitre.org/data/definitions/398.html'>398</a></td><td>warning</td><td \
>Possible leak in public function. The pointer 'm_settings' is not deallocated before \
> it is allocated.</td></tr>
</table>
</div>
<div id="footer">
diff --git a/static/reports/cppcheck/master/stats.html \
b/static/reports/cppcheck/master/stats.html index c67f6b13..29b98dd6 100644
--- a/static/reports/cppcheck/master/stats.html
+++ b/static/reports/cppcheck/master/stats.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
- <title>Cppcheck - HTML report - digiKam-master-rev-b562c7d550</title>
+ <title>Cppcheck - HTML report - digiKam-master-rev-0ca8051b21</title>
<link rel="stylesheet" href="style.css">
<style>
@@ -56,7 +56,7 @@
</head>
<body onload="init_expandables()">
<div id="header">
- <h1>Cppcheck report - digiKam-master-rev-b562c7d550: Statistics </h1>
+ <h1>Cppcheck report - digiKam-master-rev-0ca8051b21: Statistics </h1>
</div>
<div id="menu_index">
<p id="filename"><a href="index.html">Back to summary</a> </p>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic