From kde-commits Sun Sep 02 20:41:05 2018 From: Luigi Toscano Date: Sun, 02 Sep 2018 20:41:05 +0000 To: kde-commits Subject: [juk/Applications/18.08] /: Set the tick interval, because the default value is 0 Message-Id: X-MARC-Message: https://marc.info/?l=kde-commits&m=153592087718455 Git commit 665a629e914d5d08bcf0dacd553fa4a382c798f2 by Luigi Toscano. Committed on 02/09/2018 at 20:41. Pushed by ltoscano into branch 'Applications/18.08'. Set the tick interval, because the default value is 0 Summary: With this change the time is correctly updated also when using the VLC backend. It worked for some reason with phonon-gstreamer, but it looks like it's just by accident. In fact, according the documentation, the default value of the property is 0: https://api.kde.org/phonon/html/classPhonon_1_1MediaObject.html#ae0f0ab91c9= 7a1f3495ed9467048bb81a The choosen value (100) should allow for a fluid scrolling of the progress element, without having a too small resolution, and it seems to match the resolution of the gstreamer backend anyway. BUG: 389907 Test Plan: The time is updated on both the progress bar and the status bar with both VLC and GStreamer Phonon backends. Reviewers: mpyne Reviewed By: mpyne Differential Revision: https://phabricator.kde.org/D15222 M +2 -0 playermanager.cpp https://commits.kde.org/juk/665a629e914d5d08bcf0dacd553fa4a382c798f2 diff --git a/playermanager.cpp b/playermanager.cpp index c4ab876..822b05e 100644 --- a/playermanager.cpp +++ b/playermanager.cpp @@ -523,6 +523,8 @@ void PlayerManager::setup() connect(m_media, &MediaObject::finished, this, &PlayerManager::slotFin= ished); connect(m_media, &MediaObject::seekableChanged, this, &PlayerManager::= slotSeekableChanged); = + m_media->setTickInterval(100); + // initialize action states = action("pause")->setEnabled(false);