[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [knights] src: [clang-tidy] use '= default' to define a trivial destructor [modernize-use-default].
From:       Alexander Semke <null () kde ! org>
Date:       2018-09-02 10:06:46
Message-ID: E1fwPHK-0007d5-KV () code ! kde ! org
[Download RAW message or body]

Git commit 3662cf4ee860e11cb2d52031746406899353042e by Alexander Semke.
Committed on 02/09/2018 at 10:06.
Pushed by asemke into branch 'master'.

[clang-tidy] use '= default' to define a trivial destructor [modernize-use-default].

M  +2    -6    src/core/move.cpp
M  +1    -3    src/core/piece.cpp
M  +1    -3    src/core/pos.cpp
M  +1    -3    src/externalcontrol.cpp
M  +1    -3    src/proto/computerprotocol.cpp
M  +1    -3    src/proto/ficsprotocol.cpp
M  +1    -3    src/proto/localprotocol.cpp
M  +1    -3    src/proto/seekgraph.cpp
M  +1    -3    src/proto/textprotocol.cpp
M  +1    -3    src/rules/chessrules.cpp
M  +1    -2    src/rules/rules.h

https://commits.kde.org/knights/3662cf4ee860e11cb2d52031746406899353042e

diff --git a/src/core/move.cpp b/src/core/move.cpp
index 3e57920..e5f78e5 100644
--- a/src/core/move.cpp
+++ b/src/core/move.cpp
@@ -104,13 +104,9 @@ Move::Move(QString string) : d(new MovePrivate) {
 	setString(string);
 }
 
-Move::Move(const Move& other) : d(other.d) {
+Move::Move(const Move& other) = default;
 
-}
-
-Move::~Move() {
-
-}
+Move::~Move() = default;
 
 void Move::operator=(const Move& other) {
 	d = other.d;
diff --git a/src/core/piece.cpp b/src/core/piece.cpp
index 869bff1..a3299d8 100644
--- a/src/core/piece.cpp
+++ b/src/core/piece.cpp
@@ -105,9 +105,7 @@ Piece::Piece ( KGameRenderer* renderer, PieceType type, Color \
color, QGraphicsSc  }
 
 
-Piece::~Piece() {
-
-}
+Piece::~Piece() = default;
 
 Color oppositeColor ( Color color ) {
 	switch ( color ) {
diff --git a/src/core/pos.cpp b/src/core/pos.cpp
index bc0c46a..86ae6b0 100644
--- a/src/core/pos.cpp
+++ b/src/core/pos.cpp
@@ -54,9 +54,7 @@ Pos::Pos ( const QString string ) {
 	}
 }
 
-Pos::~Pos() {
-
-}
+Pos::~Pos() = default;
 
 QString Pos::string() const {
 	if ( isValid() )
diff --git a/src/externalcontrol.cpp b/src/externalcontrol.cpp
index 50a80d0..9811c69 100644
--- a/src/externalcontrol.cpp
+++ b/src/externalcontrol.cpp
@@ -35,9 +35,7 @@ ExternalControl::ExternalControl(QObject* parent) : QObject(parent) \
{  qCDebug(LOG_KNIGHTS) << \
QDBusConnection::sessionBus().registerService(QLatin1String("org.kde.Knights"));  }
 
-ExternalControl::~ExternalControl() {
-
-}
+ExternalControl::~ExternalControl() = default;
 
 FORWARD_FUNCTION(adjourn,Adjourn)
 FORWARD_FUNCTION(abort,Abort)
diff --git a/src/proto/computerprotocol.cpp b/src/proto/computerprotocol.cpp
index ed39dac..0912c8f 100644
--- a/src/proto/computerprotocol.cpp
+++ b/src/proto/computerprotocol.cpp
@@ -31,9 +31,7 @@ ComputerProtocol::ComputerProtocol(QObject* parent): \
TextProtocol(parent) {  
 }
 
-ComputerProtocol::~ComputerProtocol() {
-
-}
+ComputerProtocol::~ComputerProtocol() = default;
 
 void ComputerProtocol::startProgram() {
 	QStringList args = attribute("program").toString().split ( QLatin1Char ( ' ' ) );
diff --git a/src/proto/ficsprotocol.cpp b/src/proto/ficsprotocol.cpp
index 8a52aa2..3de229c 100644
--- a/src/proto/ficsprotocol.cpp
+++ b/src/proto/ficsprotocol.cpp
@@ -103,9 +103,7 @@ FicsProtocol::FicsProtocol ( QObject* parent ) : TextProtocol ( \
parent ),  }
 }
 
-FicsProtocol::~FicsProtocol() {
-
-}
+FicsProtocol::~FicsProtocol() = default;
 
 Protocol::Features FicsProtocol::supportedFeatures() {
 	return TimeLimit | SetTimeLimit | UpdateTime | Pause | Adjourn | Resign | Abort;
diff --git a/src/proto/localprotocol.cpp b/src/proto/localprotocol.cpp
index b26d3f2..45a0657 100644
--- a/src/proto/localprotocol.cpp
+++ b/src/proto/localprotocol.cpp
@@ -48,9 +48,7 @@ void LocalProtocol::move ( const Move& m ) {
 LocalProtocol::LocalProtocol ( QObject* parent ) : Protocol ( parent ) {
 }
 
-LocalProtocol::~LocalProtocol() {
-
-}
+LocalProtocol::~LocalProtocol() = default;
 
 bool LocalProtocol::isLocal() {
 	return true;
diff --git a/src/proto/seekgraph.cpp b/src/proto/seekgraph.cpp
index 59d867c..ad96fdf 100644
--- a/src/proto/seekgraph.cpp
+++ b/src/proto/seekgraph.cpp
@@ -42,9 +42,7 @@ SeekGraph::SeekGraph ( QWidget* parent ) : KPlotWidget ( parent ) {
 	setMouseTracking(true);
 }
 
-SeekGraph::~SeekGraph() {
-
-}
+SeekGraph::~SeekGraph() = default;
 
 void SeekGraph::paintEvent ( QPaintEvent* event ) {
 	QFrame::paintEvent( event );
diff --git a/src/proto/textprotocol.cpp b/src/proto/textprotocol.cpp
index fb4a6a2..6aa1108 100644
--- a/src/proto/textprotocol.cpp
+++ b/src/proto/textprotocol.cpp
@@ -35,9 +35,7 @@ TextProtocol::TextProtocol(QObject* parent): Protocol(parent), \
m_console(nullptr  
 }
 
-TextProtocol::~TextProtocol() {
-
-}
+TextProtocol::~TextProtocol() = default;
 
 void TextProtocol::readFromDevice() {
 	while ( !stream.atEnd() ) {
diff --git a/src/rules/chessrules.cpp b/src/rules/chessrules.cpp
index 774a248..14f5350 100644
--- a/src/rules/chessrules.cpp
+++ b/src/rules/chessrules.cpp
@@ -215,9 +215,7 @@ QList<Move> ChessRules::legalAttackMoves ( const Pos& pos, Grid* \
grid ) {  return moves;
 }
 
-ChessRules::~ChessRules() {
-
-}
+ChessRules::~ChessRules() = default;
 
 Rules::Directions ChessRules::legalDirections ( PieceType type ) {
 	switch ( type ) {
diff --git a/src/rules/rules.h b/src/rules/rules.h
index cb97e38..3b17a35 100644
--- a/src/rules/rules.h
+++ b/src/rules/rules.h
@@ -52,8 +52,7 @@ public:
 
 	typedef QFlags<Direction> Directions;
 
-	virtual ~Rules() {
-	}
+	virtual ~Rules() = default;
 
 	virtual void setGrid ( Grid* grid ) {
 		qCDebug(LOG_KNIGHTS) << "Setting Grid";


[prev in list] [next in list] [prev in thread] [next in thread]