[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kexi/3.1] src/migration/mdb/3rdparty/mdbtools/libmdb: At least for me IS NULL and IS NOT NULL are t
From:       Jaroslaw Staniek <null () kde ! org>
Date:       2018-08-30 21:19:24
Message-ID: E1fvULc-0003tX-V3 () code ! kde ! org
[Download RAW message or body]

Git commit 437231a67574a8ca8bd82cd3039bea99d0dbf979 by Jaroslaw Staniek, on behalf of \
Brian Bruns. Committed on 30/08/2018 at 21:01.
Pushed by staniek into branch '3.1'.

At least for me IS NULL and IS NOT NULL are the wrong way round in SQL, fixed it.

FIXED-IN:3.1.1
mdbtools 2355aec912724a2

M  +4    -7    src/migration/mdb/3rdparty/mdbtools/libmdb/sargs.c

https://commits.kde.org/kexi/437231a67574a8ca8bd82cd3039bea99d0dbf979

diff --git a/src/migration/mdb/3rdparty/mdbtools/libmdb/sargs.c \
b/src/migration/mdb/3rdparty/mdbtools/libmdb/sargs.c index f9d90510a..33694083c \
                100644
--- a/src/migration/mdb/3rdparty/mdbtools/libmdb/sargs.c
+++ b/src/migration/mdb/3rdparty/mdbtools/libmdb/sargs.c
@@ -175,13 +175,10 @@ mdb_test_sarg(MdbHandle *mdb, MdbColumn *col, MdbSargNode \
*node, MdbField *field  {
 	char tmpbuf[256];
 
-	if (node->op == MDB_ISNULL) {
-		if (field->is_null) return 0;
-		else return 1;
-	} else if (node->op == MDB_NOTNULL) {
-		if (field->is_null) return 1;
-		else return 0;
-	}
+	if (node->op == MDB_ISNULL)
+		return field->is_null?1:0;
+	else if (node->op == MDB_NOTNULL)
+		return field->is_null?0:1;
 	switch (col->col_type) {
 		case MDB_BOOL:
 			return mdb_test_int(node, !field->is_null);


[prev in list] [next in list] [prev in thread] [next in thread]