[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kmailtransport/Applications/18.08] src/kmailtransport/plugins/smtp: Disable password lineedit when 
From:       Laurent Montel <null () kde ! org>
Date:       2018-08-30 11:50:10
Message-ID: E1fvLSk-0000t5-GO () code ! kde ! org
[Download RAW message or body]

Git commit 325d0e03480ee756713eccdcffe19a09c44daff2 by Laurent Montel.
Committed on 30/08/2018 at 11:49.
Pushed by mlaurent into branch 'Applications/18.08'.

Disable password lineedit when we don't store password

CCBUG: 398036

M  +14   -1    src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp
M  +1    -0    src/kmailtransport/plugins/smtp/smtpconfigwidget.h

https://commits.kde.org/kmailtransport/325d0e03480ee756713eccdcffe19a09c44daff2

diff --git a/src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp \
b/src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp index 0a2b288..fe3518e 100644
--- a/src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp
+++ b/src/kmailtransport/plugins/smtp/smtpconfigwidget.cpp
@@ -76,6 +76,11 @@ public:
         updateAuthCapbilities();
     }
 
+    void enablePasswordLine()
+    {
+        ui.password->setEnabled(ui.kcfg_storePassword->isChecked());
+    }
+
     void updateAuthCapbilities()
     {
         if (serverTestFailed) {
@@ -115,6 +120,7 @@ public:
             ui.kcfg_requiresAuthentication->setVisible(true);
             ui.authCombo->setEnabled(true);
             ui.authLabel->setEnabled(true);
+            enablePasswordLine();
         }
     }
 };
@@ -176,7 +182,7 @@ void SMTPConfigWidget::init()
     connect(d->ui.kcfg_host, &QLineEdit::textChanged, this, \
                &SMTPConfigWidget::hostNameChanged);
     connect(d->encryptionGroup, QOverload<int>::of(&QButtonGroup::buttonClicked), \
                this, &SMTPConfigWidget::encryptionChanged);
     connect(d->ui.kcfg_requiresAuthentication, &QCheckBox::toggled, this, \
                &SMTPConfigWidget::ensureValidAuthSelection);
-
+    connect(d->ui.kcfg_storePassword, &QCheckBox::toggled, this, \
&SMTPConfigWidget::enablePasswordLine);  if (!d->transport->isValid()) {
         checkHighestEnabledButton(d->encryptionGroup);
     }
@@ -194,6 +200,12 @@ void SMTPConfigWidget::init()
     hostNameChanged(d->transport->host());
 }
 
+void SMTPConfigWidget::enablePasswordLine()
+{
+    Q_D(SMTPConfigWidget);
+    d->enablePasswordLine();
+}
+
 void SMTPConfigWidget::checkSmtpCapabilities()
 {
     Q_D(SMTPConfigWidget);
@@ -334,6 +346,7 @@ void SMTPConfigWidget::ensureValidAuthSelection()
 
     // adjust available authentication methods
     d->updateAuthCapbilities();
+    d->enablePasswordLine();
 }
 
 void SMTPConfigWidget::encryptionChanged(int enc)
diff --git a/src/kmailtransport/plugins/smtp/smtpconfigwidget.h \
b/src/kmailtransport/plugins/smtp/smtpconfigwidget.h index cba5f8e..cc037ef 100644
--- a/src/kmailtransport/plugins/smtp/smtpconfigwidget.h
+++ b/src/kmailtransport/plugins/smtp/smtpconfigwidget.h
@@ -62,6 +62,7 @@ private:
     Q_DECLARE_PRIVATE(SMTPConfigWidget)
 
     void init();
+    void enablePasswordLine();
 };
 } // namespace MailTransport
 


[prev in list] [next in list] [prev in thread] [next in thread]