[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevelop/5.3] plugins/custom-definesandincludes/kcm_widget: Do not reimplement QStringList::contain
From:       Friedrich W. H. Kossebau <null () kde ! org>
Date:       2018-08-15 16:03:01
Message-ID: E1fpyGD-0006PT-5M () code ! kde ! org
[Download RAW message or body]

Git commit 923da8209d7bab3de6b38d76cd09b16e118af694 by Friedrich W. H. Kossebau.
Committed on 15/08/2018 at 16:01.
Pushed by kossebau into branch '5.3'.

Do not reimplement QStringList::contains

M  +2    -4    plugins/custom-definesandincludes/kcm_widget/includesmodel.cpp

https://commits.kde.org/kdevelop/923da8209d7bab3de6b38d76cd09b16e118af694

diff --git a/plugins/custom-definesandincludes/kcm_widget/includesmodel.cpp \
b/plugins/custom-definesandincludes/kcm_widget/includesmodel.cpp index \
                cb8e3e333c..901edaa840 100644
--- a/plugins/custom-definesandincludes/kcm_widget/includesmodel.cpp
+++ b/plugins/custom-definesandincludes/kcm_widget/includesmodel.cpp
@@ -110,10 +110,8 @@ void IncludesModel::addIncludeInternal( const QString& \
includePath )  }
 
     // Do not allow duplicates
-    foreach( const QString &include, m_includes ) {
-        if( include == includePath ) {
-            return;
-        }
+    if (m_includes.contains(includePath)) {
+        return;
     }
 
     m_includes << includePath;


[prev in list] [next in list] [prev in thread] [next in thread]