[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [syntax-highlighting] src/lib: Fix compiler warning -Wimplicit-fallthrough
From:       Dominik Haumann <null () kde ! org>
Date:       2018-07-31 19:30:31
Message-ID: E1fkaLn-0006aZ-7R () code ! kde ! org
[Download RAW message or body]

Git commit 7312f52e2753bb5712404b62ffaae52021171097 by Dominik Haumann.
Committed on 31/07/2018 at 19:30.
Pushed by dhaumann into branch 'master'.

Fix compiler warning -Wimplicit-fallthrough

Summary:
syntax-highlighting/src/lib/definition.cpp: In member function ‘void \
KSyntaxHighlighting::DefinitionData::loadGeneral(QXmlStreamReader&)': \
syntax-highlighting/src/lib/definition.cpp:523:17: warning: this statement may fall \
through [-Wimplicit-fallthrough=]  if (elementRefCounter == 0)
                 ^~
syntax-highlighting/src/lib/definition.cpp:525:13: note: here
             default:
             ^~~~~~~
syntax-highlighting/src/lib/definition.cpp: In member function ‘void \
KSyntaxHighlighting::DefinitionData::loadFoldingIgnoreList(QXmlStreamReader&)': \
syntax-highlighting/src/lib/definition.cpp:552:17: warning: this statement may fall \
through [-Wimplicit-fallthrough=]  if (elementRefCounter == 0)
                 ^~
syntax-highlighting/src/lib/definition.cpp:554:13: note: here
             default:
             ^~~~~~~

Test Plan: make && make test

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D14524

M  +4    -0    src/lib/definition.cpp

https://commits.kde.org/syntax-highlighting/7312f52e2753bb5712404b62ffaae52021171097

diff --git a/src/lib/definition.cpp b/src/lib/definition.cpp
index fa6f299..3228980 100644
--- a/src/lib/definition.cpp
+++ b/src/lib/definition.cpp
@@ -516,6 +516,8 @@ void DefinitionData::loadGeneral(QXmlStreamReader& reader)
                 --elementRefCounter;
                 if (elementRefCounter == 0)
                     return;
+                reader.readNext();
+                break;
             default:
                 reader.readNext();
                 break;
@@ -545,6 +547,8 @@ void DefinitionData::loadFoldingIgnoreList(QXmlStreamReader& \
                reader)
                 --elementRefCounter;
                 if (elementRefCounter == 0)
                     return;
+                reader.readNext();
+                break;
             default:
                 reader.readNext();
                 break;


[prev in list] [next in list] [prev in thread] [next in thread]