[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kexi/3.1] src/widget/tableview: Zero values are not displayed in integer columns
From:       Jaroslaw Staniek <null () kde ! org>
Date:       2018-06-15 21:09:32
Message-ID: E1fTvyO-0004ph-A0 () code ! kde ! org
[Download RAW message or body]

Git commit 941cdfa753b09303cbd45f5de8db55f6e8387fd8 by Jaroslaw Staniek.
Committed on 15/06/2018 at 21:09.
Pushed by staniek into branch '3.1'.

Zero values are not displayed in integer columns

Summary:
(for byte/short/int/big int)

BUG:395189

Test Plan: See https://bugs.kde.org/show_bug.cgi?id=395189#c1

Reviewers: piggz

Reviewed By: piggz

Subscribers: Kexi-Devel-list

Tags: #kexi

Differential Revision: https://phabricator.kde.org/D13451

M  +1    -5    src/widget/tableview/kexitextformatter.cpp

https://commits.kde.org/kexi/941cdfa753b09303cbd45f5de8db55f6e8387fd8

diff --git a/src/widget/tableview/kexitextformatter.cpp b/src/widget/tableview/kexitextformatter.cpp
index c5b6ef86b..b30114b87 100644
--- a/src/widget/tableview/kexitextformatter.cpp
+++ b/src/widget/tableview/kexitextformatter.cpp
@@ -130,7 +130,7 @@ QString KexiTextFormatter::toString(const QVariant& value, const QString& add,
         *lengthExceeded = false;
     }
     if (d->field->isIntegerType()) {
-        if (value.toInt() == 0)
+        if (!add.isEmpty() && value.toInt() == 0)
             return add; //eat 0
     }
     else if (d->field->isFPNumericType()) {
@@ -166,10 +166,6 @@ QString KexiTextFormatter::toString(const QVariant& value, const QString& add,
             return add;
         return KexiDateTimeFormatter::toString(
                    *d->dateFormatter, *d->timeFormatter, value.toDateTime());
-    case KDbField::BigInteger:
-        if (value.toLongLong() == 0)
-            return add; //eat 0
-        break;
     default:
         break;
     }
[prev in list] [next in list] [prev in thread] [next in thread]