[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [dolphin] src: Make target_link_libraries for kdeinit_dolphin PRIVATE
From:       Andreas Sturmlechner <null () kde ! org>
Date:       2018-05-18 22:36:49
Message-ID: E1fJnzV-00060J-Vw () code ! kde ! org
[Download RAW message or body]

Git commit 8e6f4eecd318041d2e4e6386d1660742dd4ddd89 by Andreas Sturmlechner=
, on behalf of Alexander Miller.
Committed on 18/05/2018 at 20:44.
Pushed by asturmlechner into branch 'master'.

Make target_link_libraries for kdeinit_dolphin PRIVATE

Summary:
There is no need to add all of kdeinit_dolphin's
dependencies (including the static archive) when
linking dolphin; kdemain is the only needed symbol.
Mark the link libraries PRIVATE to simplify the
link command for dolphin.

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: asturmlechner, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D12931

M  +1    -1    src/CMakeLists.txt

https://commits.kde.org/dolphin/8e6f4eecd318041d2e4e6386d1660742dd4ddd89

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e8fe719a43..beaa0ec500 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -299,7 +299,7 @@ ecm_add_app_icon(dolphin_SRCS ICONS ${ICONS_SRCS})
 kf5_add_kdeinit_executable(dolphin ${dolphin_SRCS})
 =

 =

-target_link_libraries(kdeinit_dolphin
+target_link_libraries(kdeinit_dolphin PRIVATE
     dolphinstatic
     dolphinprivate
 )
[prev in list] [next in list] [prev in thread] [next in thread]