[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-framework] src/plasma/private: Use "Configure %1..." for text of applet configure action
From:       Friedrich W. H. Kossebau <null () kde ! org>
Date:       2018-04-30 16:07:20
Message-ID: E1fDBKi-00072N-0O () code ! kde ! org
[Download RAW message or body]

Git commit 7c15af41387e061df46c313aed7d272e3411468c by Friedrich W. H. Kossebau.
Committed on 30/04/2018 at 16:07.
Pushed by kossebau into branch 'master'.

Use "Configure %1..." for text of applet configure action

Summary:
Follows HIG in using verb-based name, also starting the text with the most
important objective first.
As result also consistent with default text for similar action in menu of a
normal app (when using KStandardAction).

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D12562

M  +1    -1    src/plasma/private/applet_p.cpp

https://commits.kde.org/plasma-framework/7c15af41387e061df46c313aed7d272e3411468c

diff --git a/src/plasma/private/applet_p.cpp b/src/plasma/private/applet_p.cpp
index 05c05d81a..a3b1a0803 100644
--- a/src/plasma/private/applet_p.cpp
+++ b/src/plasma/private/applet_p.cpp
@@ -126,7 +126,7 @@ void AppletPrivate::init(const QString &_packagePath, const \
QVariantList &args)  
     QAction *configAction = actions->action(QStringLiteral("configure"));
     if (configAction) {
-        configAction->setText(i18nc("%1 is the name of the applet", "%1 \
Settings...", q->title().replace(QLatin1Char('&'), QStringLiteral("&&")))); +        \
configAction->setText(i18nc("%1 is the name of the applet", "Configure %1...", \
q->title().replace(QLatin1Char('&'), QStringLiteral("&&"))));  }
 
     if (!appletDescription.isValid()) {


[prev in list] [next in list] [prev in thread] [next in thread]