[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [cantor] src/backends/octave: Improve octave login
From:       Nikita Sirgienko <null () kde ! org>
Date:       2018-04-30 15:19:36
Message-ID: E1fDAaW-0002Ey-Om () code ! kde ! org
[Download RAW message or body]

Git commit 6def20294ade1783132552786aef0ef0f06c120f by Nikita Sirgienko.
Committed on 30/04/2018 at 15:19.
Pushed by sirgienko into branch 'master'.

Improve octave login

Summary: Before, when we work with octave and use 'Restart Backend' button, we \
suddenly get foreign output. So this commit fix it by adding backend cleanup of inner \
state in logout.

Test Plan:
1) Run octave backend without patch
2) Write some entries and run they
3) Reboot octave backend by the button and check, that the output changes
4) Apply patch
5) Check, that now all fine.

Reviewers: #cantor, asemke

Reviewed By: #cantor, asemke

Subscribers: #cantor, #kde_edu

Tags: #kde_edu, #cantor

Differential Revision: https://phabricator.kde.org/D12565

M  +5    -1    src/backends/octave/octavesession.cpp

https://commits.kde.org/cantor/6def20294ade1783132552786aef0ef0f06c120f

diff --git a/src/backends/octave/octavesession.cpp \
b/src/backends/octave/octavesession.cpp index 35dd4264..704991bd 100644
--- a/src/backends/octave/octavesession.cpp
+++ b/src/backends/octave/octavesession.cpp
@@ -149,7 +149,11 @@ void OctaveSession::logout()
     delete m_process;
     m_process = nullptr;
 
-    qDebug()<<"login done";
+    m_currentExpression = nullptr;
+    m_prompt = QRegExp();
+    m_tempDir.clear();
+
+    qDebug()<<"logout done";
 }
 
 void OctaveSession::interrupt()


[prev in list] [next in list] [prev in thread] [next in thread]