[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-browser-integration] extension: Call preventDefault in link click handler to avoid navigatin
From:       Kai Uwe Broulik <null () kde ! org>
Date:       2018-04-30 14:42:26
Message-ID: E1fDA0Y-0004Fu-2A () code ! kde ! org
[Download RAW message or body]

Git commit b54ab8938e18a503b57fdfb479ebc01d61a63dc1 by Kai Uwe Broulik.
Committed on 30/04/2018 at 14:42.
Pushed by broulik into branch 'master'.

Call preventDefault in link click handler to avoid navigating to #

M  +4    -2    extension/options.js

https://commits.kde.org/plasma-browser-integration/b54ab8938e18a503b57fdfb479ebc01d61a63dc1

diff --git a/extension/options.js b/extension/options.js
index 49cea2c..ba46aad 100644
--- a/extension/options.js
+++ b/extension/options.js
@@ -109,8 +109,9 @@ document.addEventListener("DOMContentLoaded", function () {
 
             var tabtarget = document.querySelector("[data-tab-id=" + tablink + "]");
 
-            button.addEventListener("click", function () {
+            button.addEventListener("click", function (event) {
                 tabClicked(tabbar, button);
+                event.preventDefault();
             });
 
             tabbar.buttons.push(button);
@@ -149,8 +150,9 @@ document.addEventListener("DOMContentLoaded", function () {
         });
     });
 
-    document.getElementById("open-krunner-settings").addEventListener("click", function () {
+    document.getElementById("open-krunner-settings").addEventListener("click", function (event) {
         sendMessage("openKRunnerSettings");
+        event.preventDefault();
     });
 
 });
[prev in list] [next in list] [prev in thread] [next in thread]