[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-desktop/Plasma/5.12] kcms/desktoptheme/package/contents/ui: [Desktop Theme KCM] Workaround b
From:       Kai Uwe Broulik <null () kde ! org>
Date:       2018-04-24 14:32:12
Message-ID: E1fAyzM-0000ye-SY () code ! kde ! org
[Download RAW message or body]

Git commit c5c756623a3495183f5b3390520ee599dd0f43c1 by Kai Uwe Broulik.
Committed on 24/04/2018 at 14:31.
Pushed by broulik into branch 'Plasma/5.12'.

[Desktop Theme KCM] Workaround bug in FileDialog

When FileDialog is created with visible set to true it will open the dialog \
immediately before its properties are set leading to a dialog with no title and \
filter.

Differential Revision: https://phabricator.kde.org/D12495

M  +1    -1    kcms/desktoptheme/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/c5c756623a3495183f5b3390520ee599dd0f43c1

diff --git a/kcms/desktoptheme/package/contents/ui/main.qml \
b/kcms/desktoptheme/package/contents/ui/main.qml index 93fdf0bd..a6928a9b 100644
--- a/kcms/desktoptheme/package/contents/ui/main.qml
+++ b/kcms/desktoptheme/package/contents/ui/main.qml
@@ -225,10 +225,10 @@ Item {
         id: fileDialogLoader
         active: false
         sourceComponent: FileDialog {
-            visible: true
             title: i18n("Open Theme")
             folder: shortcuts.home
             nameFilters: [ i18n("Theme Files (*.zip *.tar.gz *.tar.bz2)") ]
+            Component.onCompleted: open()
             onAccepted: {
                 kcm.installThemeFromFile(fileUrls[0])
                 fileDialogLoader.active = false


[prev in list] [next in list] [prev in thread] [next in thread]