[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [krita] libs/flake/commands: Fix "Break at segment" to work correctly with closed paths
From:       Dmitry Kazakov <null () kde ! org>
Date:       2018-04-24 14:20:54
Message-ID: E1fAyoQ-0007iS-FJ () code ! kde ! org
[Download RAW message or body]

Git commit 2b861ac1a7afb9719f1bcdcb8d6a2cdabeabee89 by Dmitry Kazakov.
Committed on 24/04/2018 at 14:20.
Pushed by dkazakov into branch 'master'.

Fix "Break at segment" to work correctly with closed paths

M  +3    -6    libs/flake/commands/KoPathSegmentBreakCommand.cpp

https://commits.kde.org/krita/2b861ac1a7afb9719f1bcdcb8d6a2cdabeabee89

diff --git a/libs/flake/commands/KoPathSegmentBreakCommand.cpp \
b/libs/flake/commands/KoPathSegmentBreakCommand.cpp index 7752eead2eb..e95797426aa \
                100644
--- a/libs/flake/commands/KoPathSegmentBreakCommand.cpp
+++ b/libs/flake/commands/KoPathSegmentBreakCommand.cpp
@@ -31,12 +31,9 @@ KoPathSegmentBreakCommand::KoPathSegmentBreakCommand(const \
KoPathPointData & poi  {
     if (m_pointData.pathShape->isClosedSubpath(m_pointData.pointIndex.first)) {
         m_startIndex = m_pointData.pointIndex;
-        KoPathPoint * before = m_pointData.pathShape->pointByIndex(m_startIndex);
-        if (before->properties() & KoPathPoint::CloseSubpath) {
-            m_startIndex.second = 0;
-        } else {
-            ++m_startIndex.second;
-        }
+
+        const int numPoints = \
m_pointData.pathShape->subpathPointCount(m_startIndex.first); +        \
m_startIndex.second = (m_startIndex.second + 1) % numPoints;  }
     setText(kundo2_i18n("Break subpath"));
 }


[prev in list] [next in list] [prev in thread] [next in thread]