[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwin] /: main_wayland: Don't hardcode /dev/fb0 anymore
From:       Martin_Flöser <null () kde ! org>
Date:       2018-04-22 15:53:41
Message-ID: E1fAHJ7-0008Cs-1i () code ! kde ! org
[Download RAW message or body]

Git commit e737a6193c805d8e480fdd22abe815acddafd483 by Martin Fl=C3=B6ser, =
on behalf of Nerdopolis Turfwalker.
Committed on 22/04/2018 at 15:53.
Pushed by graesslin into branch 'master'.

main_wayland: Don't hardcode /dev/fb0 anymore

Summary: Now that the framebuffer device is queried, don't assume that the =
framebuffer device is /dev/fb0

Test Plan:
Add /dev/fb1 to seat1, start kwin with the framebuffer backend on seat1, ve=
rify with the stdio/stderr output it selected /dev/fb1.
Make sure manual device selection still works

There is an issue right now where /dev/fb1 is all black, if it is both sele=
cted manually or automatically. I think I might need see if the VSCREENINFO=
 or FSCREENINFO framebuffer settings are changing or something (I had to do=
 something similar to this to Weston's fbdev backend as well)

If I do find a solution, I'll send one separate from this series

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: zzag, rkflx, graesslin, kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D9557

M  +0    -1    main_wayland.cpp

https://commits.kde.org/kwin/e737a6193c805d8e480fdd22abe815acddafd483

diff --git a/main_wayland.cpp b/main_wayland.cpp
index 59f7ed94d..0e81d6dea 100644
--- a/main_wayland.cpp
+++ b/main_wayland.cpp
@@ -589,7 +589,6 @@ int main(int argc, char * argv[])
     QCommandLineOption framebufferDeviceOption(QStringLiteral("fb-device"),
                                                i18n("The framebuffer devic=
e to render to."),
                                                QStringLiteral("fbdev"));
-    framebufferDeviceOption.setDefaultValue(QStringLiteral("/dev/fb0"));
     QCommandLineOption x11DisplayOption(QStringLiteral("x11-display"),
                                         i18n("The X11 Display to use in wi=
ndowed mode on platform X11."),
                                         QStringLiteral("display"));
[prev in list] [next in list] [prev in thread] [next in thread]