[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdeconnect-android/contacts] src/org/kde/kdeconnect/Helpers: Fix reference bug with every reply fro
From:       Simon Redman <null () kde ! org>
Date:       2018-03-31 21:31:06
Message-ID: E1f2O5a-00005c-CP () code ! kde ! org
[Download RAW message or body]

Git commit 3e72b67504148ddb01dae6dd888953f20ee70816 by Simon Redman.
Committed on 31/03/2018 at 21:31.
Pushed by sredman into branch 'contacts'.

Fix reference bug with every reply from getColumnsFromContactsForIDs getting the same \
data

M  +2    -2    src/org/kde/kdeconnect/Helpers/ContactsHelper.java

https://commits.kde.org/kdeconnect-android/3e72b67504148ddb01dae6dd888953f20ee70816

diff --git a/src/org/kde/kdeconnect/Helpers/ContactsHelper.java \
b/src/org/kde/kdeconnect/Helpers/ContactsHelper.java index 7a405cc..fda7539 100644
--- a/src/org/kde/kdeconnect/Helpers/ContactsHelper.java
+++ b/src/org/kde/kdeconnect/Helpers/ContactsHelper.java
@@ -342,10 +342,10 @@ public class ContactsHelper {
                 contactsArgs.toArray(new String[0]), null
         );
 
-        Map<String, Object> requestedData = new HashMap<>();
-
         if (contactsCursor != null && contactsCursor.moveToFirst()) {
             do {
+                Map<String, Object> requestedData = new HashMap<>();
+
                 int lookupKeyIdx = contactsCursor.getColumnIndexOrThrow(uID.COLUMN);
                 String lookupKey = contactsCursor.getString(lookupKeyIdx);
 


[prev in list] [next in list] [prev in thread] [next in thread]