[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kpmcore/kauth] src/backend: Finish d-pointerizing CoreBackend class.
From:       Andrius_Å tikonas <null () kde ! org>
Date:       2018-03-31 21:09:00
Message-ID: E1f2NkC-0007nL-PU () code ! kde ! org
[Download RAW message or body]

Git commit a83cb256cb6890588ad0e35da40dbe9d76a411cf by Andrius Å tikonas.
Committed on 31/03/2018 at 21:08.
Pushed by stikonas into branch 'kauth'.

Finish d-pointerizing CoreBackend class.

M  +17   -3    src/backend/corebackend.cpp
M  +5    -15   src/backend/corebackend.h

https://commits.kde.org/kpmcore/a83cb256cb6890588ad0e35da40dbe9d76a411cf

diff --git a/src/backend/corebackend.cpp b/src/backend/corebackend.cpp
index 9c1d42e..380ffe1 100644
--- a/src/backend/corebackend.cpp
+++ b/src/backend/corebackend.cpp
@@ -24,10 +24,9 @@
 
 #include <QDebug>
 
-class CoreBackend::CoreBackendPrivate
+struct CoreBackendPrivate
 {
-public:
-    CoreBackendPrivate() {}
+    QString m_id, m_version;
 };
 
 CoreBackend::CoreBackend() :
@@ -58,3 +57,18 @@ void CoreBackend::setPartitionTableMaxPrimaries(PartitionTable& p, qint32 max_pr
 {
     p.setMaxPrimaries(max_primaries);
 }
+
+QString CoreBackend::id() {
+    return d->m_id;
+}
+
+QString CoreBackend::version() {
+    return d->m_version;
+}
+
+void CoreBackend::setId(const QString& id) {
+    d->m_id = id;
+}
+void CoreBackend::setVersion(const QString& version) {
+    d->m_version = version;
+}
diff --git a/src/backend/corebackend.h b/src/backend/corebackend.h
index e44b740..6a61b34 100644
--- a/src/backend/corebackend.h
+++ b/src/backend/corebackend.h
@@ -30,6 +30,7 @@
 
 class CoreBackendManager;
 class CoreBackendDevice;
+class CoreBackendPrivate;
 class Device;
 class PartitionTable;
 
@@ -70,17 +71,13 @@ public:
       * Return the plugin's unique Id from JSON metadata
       * @return the plugin's unique Id from JSON metadata
       */
-    QString id() {
-        return m_id;
-    }
+    QString id();
 
     /**
       * Return the plugin's version from JSON metadata
       * @return the plugin's version from JSON metadata
       */
-    QString version() {
-        return m_version;
-    }
+    QString version();
 
     /**
       * Initialize the plugin's FileSystem support
@@ -172,17 +169,10 @@ protected:
     static void setPartitionTableMaxPrimaries(PartitionTable& p, qint32 max_primaries);
 
 private:
-    void setId(const QString& id) {
-        m_id = id;
-    }
-    void setVersion(const QString& version) {
-        m_version = version;
-    }
+    void setId(const QString& id);
+    void setVersion(const QString& version);
 
 private:
-    QString m_id, m_version;
-
-    class CoreBackendPrivate;
     std::unique_ptr<CoreBackendPrivate> d;
 };
 
[prev in list] [next in list] [prev in thread] [next in thread]