[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex/kbibtex/0.8] src: Don't overwrite first line in auto-generated header
From:       Thomas Fischer <null () kde ! org>
Date:       2018-02-28 20:58:02
Message-ID: E1er8na-0002wT-IA () code ! kde ! org
[Download RAW message or body]

Git commit 8728a732d47e0c6470e234c74bbf365bb7458ad1 by Thomas Fischer.
Committed on 22/02/2018 at 19:16.
Pushed by thomasfischer into branch 'kbibtex/0.8'.

Don't overwrite first line in auto-generated header

Two subsequent 'file(..)' commands used the keyword 'WRITE', implying that
the second invocation would overwrite the file just created in the first
invocation and as such erasing the first line of text (which just contained
a command and as such this bug had no functional issues).

M  +1    -1    src/getgit.cmake

https://commits.kde.org/kbibtex/8728a732d47e0c6470e234c74bbf365bb7458ad1

diff --git a/src/getgit.cmake b/src/getgit.cmake
index 0c73a7ba..9a7ba426 100644
--- a/src/getgit.cmake
+++ b/src/getgit.cmake
@@ -61,7 +61,7 @@ file(
     "/// This file has been automatically generated by 'getgit.cmake'.\n//=
/ Do not edit or modify it.\n\n"
 )
 file(
-    WRITE
+    APPEND
     "${BINARY_DIR}/kbibtex-git-info.h.tmp"
     "#ifndef KBIBTEX_GIT_INFO_H\n"
 )

[prev in list] [next in list] [prev in thread] [next in thread]