[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kcoreaddons] autotests: Increase timeout in the hope of fixing test failure on the CI
From:       Milian Wolff <null () kde ! org>
Date:       2018-02-06 9:37:12
Message-ID: E1eizge-0003Qc-Mg () code ! kde ! org
[Download RAW message or body]

Git commit 2cf36358fb40ae4d1c2945d28db8b4b9dc9426bd by Milian Wolff.
Committed on 06/02/2018 at 09:35.
Pushed by mwolff into branch 'master'.

Increase timeout in the hope of fixing test failure on the CI

The benchmark works fine for me on my local machine, but on the
CI the QFileSystemWatcher based benchmark fails. I suspect that
it is due to a timing issue. Let's see if that hunch is correct
by increasing the timeout.

Note: Profiling that test shows lots of low-hanging fruit in
the QFileSystemWatcher implementation. Something we should fix
upstream, notably lots of QStringList accesses which could
probably be fixed by using QSet<QString> or similar.

CCMAIL: dfaure@kde.org

M  +1    -1    autotests/kdirwatch_unittest.cpp

https://commits.kde.org/kcoreaddons/2cf36358fb40ae4d1c2945d28db8b4b9dc9426bd

diff --git a/autotests/kdirwatch_unittest.cpp b/autotests/kdirwatch_unittes=
t.cpp
index 7423327..1982c01 100644
--- a/autotests/kdirwatch_unittest.cpp
+++ b/autotests/kdirwatch_unittest.cpp
@@ -836,7 +836,7 @@ void KDirWatch_UnitTest::benchNotifyWatcher()
     QSignalSpy spy(&watch, &KDirWatch::dirty);
     QBENCHMARK {
         createDirectoryTree(dir.path());
-        QTRY_COMPARE_WITH_TIMEOUT(spy.count(), numFiles, s_maxTries * 50);
+        QTRY_COMPARE_WITH_TIMEOUT(spy.count(), numFiles, s_maxTries * 50 *=
 2);
         spy.clear();
     }
 }
[prev in list] [next in list] [prev in thread] [next in thread]