[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [okular/Applications/17.12] autotests: parttest: make the mouse selection be a few steps
From:       Albert Astals Cid <null () kde ! org>
Date:       2018-01-31 22:26:58
Message-ID: E1eh0qI-0000wC-Hz () code ! kde ! org
[Download RAW message or body]

Git commit 8a0f70cb165a1f2fdf0fc831b09e4db42584b5d7 by Albert Astals Cid.
Committed on 31/01/2018 at 22:24.
Pushed by aacid into branch 'Applications/17.12'.

parttest: make the mouse selection be a few steps

Makes it more reliable for me here

M  +11   -3    autotests/parttest.cpp

https://commits.kde.org/okular/8a0f70cb165a1f2fdf0fc831b09e4db42584b5d7

diff --git a/autotests/parttest.cpp b/autotests/parttest.cpp
index e9fe9b0eb..bce91937b 100644
--- a/autotests/parttest.cpp
+++ b/autotests/parttest.cpp
@@ -771,13 +771,21 @@ void PartTest::testeRectSelectionStartingOnLinks()
 
 void PartTest::simulateMouseSelection(double startX, double startY, double endX, \
double endY, QWidget *target)  {
+    const int steps = 5;
+    const double diffX = endX - startX;
+    const double diffY = endY - startY;
+    const double diffXStep = diffX / steps;
+    const double diffYStep = diffY / steps;
+
     QTestEventList events;
     events.addMouseMove(QPoint(startX, startY));
     events.addMousePress(Qt::LeftButton, Qt::NoModifier, QPoint(startX, startY));
+    for (int i = 0; i < steps - 1; ++i) {
+        events.addMouseMove(QPoint(startX + i * diffXStep, startY + i * diffYStep));
+        events.addDelay(100);
+    }
     events.addMouseMove(QPoint(endX, endY));
-    // without this wait the test fails. 100ms were enough on my local system, but \
                when running under valgrind
-    // or on the CI server we need to wait longer.
-    events.addDelay(1000);
+    events.addDelay(100);
     events.addMouseRelease(Qt::LeftButton, Qt::NoModifier, QPoint(endX, endY));
 
     events.simulate(target);


[prev in list] [next in list] [prev in thread] [next in thread]