[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdeplasma-addons] applets/comic: [comic applet] Use KNotification::event() variant with theme icon 
From:       Friedrich W. H. Kossebau <null () kde ! org>
Date:       2018-01-31 22:25:28
Message-ID: E1eh0oq-0007ys-Rp () code ! kde ! org
[Download RAW message or body]

Git commit 1675fc86771480c9f3cc61f89082a978061e011e by Friedrich W. H. Koss=
ebau.
Committed on 31/01/2018 at 21:34.
Pushed by kossebau into branch 'master'.

[comic applet] Use KNotification::event() variant with theme icon name

Allows rendering-to-pixel by notification displayer and avoids dep
on KF5::IconThemes

M  +0    -1    applets/comic/CMakeLists.txt
M  +1    -2    applets/comic/comic.cpp

https://commits.kde.org/kdeplasma-addons/1675fc86771480c9f3cc61f89082a97806=
1e011e

diff --git a/applets/comic/CMakeLists.txt b/applets/comic/CMakeLists.txt
index f99944383..58063c9cb 100644
--- a/applets/comic/CMakeLists.txt
+++ b/applets/comic/CMakeLists.txt
@@ -31,7 +31,6 @@ target_link_libraries(plasma_applet_comic
                       KF5::KIOWidgets
                       KF5::NewStuff
                       KF5::Notifications
-                      KF5::IconThemes
                       KF5::Archive)
 =

 =

diff --git a/applets/comic/comic.cpp b/applets/comic/comic.cpp
index 823fbafb5..4656e5519 100644
--- a/applets/comic/comic.cpp
+++ b/applets/comic/comic.cpp
@@ -42,7 +42,6 @@
 #include <KNewStuff3/KNS3/DownloadDialog>
 #include <KRun>
 #include <KStandardShortcut>
-#include <KIconLoader>
 =

 #include <Plasma/Containment>
 #include <Plasma/Package>
@@ -476,7 +475,7 @@ void ComicApplet::slotArchive( int archiveType, const Q=
Url &dest, const QString
 void ComicApplet::slotArchiveFinished (KJob *job )
 {
     if ( job->error() ) {
-        KNotification::event( KNotification::Warning, i18n( "Archiving com=
ic failed" ), job->errorText(), QIcon::fromTheme(QStringLiteral("dialog-war=
ning")).pixmap(KIconLoader::SizeMedium));
+        KNotification::event(KNotification::Warning, i18n("Archiving comic=
 failed"), job->errorText(), QStringLiteral("dialog-warning"));
     }
 }
 =


[prev in list] [next in list] [prev in thread] [next in thread]