Git commit c48860f00d842668ac6d3d9cacdebd9035c8535e by Laurent Montel.
Committed on 31/01/2018 at 21:22.
Pushed by mlaurent into branch 'master'.
Coding style
M +0 -2 autotests/emojimanagertest.cpp
M +4 -2 autotests/textconvertertest.cpp
M +6 -6 src/emoji.cpp
M +0 -1 src/rocketchataccount.cpp
M +2 -0 src/rocketchatmessage.cpp
M +1 -1 src/user.cpp
M +0 -1 src/user.h
M +0 -1 src/utils.cpp
https://commits.kde.org/ruqola/c48860f00d842668ac6d3d9cacdebd9035c8535e
diff --git a/autotests/emojimanagertest.cpp b/autotests/emojimanagertest.cpp
index 7018946..2873f1e 100644
--- a/autotests/emojimanagertest.cpp
+++ b/autotests/emojimanagertest.cpp
@@ -84,7 +84,6 @@ void EmojiManagerTest::shouldGenerateHtml()
//It exists
QCOMPARE(manager.html(QStringLiteral(":react_rocket:")), QStringLitera=
l(""));
=
-
QCOMPARE(manager.html(QStringLiteral(":totoro:")), QStringLiteral(""));
=
//Test aliases
@@ -113,5 +112,4 @@ void EmojiManagerTest::shouldChangeServerUrl()
serverUrl =3D QStringLiteral("www.bla.org");
manager.setServerUrl(serverUrl);
QCOMPARE(manager.html(QStringLiteral(":react_rocket:")), QStringLitera=
l("").arg(serverUrl));
-
}
diff --git a/autotests/textconvertertest.cpp b/autotests/textconvertertest.=
cpp
index baf6740..45ab78c 100644
--- a/autotests/textconvertertest.cpp
+++ b/autotests/textconvertertest.cpp
@@ -60,12 +60,14 @@ void TextConverterTest::shouldConvertTextWithEmoji_data=
()
<< QStringLiteral("")
<< QStringLiteral("www.kde.or=
g");
QTest::newRow("customemojiwithmanager2") << QStringLiteral(":totoro::t=
otoro:")
- << QStringLiteral("<=
img height=3D'22' width=3D'22' src=3D'http://www.kde.org/emoji-custom/totor=
o.gif'/>")
+ << QStringLiteral(
+ "")
<< QStringLiteral("www.kde.or=
g");
=
//Use server with http://
QTest::newRow("customemojiwithmanager2") << QStringLiteral(":totoro::t=
otoro:")
- << QStringLiteral("<=
img height=3D'22' width=3D'22' src=3D'http://www.kde.org/emoji-custom/totor=
o.gif'/>")
+ << QStringLiteral(
+ "")
<< QStringLiteral("http://www=
.kde.org");
//TODO add alias support too
}
diff --git a/src/emoji.cpp b/src/emoji.cpp
index bcb7879..d78d0ff 100644
--- a/src/emoji.cpp
+++ b/src/emoji.cpp
@@ -33,7 +33,7 @@ Emoji::~Emoji()
=
bool Emoji::hasEmoji(const QString &identifier) const
{
- return ((mEmojiIdentifier =3D=3D identifier) || mAliases.contains(iden=
tifier));
+ return (mEmojiIdentifier =3D=3D identifier) || mAliases.contains(ident=
ifier);
}
=
void Emoji::parseEmoji(const QJsonObject &emoji)
@@ -138,11 +138,11 @@ QString Emoji::name() const
=
bool Emoji::operator=3D=3D(const Emoji &other) const
{
- return (mName =3D=3D other.name()) &&
- (mExtension =3D=3D other.extension()) &&
- (mIdentifier =3D=3D other.identifier() &&
- (mAliases =3D=3D other.aliases()) &&
- (mEmojiIdentifier =3D=3D other.emojiIdentifier()));
+ return (mName =3D=3D other.name())
+ && (mExtension =3D=3D other.extension())
+ && (mIdentifier =3D=3D other.identifier()
+ && (mAliases =3D=3D other.aliases())
+ && (mEmojiIdentifier =3D=3D other.emojiIdentifier()));
}
=
Emoji &Emoji::operator=3D(const Emoji &other)
diff --git a/src/rocketchataccount.cpp b/src/rocketchataccount.cpp
index 8cdc72b..e498748 100644
--- a/src/rocketchataccount.cpp
+++ b/src/rocketchataccount.cpp
@@ -658,7 +658,6 @@ void RocketChatAccount::parseOtr(const QJsonArray &cont=
ents)
const Otr t =3D mOtrManager->parseOtr(contents);
qDebug() << " void RocketChatAccount::parseOtr(const QJsonArray &conte=
nts)"<