[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [falkon] src/lib/webtab: WebTab: Correctly reparent children in destructor
From:       David Rosca <null () kde ! org>
Date:       2018-01-31 20:10:36
Message-ID: E1egyiK-0002Fo-Kv () code ! kde ! org
[Download RAW message or body]

Git commit 8fe53f1c2cee8c0da10e8bf1a189274ba697ce65 by David Rosca.
Committed on 31/01/2018 at 19:55.
Pushed by drosca into branch 'master'.

WebTab: Correctly reparent children in destructor

M  +2    -1    src/lib/webtab/webtab.cpp

https://commits.kde.org/falkon/8fe53f1c2cee8c0da10e8bf1a189274ba697ce65

diff --git a/src/lib/webtab/webtab.cpp b/src/lib/webtab/webtab.cpp
index 42d99367..25b23408 100644
--- a/src/lib/webtab/webtab.cpp
+++ b/src/lib/webtab/webtab.cpp
@@ -184,7 +184,8 @@ WebTab::~WebTab()
         emit m_parentTab->childTabRemoved(this);
     }
 
-    for (WebTab *child : qAsConst(m_childTabs)) {
+    const auto childTabs = m_childTabs; // modified in loop
+    for (WebTab *child : childTabs) {
         child->setParentTab(nullptr);
     }
 }

[prev in list] [next in list] [prev in thread] [next in thread]